From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3B5C048C24 for ; Tue, 23 Jan 2024 05:40:33 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 40D7368CF92; Tue, 23 Jan 2024 07:40:30 +0200 (EET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6E0FB68C353 for ; Tue, 23 Jan 2024 07:40:23 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1705988429; x=1737524429; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=I26LjnYv3HAj78hemN2f4dSna9N+z4rKg032bI3Pf1c=; b=cOkrxUOr9aCcgcswjw+Tyomp8vhWHoxvrwoIHrY/juy+K3k9UhFDqOZP DtSabHzcq7qAhWj1B5ky22FUCN6ZudkbY5dS8UxDxz1/26HNPlc/kWvU9 ZSzLETFBukhmNR6TAOQZAvyPWAglamNRRlPRIy+4+sc0oCVkKcqpoGBFB Fbx7WHZt7Vq1sVDRiL+tWmDpN0Nu01aPz+Gg7HScRR2EWGMhn81I2D0no abO8D9XytTh6Kz0rYDpx/SVE+iJyHOqusSt4rwRzoh1FTi4dkviC3muwO bNT8caQ8waoCveuHXuQme6cOsfO+uGsByF3ACNdadyn50CHWLWA6riTeN g==; X-IronPort-AV: E=McAfee;i="6600,9927,10961"; a="8073284" X-IronPort-AV: E=Sophos;i="6.05,213,1701158400"; d="scan'208";a="8073284" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jan 2024 21:40:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10961"; a="785927161" X-IronPort-AV: E=Sophos;i="6.05,213,1701158400"; d="scan'208";a="785927161" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 22 Jan 2024 21:40:13 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 22 Jan 2024 21:40:12 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 22 Jan 2024 21:40:12 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.168) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 22 Jan 2024 21:40:12 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BBHza2E/gMS4wDw7fSqObFsacZpBWDneUyoX558SbVw7ju4uFaWIevEobMT2vxIpltn7K0TXQ+JupMNda3hqLaiBqLzCHhZoSPv0O0wc2GuJjxXqDLONeKhQrFbGkBbQ4fVZFhJE8BPMgQiBfa4fEEznlJSseoyGeQDnX+R2TxfQi/Xp+BlQ7CSG6LxGgFYYlOcgSSFKtsQSUVFvmFCGkbXmAuH8AR47reUdAUvW+5G+uSL55mLNNJfXmK70djfzvP14FfOlvzs1p8LDus8iDbzp7sTwWzjjllZNCZ75FtcA+U+GpxpGyOXK1BSHF0DkEXIyS5lEmoDWXD37PBq9AQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4E4VACCfXupjMwhXQrJpAMfd9A6Bc2FLl8d+YD1fcdM=; b=f8zETAZL26x9IjWYzGtOevCkpWqVVwPrAwypkplj2FoqkxJcKLLwWB2OQUNvEajvJIoLZ5ICzNtb76TaWvCzp0uS9Jpphuu+2HwaG3a5BD6hK+GJcr7QMEOL9n7FJuEj31LAUn8nzchezbr+eyIQZkZJU4C8H8R89RbMWpkgRUiB4XzKN/g/ZwHHvtNuk4EwA0vmpA0TOSKKbeDKIBeoRtY1FNEb+nobZ/96FTtxuc/3u+NDE+sMh/Mshi7HnHA4ph5icIYY76923d7Ig6HT4lnKdCmZy37DiwpkwOWH0yhP5vLtQyRsv+XXKGx9bRTUVvH6Xc38MSyjfejy5WUqzA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CH3PR11MB8659.namprd11.prod.outlook.com (2603:10b6:610:1cf::5) by CH0PR11MB5563.namprd11.prod.outlook.com (2603:10b6:610:d6::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.34; Tue, 23 Jan 2024 05:40:10 +0000 Received: from CH3PR11MB8659.namprd11.prod.outlook.com ([fe80::37b4:8d26:68d0:9935]) by CH3PR11MB8659.namprd11.prod.outlook.com ([fe80::37b4:8d26:68d0:9935%4]) with mapi id 15.20.7202.035; Tue, 23 Jan 2024 05:40:10 +0000 From: "Wu, Tong1" To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH 7/9] avutil/hwcontext_d3d12va: add Flags for resource creation Thread-Index: AQHaTX1a0wtxz5IAHUeyULgOIF0ae7Dm3mww Date: Tue, 23 Jan 2024 05:40:10 +0000 Message-ID: References: <20240122055756.1142-1-tong1.wu@intel.com> <20240122055756.1142-7-tong1.wu@intel.com> <52035da0-1c0a-48fc-8846-6f2705230fb3@jkqxz.net> In-Reply-To: <52035da0-1c0a-48fc-8846-6f2705230fb3@jkqxz.net> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR11MB8659:EE_|CH0PR11MB5563:EE_ x-ms-office365-filtering-correlation-id: aff3fc15-a15f-4960-6453-08dc1bd5c36e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fIJ5ilwKT++32fYwik1ctetDaZZv0ojCppQGNQBskgalzHEB851ELr3SAd1HGZMleJY7LVfS0sic2AohDJsj2VK4bVh7XBKCotsa/6hFX23LeSysSDZeu6TnRZ04zH5XsqlJkCK2BXZRMDolrWj/YPPz6fkOcWEvt2iOzops1kOY65LtKLBrveQXOMzGeHLf2ckR3gajzBq0qt+UlC8olgXMbDXc+KYGQK0/ncusDLWf8DktZZS4zewS7W3tETiZZRqFg3sE7Dp4dLe58jvGusGeIqLpKYQxlMCrXyt+34kJon8HHOVbhL1dKkExWzToR8AVZGk2K8j0b+fUzmhzntSIfcT5CUQ/db5AnNtkk9clrWpgL3m91FAd5wv1BckanpePfvqH0oX9/MnWJx139p66buZd/+5/5Sulh/FMEiCsjrASM5QZCYBxq8TI6AZCG/r7xaJZg1c2HdN2usBfGXBTbOoPSGWUpxDz1xDECP+wtDeB431neBC4JN2y+1jEe98hrGLgaELjSP/YybUSXA7GePOSgfC7jKbBxRM9DOK6BxHISQmbaWsPa08rSEH9JqBFq6Ne/SoGNA0f86ZxztLqACuY62783PnH280wfW4= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR11MB8659.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(396003)(366004)(376002)(136003)(39860400002)(230922051799003)(64100799003)(186009)(451199024)(1800799012)(66899024)(55016003)(6506007)(71200400001)(7696005)(26005)(9686003)(122000001)(38070700009)(86362001)(38100700002)(33656002)(82960400001)(41300700001)(52536014)(19627235002)(83380400001)(8936002)(2906002)(478600001)(5660300002)(66446008)(8676002)(66556008)(66946007)(64756008)(316002)(66476007)(6916009)(76116006); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Dh209b7Rl60I6TnTvSujhb7q3m0DOB7zjE0Vvm0qcoK5AWNHfASPYPbtowxR?= =?us-ascii?Q?vuI91ZUTpSTHm1IqGQ5gTTfyIr5tbhuc4nmUcc5Z1aFikJZB+cKTw2KyU3PK?= =?us-ascii?Q?EpzS2idaX8Auoih4nxICXWVO/ok9NkhFl9tUTzYe/I6+9z/UdPiaOAd22HRe?= =?us-ascii?Q?EGNOG9iWF2sbnPwUPkRfw4AsO/oqzMnnRJopjwPK8yxtdJ70cQjSlocdCHAe?= =?us-ascii?Q?5g3xCP6JJ/Fa2k0Qlc3bUY9V21K1HQYNFrkHYsN407tMK3yGxDYD0jugnGAy?= =?us-ascii?Q?lIk2rVEV50rwQKZluKWFmjxRDThIB4gyFNWXyAsSCyuQH/cw5sDKthdLfS9l?= =?us-ascii?Q?FkYOFmdPmvrgt5Q1daYknBxCOZ0EeD6OXDaClrniefe6fB704h0CgYAXI/iq?= =?us-ascii?Q?OYg6mTHvT+AQJhwO1z5Qkwrg4OAcDLPWWPIwUzyrgFCY3g1Vnxzf/qAHXOH8?= =?us-ascii?Q?cEqFsjPAiiLzqd4AL+sJBbJgnM/teesCg+ylArjFtCU5uVfvBPTbXmEcRRaL?= =?us-ascii?Q?hHF0Ko68iOvXLOPAe9OEdA+llBzYgYaF5jMov2BS6wug3TrtJisULsfA+/1A?= =?us-ascii?Q?mucgaHNwYdfcw/P5guobSxKYQbFWyAoh01kofiXDgvK1cpYAMsRl6ch6vX3Q?= =?us-ascii?Q?yo2FCsGXNkD+w1nW+ZtPw9t8b+NNg90wOBRtcSMdXCSoK34k3QiEmesl0wPB?= =?us-ascii?Q?SiPY1zuzyEo440euP2F+KJVDjolcjfAAfQJtyMKwXCLKfC3niM0ZPSzkzkSZ?= =?us-ascii?Q?S86yKRQSqiVYapFK2CmAov32B3xEtCDexvWmkbGa7veBjYt2X+/4OCEwhgxL?= =?us-ascii?Q?2+QEIOQSqKso8X5lSwbMnplj3CGUtrYqylg/UfBPymkmYw0w1rUSgAnPbBaI?= =?us-ascii?Q?7kBwICfTjNYiTbXDKBn7kqMdiMn51hb4i/KE9VS5u+D4uShmvMt/I9tAHdsK?= =?us-ascii?Q?c8yW2EmiVWsqHzjHcl91Vwjo9YhcSrq2Ypxcl8PLX/IE7yIoo69+0HjpijEQ?= =?us-ascii?Q?RWGX4MdxSipsR4YlXXcQ+bCdwHYVNMFkxulF6wuvE5YHTKw3dkx/AHnjueOK?= =?us-ascii?Q?XaS89fNn19IutSN8EVLLrbeiHJZn/CZRUDfYaV863iHXunZSnxCPsY/ul+Nv?= =?us-ascii?Q?EqzSEeiOAra1GYRg/vw0v6cr3/QFA+Pf5kMqq6s8MpxDr3XD9XFFtK1okEg8?= =?us-ascii?Q?6Dhgrh2T0epYoPJxKUhoHX5ffGp7XaSD0n7gNriuQdRToF/95YmNF1Xwvpcj?= =?us-ascii?Q?oXsXoqTp3sxLH4Hr+1Ui1HHs0PQehwQTkRwMkzyHtit1nZdRiJY3I4SaBrPB?= =?us-ascii?Q?PTr+toquV4qgomhS0EH368L8KdR8NLmM29mB0dahITFBRg93574GQ+7sSWIh?= =?us-ascii?Q?AWS9KN5LW8t1k8YJEQrdnw/qK1lII8x88hYwl9UtIHVbeJg3l88mcRi9W3DV?= =?us-ascii?Q?4fsaTF2ppVbpQlXHbhr4kJ95lt/QNA3bBn+/dyV0WCCAQW17wfha5OZGKw3y?= =?us-ascii?Q?GVntzd8KmWlJ/zgbAdmL1Atq7EXoMBCjJjbi5JmVnCFgh1zTCX6zodwzGOc1?= =?us-ascii?Q?L0vHPt9NQ2bmdKRyUoY=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR11MB8659.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: aff3fc15-a15f-4960-6453-08dc1bd5c36e X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jan 2024 05:40:10.0223 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zReELxYLclntlu0RMxKz5hOB2koeK215J8+BAVp6Akp9ju5eDzbeW81IiNdTmcmmuRP2th4g8CXunsnybgQTPA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5563 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH 7/9] avutil/hwcontext_d3d12va: add Flags for resource creation X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: >From: ffmpeg-devel On Behalf Of Mark >Thompson >Sent: Tuesday, January 23, 2024 5:52 AM >To: ffmpeg-devel@ffmpeg.org >Subject: Re: [FFmpeg-devel] [PATCH 7/9] avutil/hwcontext_d3d12va: add Flags >for resource creation > >On 22/01/2024 05:57, tong1.wu-at-intel.com@ffmpeg.org wrote: >> From: Tong Wu >> >> Flags field is added to support diffferent resource creation. >> >> Signed-off-by: Tong Wu >> --- >> doc/APIchanges | 3 +++ >> libavutil/hwcontext_d3d12va.c | 2 +- >> libavutil/hwcontext_d3d12va.h | 5 +++++ >> libavutil/version.h | 2 +- >> 4 files changed, 10 insertions(+), 2 deletions(-) >> >> diff --git a/doc/APIchanges b/doc/APIchanges >> index e477ed78e0..a33e54dd3b 100644 >> --- a/doc/APIchanges >> +++ b/doc/APIchanges >> @@ -2,6 +2,9 @@ The last version increases of all libraries were on 2023-02- >09 >> >> API changes, most recent first: >> >> +2024-01-xx - xxxxxxxxxx - lavu 58.37.100 - hwcontext_d3d12va.h >> + Add AVD3D12VAFramesContext.Flags >> + >> 2023-11-xx - xxxxxxxxxx - lavfi 9.16.100 - buffersink.h buffersrc.h >> Add av_buffersink_get_colorspace and av_buffersink_get_color_range. >> Add AVBufferSrcParameters.color_space and >AVBufferSrcParameters.color_range. >> diff --git a/libavutil/hwcontext_d3d12va.c b/libavutil/hwcontext_d3d12va.c >> index 414dd44290..0d94f48543 100644 >> --- a/libavutil/hwcontext_d3d12va.c >> +++ b/libavutil/hwcontext_d3d12va.c >> @@ -237,7 +237,7 @@ static AVBufferRef *d3d12va_pool_alloc(void >*opaque, size_t size) >> .Format = hwctx->format, >> .SampleDesc = {.Count = 1, .Quality = 0 }, >> .Layout = D3D12_TEXTURE_LAYOUT_UNKNOWN, >> - .Flags = D3D12_RESOURCE_FLAG_NONE, >> + .Flags = hwctx->Flags, > >This seems like a hole in the existing decoder implementation? How does it >work without making >D3D12_RESOURCE_FLAG_VIDEO_DECODE_REFERENCE_ONLY textures when >required by the device? For current decoder implementation it applies to most devices and it's indeed not supported when driver requests this REFERENCE_ONLY flag. It seems that I haven't met this request in my working environment. We may add it later if needed. > >> }; >> >> frame = av_mallocz(sizeof(AVD3D12VAFrame)); >> diff --git a/libavutil/hwcontext_d3d12va.h b/libavutil/hwcontext_d3d12va.h >> index ff06e6f2ef..dc1c17d3f9 100644 >> --- a/libavutil/hwcontext_d3d12va.h >> +++ b/libavutil/hwcontext_d3d12va.h >> @@ -129,6 +129,11 @@ typedef struct AVD3D12VAFramesContext { >> * If unset, will be automatically set. >> */ >> DXGI_FORMAT format; >> + >> + /** >> + * This field is used for resource creation. > >This documentation could be better. Used to do what? Can it not be set, and >what is the behaviour if it isn't? Will update in V2. > >> + */ >> + D3D12_RESOURCE_FLAGS Flags; > >Use lowercase for structure elements. > >> } AVD3D12VAFramesContext; >> >> #endif /* AVUTIL_HWCONTEXT_D3D12VA_H */ >> diff --git a/libavutil/version.h b/libavutil/version.h >> index 772c4e209c..3ad1a9446c 100644 >> --- a/libavutil/version.h >> +++ b/libavutil/version.h >> @@ -79,7 +79,7 @@ >> */ >> >> #define LIBAVUTIL_VERSION_MAJOR 58 >> -#define LIBAVUTIL_VERSION_MINOR 36 >> +#define LIBAVUTIL_VERSION_MINOR 37 >> #define LIBAVUTIL_VERSION_MICRO 101 >> >> #define LIBAVUTIL_VERSION_INT >AV_VERSION_INT(LIBAVUTIL_VERSION_MAJOR, \ > >It's not good to be changing the user-facing API like this. Are there any more >properties here which really should be user-visible? Adding them one at a >time later would be very unfortunate and make compatibility harder. > >Thanks, > >- Mark AFAIK, I don't think there're more properties that need to be added one by one in a short time. It's going to be just this one that is really needed since we have to give specific flags for recon frames creation during encoding. Thanks for the opinions and I'll update those in next version. Best Regards, Tong >_______________________________________________ >ffmpeg-devel mailing list >ffmpeg-devel@ffmpeg.org >https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > >To unsubscribe, visit link above, or email >ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".