From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 62244489A4 for ; Wed, 22 May 2024 01:30:19 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 36B3568D4B7; Wed, 22 May 2024 04:29:36 +0300 (EEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6A45668D3E9 for ; Wed, 22 May 2024 04:29:33 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1716341374; x=1747877374; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=ucd2u5BNQj3r6g/hBlVDM3y5v8pLJDSg5m0i1r4KPvY=; b=LAbilDo89ULrzhS+gzJAxkL5l6yGecqJaLIuXO2/0xkK93QCFDOJqw/u 1sxCxRXuGlmSzNgkeWKGQ1eYpIhZzVwoOp3oCwP6Xk/KHLc9Us42NTqh0 nZDthbG2DFr/24cOv99T65bALcomb2kYgAQdJhr85T8L63xv4E3Ig7VJj mf8T647V7VED30+GZGBCs/4+dKXfbo5G4HkwdTqMTXGnz4y3DuBlU3b1I jwnQwqNUqwgQ7P5MO8Azn/shJrdSZBEnJSEMmNXHXxBqVbFQKEHZ8JLgd 36yQNoJo0B8qQ+UO8FsR5tioV/uZhR7JQUQrqIS5BFOC6zuJK3bsskRfZ g==; X-CSE-ConnectionGUID: +1ppYP4STtWrvJ52KuGPFQ== X-CSE-MsgGUID: 0ym6UDdZS/q+gYKV9s7/6g== X-IronPort-AV: E=McAfee;i="6600,9927,11079"; a="23973449" X-IronPort-AV: E=Sophos;i="6.08,179,1712646000"; d="scan'208";a="23973449" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 May 2024 18:29:32 -0700 X-CSE-ConnectionGUID: Fp6coXFTSpO20iz/oA1qhA== X-CSE-MsgGUID: ynP2nV1/TQShiQKQ16HloQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,179,1712646000"; d="scan'208";a="33645785" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orviesa008.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 21 May 2024 18:29:32 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 21 May 2024 18:29:31 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 21 May 2024 18:29:31 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 21 May 2024 18:29:31 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 21 May 2024 18:29:31 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f1xhF8Y1deGOL9Yg7OnU1zsd5fw3qWZfcUWL5nopVvqUCk2JsQH2BCN11FGB7zXqjkG/lHYK3dYz9jtEbNzmiCK5V59kUmzjoBIMVXO9CCwa58YKbA8nYAmigTtyYWvHnqKKuRNokrPb/kkPgJTKQoqouhScAlmtQo3K5vSYQtWkUX8ce5ELrIeBMdu/TV1lAhLIH7IbW0cmXo0kRBlN3IGLLDka0U9RtO0A49E+i0YNSAhs3dk5/KYw4+aboUntnLER1M9bMg250P44jazvHHC5/MAIcRRKSpCyxVQGJlxajWaCIeuB95ish1uIhERAfBR8ZSwqOo8tDdkJS2crRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CsBPGJFOwO++w2R5zyO23hi9OD4IudD1yp672zqJHtk=; b=OwnZEx2yd/Ye9itMaSDE4cQEK9cNkee4OpjR7jgk0FLR0aX+7RlLwm0z/wv4tzTCDbBg+X3jIQiSX1MGHVuXThnW1DY05UtuhEp1fSseQigBfqZYz4PatZMHd+xdRNFowZLNGH/+49J2z/Yq0JMLclacwNQAToPoVghDA5FFw0Bh4JpGzKkSon/miwheBv3BWoGrjtL4ndudvV/Mvpz/OlqWIowCovetIFuoLAevRusZeMbgjirKYXychFIYsX5AROSM6xM05haGo0wgi9/SehkE98gg0/YATMKcdmtUBxzIQs5xjWRMG6ZPESDd7wdEQk7bWCVOjBMSeu6tRd6qLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CH3PR11MB8659.namprd11.prod.outlook.com (2603:10b6:610:1cf::5) by BL1PR11MB5239.namprd11.prod.outlook.com (2603:10b6:208:31a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.36; Wed, 22 May 2024 01:29:29 +0000 Received: from CH3PR11MB8659.namprd11.prod.outlook.com ([fe80::7037:678a:eb45:ac6c]) by CH3PR11MB8659.namprd11.prod.outlook.com ([fe80::7037:678a:eb45:ac6c%3]) with mapi id 15.20.7587.035; Wed, 22 May 2024 01:29:29 +0000 From: "Wu, Tong1" To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH v9 11/13] avutil/hwcontext_d3d12va: add Flags for resource creation Thread-Index: AQHaq5yIS/JIX4Wdm0SbpMJTmuXrdLGid5Bw Date: Wed, 22 May 2024 01:29:29 +0000 Message-ID: References: <20240520145222.291-1-tong1.wu@intel.com> <20240520145222.291-11-tong1.wu@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR11MB8659:EE_|BL1PR11MB5239:EE_ x-ms-office365-filtering-correlation-id: 21159936-5ef4-40e7-bcac-08dc79fe9fea x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230031|366007|376005|1800799015|38070700009; x-microsoft-antispam-message-info: =?us-ascii?Q?N7mhAvkBQ9LasYRGdZsly7y0HTD+8FWyoFTDRjWvSV1g1a/N+6OZ2CTnOVyu?= =?us-ascii?Q?93zO5MuBmEfjXxMF397GaevnwVRELBzjlM27BR+QfOsUwsldUX0EJlDBgvSL?= =?us-ascii?Q?lzxU1sj+G9rAGdJjnCDHvDD22KtxAutexOhqbSTo6e/AjQGgHKxG5jFXoFA5?= =?us-ascii?Q?aUf1hglmKJ/oyDnCN+0BbYeDHiOJPTKS82U5nJJtMRg2GKggWg2vE/kPlD0I?= =?us-ascii?Q?isf5aL8nFYbwEjkR4Az0tpOkFU44mbt3IbhpkyW7MGSSHx7ACVHz/PmbxhQr?= =?us-ascii?Q?pi3pNKfy78mIrCIprba0HAcmcADRmpxlRC6bqJ/n1259cnwRgb81ZCUq2AUC?= =?us-ascii?Q?KsBOzThREmbmy+Lxlu9hrpFmzs6LxZeKM1ktTTfoOhq6e9gR0rgST/JpZC4F?= =?us-ascii?Q?DxY+vVXATKJQ5uu36/HnQifLOWJBG9XqcfyPPEREoArskJVn6n9hQmfzgQii?= =?us-ascii?Q?IHvOW8hORx1+C15iXABHNbfhSqWCPyYBMKCl8xJm7xSM2RQyTnNWkduFtpEl?= =?us-ascii?Q?i8pUsAr3sElllRuy3qBg94eTvybz6VnSj7ImNNJnk/hbQp7en+ltYh6bw787?= =?us-ascii?Q?0aTHhwTRQos4FLRZFIJ+D93i7qVeMVV2tfaL6NkrMvtfcTq2H9WzbMaiSwdW?= =?us-ascii?Q?13nBgmxosfuMdG4dKdT0QukcsrB5W8ZT0L70f6lFkjSFEuqzUvvd2Dh5Ds95?= =?us-ascii?Q?m5FRtKqKw1XZfrRoe4SbWDG3wslhHM4DIZ2DMhnNb+tBTyoQO7qGnG7dlDAF?= =?us-ascii?Q?1bmzWrtvD09cEpu3aaBAxzDZJf1C5MN6n+hsARL19mVANDUUIgPmVRY0jMxQ?= =?us-ascii?Q?hZs+QRXNIkcB1WvXg11YE0Hkbbv/qNkk0OabSx3pIu0KX5BNWrz3rxV9yQ5X?= =?us-ascii?Q?4Usy/7oXUsn+WCXwPyP6ICIdSjWc18KFCPmy1G9BuA7cm/zU//jRBTWlwqm1?= =?us-ascii?Q?VcwSUeEi/6eU1QnuCQJXu2paDdT7YTQAwv7hG+UxwUytM/9tywhw3af+lPay?= =?us-ascii?Q?N+gOwjiaE3z/KlxuQy2apkj7PCTJCNLoeHdT155wYJc/vVIoI48cXa9ZTsg3?= =?us-ascii?Q?a5xX1BrxYITxJIqgw3SDug/lTomNlcs6Q+Zdcszmdnrm8iGPfFZvZ6+4WDZ0?= =?us-ascii?Q?9vU2jtL7q9nFdYNTq8iTX77rtO37GMy90KwuWWDV6agyPof0Id2cw4G2gpWO?= =?us-ascii?Q?fvfC5Q35c5CODVWlEbCYyyATKEHuIVFWeFsNbvCQPB+B1rjTBFhcx5FC8LHM?= =?us-ascii?Q?KzwFEVinM3YMySQqVXFVYCfkw5X+EcEYyOidBtUNnQ=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR11MB8659.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366007)(376005)(1800799015)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?etoA0UwLoycxUn7hgQLIV3LVm9dnZb2bjwSuMLWF6yhekf116bytSKZhuPzq?= =?us-ascii?Q?nUOaStW2oS1kXqN+nMgK1w1H1X5WVfK/FqTgSjs9jrQqQbray7dHZ5qrv2ZK?= =?us-ascii?Q?Op/chRl1fvE4+NU8lCzEXcxQNFRHupo2+8CYwS8vYMTP5xvxI4zfb5EcXokU?= =?us-ascii?Q?g6JvgLiFWrg5oV/3e5b/0Vh+jL/IM1Ub4SbMoFgUFpLR47S2ox6tS7Ur0/DN?= =?us-ascii?Q?GJh+MefF8gCjMYuJv3CPeV7i7gOYb/U4K/SyrYDzMcVmJqbFI+S7zdkYS2rk?= =?us-ascii?Q?NFzAtO1qU/1hVv8HhhxoGdV1K+IRD2zbUCFEmxY27oIhGVcdGqFXFY1/edOZ?= =?us-ascii?Q?TUZO2JJjyexElRkX0IukLzwxByeYqwoMBo+vOyy8Q6+JV8pLXZ8E6Gh814ez?= =?us-ascii?Q?PL6HaAGL4nz3vxw41DGVLHcCrNLwZCdx9RTg9IRK8uPDrLdU2EjqHO3Lg31W?= =?us-ascii?Q?tcfMn7inxUW6H7YiT6t63iQ9Vz075mi92OoUgPYqpAA5uSZWNuAejLCoNuCh?= =?us-ascii?Q?ItQVTQeveYPoBVYo3gRh7Jz7PaQo6zlNK4tS/M8/EIJOnigxl1PIugoTMwGv?= =?us-ascii?Q?NTaqnqh3V7cCWDXLcK69pExfhXAE9F6MIPbxr/1bsgvxym8DW8U6uXaTUtJL?= =?us-ascii?Q?7OYGR57z1q6uK6qg5jXOQE3BRcBOZkcsdOMj+hF25lgEIgSjbbvNDDqa/gjV?= =?us-ascii?Q?TaynAjZHvpGvQg8630Wr4hw1ow5zI6tLllQzcjS4s2a73n2MQjGOcLqPCDra?= =?us-ascii?Q?oTkAFP/GWPGtWsP1weCd9bbedaWxv0m/1w3Wu3CNrZo0BMtQoDXwoWz+ulQ4?= =?us-ascii?Q?ELvHY9VMFrckLOJdZCdsnIDBFm1vayoHayIQg6G0JPXv77KmROCANCf0qz3E?= =?us-ascii?Q?4jufE6g4njmlPlrzvhsGla7R4ui+UfbxAb+qzJeKGlNAujcO8iGDAZBLNWBa?= =?us-ascii?Q?em2Wu94Wp36N/lSil3l9L+L8xHvxvlhK6akwTN5E7TSYRtt8VxlUPTdiit8+?= =?us-ascii?Q?T2xQ6Q0LhouiHLBF4nDef9GbEWH56hrlf4TRL8wdcUAIHfl33v4dskpmK7nf?= =?us-ascii?Q?/SaztBkIPoFxl4QTrdS/7y/+AaZp1AwYlr8Cs+VcsUM/5B5hKYlO8LVgg/J2?= =?us-ascii?Q?Y33TQEndmhTHCEySiaD2bUAKeWz0VlEgRul/0lCbaUzjg1LbRap0pUVy/bF2?= =?us-ascii?Q?MvSscErsZ2zL3F5pQEABRy0Z+Ks1jnog5eKDCx3Fkgky5LKhLHa+dcXXTPDS?= =?us-ascii?Q?pAB55AdUaTuPRU3wPblfFuSQQomCwuUqq9hXY/ow2KSbaFkAQXe0bUZrVmw2?= =?us-ascii?Q?BUz6p3kSX8y4p6vQye++C1z3SMuCht/CpmvvpjroXpvfmTwi+XyXysNjFxZY?= =?us-ascii?Q?bjGnTr+Ta6D2kQdlgRTvfqDxqxSbfUzohvss/WIsZGM+//0Ky2N4v9VcomGm?= =?us-ascii?Q?Gh0C9X1cAYvGD8lKa1noDG+mwabc3pUfyn39fuXuSMpBtCackO6RaXX9p9EO?= =?us-ascii?Q?auHlqIj3COzceL9g1UKzifVBQerF6RMPv7EYKaPLLfLTtWLprIwzTMesxmM7?= =?us-ascii?Q?JN1InQeklIouypDH37CaONdTkhOo0R/t16M02hoI?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR11MB8659.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 21159936-5ef4-40e7-bcac-08dc79fe9fea X-MS-Exchange-CrossTenant-originalarrivaltime: 22 May 2024 01:29:29.1153 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xs3FpL4iGUJJtybf05hrjdiwTTWbUT2SBa8QtyKRqxhMJ/67iG8ibAeXMI3QIhaOLwdz7RFuchp8AyJH5GFyqA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5239 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v9 11/13] avutil/hwcontext_d3d12va: add Flags for resource creation X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: >-----Original Message----- >From: ffmpeg-devel On Behalf Of >Andrew Sayers >Sent: Wednesday, May 22, 2024 12:32 AM >To: FFmpeg development discussions and patches devel@ffmpeg.org> >Subject: Re: [FFmpeg-devel] [PATCH v9 11/13] avutil/hwcontext_d3d12va: add >Flags for resource creation > >(Only reviewing documentation, not code) > >On Mon, May 20, 2024 at 10:52:20PM +0800, tong1.wu-at- >intel.com@ffmpeg.org wrote: >> From: Tong Wu >> >> Flags field is added to support diffferent resource creation. >> >> Signed-off-by: Tong Wu >> --- >> doc/APIchanges | 3 +++ >> libavutil/hwcontext_d3d12va.c | 2 +- >> libavutil/hwcontext_d3d12va.h | 8 ++++++++ >> libavutil/version.h | 2 +- >> 4 files changed, 13 insertions(+), 2 deletions(-) >> >> diff --git a/doc/APIchanges b/doc/APIchanges >> index 269fd36559..808ba02f2d 100644 >> --- a/doc/APIchanges >> +++ b/doc/APIchanges >> @@ -2,6 +2,9 @@ The last version increases of all libraries were on 2024-03- >07 >> >> API changes, most recent first: >> >> +2024-01-xx - xxxxxxxxxx - lavu 59.20.100 - hwcontext_d3d12va.h >> + Add AVD3D12VAFramesContext.flags >> + >> 2024-05-xx - xxxxxxxxxx - lavu 59.19.100 - hwcontext_qsv.h >> Add AVQSVFramesContext.info >> >> diff --git a/libavutil/hwcontext_d3d12va.c b/libavutil/hwcontext_d3d12va.c >> index cfc016315d..6507cf69c1 100644 >> --- a/libavutil/hwcontext_d3d12va.c >> +++ b/libavutil/hwcontext_d3d12va.c >> @@ -247,7 +247,7 @@ static AVBufferRef *d3d12va_pool_alloc(void >*opaque, size_t size) >> .Format = hwctx->format, >> .SampleDesc = {.Count = 1, .Quality = 0 }, >> .Layout = D3D12_TEXTURE_LAYOUT_UNKNOWN, >> - .Flags = D3D12_RESOURCE_FLAG_NONE, >> + .Flags = hwctx->flags, >> }; >> >> frame = av_mallocz(sizeof(AVD3D12VAFrame)); >> diff --git a/libavutil/hwcontext_d3d12va.h b/libavutil/hwcontext_d3d12va.h >> index ff06e6f2ef..608dbac97f 100644 >> --- a/libavutil/hwcontext_d3d12va.h >> +++ b/libavutil/hwcontext_d3d12va.h >> @@ -129,6 +129,14 @@ typedef struct AVD3D12VAFramesContext { >> * If unset, will be automatically set. >> */ >> DXGI_FORMAT format; >> + >> + /** >> + * This field is used to specify options for working with resources. >> + * If unset, this will be D3D12_RESOURCE_FLAG_NONE. >> + * >> + * @see: https://learn.microsoft.com/en- >us/windows/win32/api/d3d12/ne-d3d12-d3d12_resource_flags. >> + */ >> + D3D12_RESOURCE_FLAGS flags; > >Some nitpicks: > >* "This field is used to specify" is redundant, you can save the reader > a few seconds by starting the sentence with just "Options..." >* "@see" starts a paragraph, so the rendered documentation will look better > without the ":" >* the full stop after the URL makes it harder to copy/paste the text - > remove the full stop or use a [markdown link](...) Sounds good. I've updated it with a new version. -Tong _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".