From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2005B48C6E for ; Fri, 23 Feb 2024 00:43:35 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C53AC68C282; Fri, 23 Feb 2024 02:43:31 +0200 (EET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BA80F68BDD3 for ; Fri, 23 Feb 2024 02:43:25 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708649011; x=1740185011; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=/HP2sTfC82cWOSbOoxG9Lx4GxjeqxnPJwgWaa+/krMg=; b=isGCTwzR1QJf+HaNBz4uvynlLnr9253tJc6TfB9WHIFPwbHXQAtB6CpK nbXHbR/vzvczBSKc2KHiuBwsUuKGsFTlkxDXwvE/vlX6IGpgK/1tSBIDc ZGeXUV5VD2dzR2+AiU4d7la2c1GtaEA0Tcb5bZGkNKqcK+8zTInQfq4fj 1JdvBk7AQ0sTYInUQrRa3zgyWsShpm8/hUjUh4rQa6W3Ds9eTey0mFPic vBg6Bd9Pd1xtTkdsWVCBxQ7+6JodcP+WZa309HqieyGwior7nLedbfEmU YH1QTRuWejb+j0GaRmaOKmWfr5B76HFyzHHrv4o7nMjwPU6uc9kLifLuN A==; X-IronPort-AV: E=McAfee;i="6600,9927,10992"; a="3095557" X-IronPort-AV: E=Sophos;i="6.06,179,1705392000"; d="scan'208";a="3095557" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2024 16:43:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,179,1705392000"; d="scan'208";a="10440178" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orviesa005.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 22 Feb 2024 16:43:22 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 22 Feb 2024 16:43:20 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 22 Feb 2024 16:43:20 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.168) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 22 Feb 2024 16:43:20 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AS1x+eGkEHgzsatA4A7NMlONo4sXd2GfQY6Jyciqb9BtFVys75iwCUmDQWqZrL00yS+BuFjduUghcafiNMx+EDP08VhLmhU5YbhtXyXPhbdHJgqphczt96iesuwsQcCMA9j9fZRJi7Lm9Gw4bi8+PxilPCz38r1RaUso0mGClK3GqyhA7aEpoC3FvJtUK/isMMUNghHiKP6zORCYREjhhxMw//HXwOm/YVMLcTj2zJ5OrAmS3qg7JCgTgZXn5yhA8mZWybAYlnad5fZY2hFStS2PCXj6ONFqEuu9b/uD3zQnJYOGcPnHIJV0siQfojar9VJWOW1+Tp2g+lprLboTag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=f6OoW2W92U1bzE84d7aOVvD+SpviSr2tWjlmAgqv+Bk=; b=COINOaAbc0timMt59B/7PwxgK2HlQAEzu6iv+BuDIQEbVPF01rkhxKyGVtRF7dkFCJlEg7G1fGPs3QBEdaul8DAcd7sODkXJXvG1f1g5APOetTnUHUev/SKUYR+i6/9JEuJ83AN3NGPi3szxpleVdPdzKEdGFz9si9ZvJLNxfQwsH3d+vx+WMKc+oATugTElNqpIZq6Qcf8y0VlN/mBU4ZHCAeM/B476tTikjM3bwHp3fRawAh4YSlCFcgBoouuERjYqy2wtbZ7xVpnj1UlTeyktm63BhekRLy+HZhLpzHriJa+A+KsVw11cURmAH6YkZoBYjHl7Val3amdsPnMB/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CH3PR11MB7937.namprd11.prod.outlook.com (2603:10b6:610:12c::15) by SJ2PR11MB8324.namprd11.prod.outlook.com (2603:10b6:a03:538::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.10; Fri, 23 Feb 2024 00:43:18 +0000 Received: from CH3PR11MB7937.namprd11.prod.outlook.com ([fe80::3d58:ec91:73d2:1925]) by CH3PR11MB7937.namprd11.prod.outlook.com ([fe80::3d58:ec91:73d2:1925%4]) with mapi id 15.20.7292.036; Fri, 23 Feb 2024 00:43:18 +0000 From: "Dai, Jianhui J" To: FFmpeg development discussions and patches Thread-Topic: [PATCH v1] avcodec/cbs_vp8: Improve the bitstream position check Thread-Index: AdpPI2nmVPdD6Fl2TZKSQ05lzo+fBAWzbiQA Date: Fri, 23 Feb 2024 00:43:18 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR11MB7937:EE_|SJ2PR11MB8324:EE_ x-ms-office365-filtering-correlation-id: ddc86c33-03ea-4a42-33dd-08dc34086db8 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wTD3MsnfyCsB57TkFs3oWEeva16/suYzR4ZgmpUTOi4ni3GmVBkR+/ZP7jqcrOntjviEK+0EAmNpelX5KdY2ePGPzimUlxbRLIWl/k6FYqD1q/xro4DHFxOj/Azkln/Q9ZZnHipI1bYXnJXRu30aklIO7R/FwYutr7TOuKJK7LopGZxxLmmnfZ4TcdqdaSx8ziHhPpXgkoKdj8fk2TeYLAi0rCY66fTEGgArl+cvc38+HqC5f6YxbuaZXZCb/+z65JfV+Oay2qITAru5jxCUg2m1uMtvBuxeY8n0n0sqWF/cjzubd1r2okiZoTlUhIWBBzz1ZPWdFUyfoeOTn+CTN2vezX9pY3WvlVmx/hceYOSNechMyivjdiq3fLbI6FUUNV3O5LZZ6u59ZW+OHejVNYOXEB5nM5sHqnO2RpiVm3C99iO+gD70RQTLv0eGVVlnEaEn1KmwtDJHHPqZIaTyECCu4tiZoE7b1PmBuZjWJVoDGXg+Br8Avq6L9O+v7+IWn1ptLlj2wtI3LKQ6E+kOljrvGhtGqubtCKyRCLZjx+NwaBBeCCyS0tnewW7vSipbS6b7Dt6YTc52iFbLW+aXV9vMQr/a2L9oxcnEdfIWbCA= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR11MB7937.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?uV3G6FV9pjumYVbxcPxoChvmXgFnpNwK023mL9wbJii7cC2STRLNs8NIKNcx?= =?us-ascii?Q?gPvY5kLavWBq3aNQ+BmaBN6oqswFj1O4TEu1E6NPgrkdYY8+6NPIYzVU8coH?= =?us-ascii?Q?tyWwudjnXXQ0Q7JpOduwYZ2Vh3Y1BkFMf14krGpi25CiviIPQ7cnOl4AkVsI?= =?us-ascii?Q?GIuz9sPUzQi3xRrgn4xLUhSZSsJrrgSrkZ8PdhZ+guWYcVhDTTDQEUjTtkoI?= =?us-ascii?Q?FTUei5VYgeUaDtQK/UY45cvVJ4f5TJ3HoyFncD2R/WG1z9EOfskXuWHRdCzy?= =?us-ascii?Q?gloCGewlWx+9X31X9aNGsn/pvTqjjv/P6QmB1yNBNhBqlXIMPr8XkbhAkqcW?= =?us-ascii?Q?Bb0nQnCT17RwrcNxHbzf+biWTBIr7qiwKPqEsXnyBA/xUhdYpofJrOkgqrWj?= =?us-ascii?Q?iW+nF9QitlCJU3ms3atjpK4osSJyjd8NGC7raVumd7Xv9linhzWdef1J4iWl?= =?us-ascii?Q?VDdHE8wH74BoTKTmL9eZC25uxwKQjXugfj69MoyV7U+6/DOp/Gn6JCLF0XPW?= =?us-ascii?Q?2VUJQzriboizP/er/0dJH1P1NJvONUZlZGsbPdNC7BqoxIW1nVFidT2L/G2Z?= =?us-ascii?Q?auxGzPk9EmqEkUAk+SEobXkqCjP8m1z3ztOZJsqBtDtIRFwkMT8Ey797fSEZ?= =?us-ascii?Q?pCsdlJF+X7dtOpImbBBxiKabfjDv9N6zhjq6+epk23X8c0fDajhWgyuxSpGW?= =?us-ascii?Q?Cu6oHLczF3uvOY9U2Emzg99G57UJt9Z/RJuHHt9G8d4yhCvGpDP5uiPpaAPQ?= =?us-ascii?Q?mXYhda+HP89cuhqW77W2NW/fTFk+qc8YWfSOeunicOP+z196ZQORMVJS2KZf?= =?us-ascii?Q?g2oT6x/V3mGgLPNc4QT+vJpnCmBHNtwORhrXbMTiqh2tYjTPhg/NdwEmy6HF?= =?us-ascii?Q?7VOzPyjMDhwe/UKJXkKyO4crZQojhl/IJMsXSKPWOlnCWsmOJzmY6DjS0FW6?= =?us-ascii?Q?bPXCvWyciY6eBl9ZjsDZS20KbCgOii9zBfYJ88Dj68kH6SH+bWjn58y7ltYf?= =?us-ascii?Q?K910Ss/0kcC/ouTAQK6dOTuJwsggcTh5U/kPV15h5plmO9UcpMuq/JMQe43V?= =?us-ascii?Q?sHkKGELx9p+7WZUUXZi/OgDbKASloPv1Qvr4lbKHg9LB9PRoCBVN+XLMHCB/?= =?us-ascii?Q?WLwaXbwtsAn9M07t6S2tkON4OBV0+XXIxHGoRaWQ6rSqv8LKgZXV2kX4hACr?= =?us-ascii?Q?8HicE889pgm9z9lZRFvU0Y2qLbNQIwLyTCIanA4J9jhx0d0lacFfpbwnHI3/?= =?us-ascii?Q?K1eobeBNKXnLdr1kBPmAd4QinFgzzvJy8d7+W7tErDeCB+vtguYQngCfkApd?= =?us-ascii?Q?pcReTnZ0eYGYSlrBx2uposUJuKISXh66KqvGnIIJydE2Y321UbLik3vpq7y4?= =?us-ascii?Q?MiUGAmPfpLddxKIDuCj4Ha5/4ZJbdUL93ddIG1StTiFir3aEok45O1iiMWzX?= =?us-ascii?Q?EydqrupZ5JlmbrYSLBRSrsnr2zNh44zAduTDRBhkpBpc0Ta95bvTFeXjPRLT?= =?us-ascii?Q?UkktZotAkWO9E8hbXfvwC3+JEzvRyDzMQd614sNzv7GEvOmiBo1m7maZ1VP8?= =?us-ascii?Q?EBG1h9MpIsqY1oTJ7usmJjfg4fNcFktksCzO7/SX?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR11MB7937.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ddc86c33-03ea-4a42-33dd-08dc34086db8 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Feb 2024 00:43:18.4752 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Xyd+WmCpe3H0PHISX36p9DNoS9zdIjR2z/sEpb056docHMGcf8Fzk5kfCnxC1Z/FX34ESvKndtZL8NMd1i8JYw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB8324 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v1] avcodec/cbs_vp8: Improve the bitstream position check X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of Dai, > Jianhui J > Sent: Thursday, January 25, 2024 8:54 AM > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH v1] avcodec/cbs_vp8: Improve the bitstream > position check > > The VP8 compressed header may not be byte-aligned due to boolean coding. Use > bitwise comparison to prevent the potential overread. > > Signed-off-by: Jianhui Dai > --- > libavcodec/cbs_vp8.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/cbs_vp8.c b/libavcodec/cbs_vp8.c index > 065156c248..13acad3724 100644 > --- a/libavcodec/cbs_vp8.c > +++ b/libavcodec/cbs_vp8.c > @@ -327,9 +327,10 @@ static int cbs_vp8_read_unit(CodedBitstreamContext > *ctx, > if (err < 0) > return err; > > + // Position may not be byte-aligned after compressed header; using bits > + // count comparison for accuracy. > pos = get_bits_count(&gbc); > - pos /= 8; > - av_assert0(pos <= unit->data_size); > + av_assert0(pos <= unit->data_size * 8); > > frame->data_ref = av_buffer_ref(unit->data_ref); > if (!frame->data_ref) Ping reviewers to help to apply. The review history can be found here: https://patchwork.ffmpeg.org/project/ffmpeg/patch/CH3PR11MB793797554CDB411074364733B1742@CH3PR11MB7937.namprd11.prod.outlook.com/ > -- > 2.25.1 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with > subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".