From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C035949C0D for ; Tue, 5 Mar 2024 05:33:40 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D55EC68CC2A; Tue, 5 Mar 2024 07:33:38 +0200 (EET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2BB1E68CA86 for ; Tue, 5 Mar 2024 07:33:30 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709616816; x=1741152816; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=SQCHKMbid9zQiBVovS0UslRyIQWBbH0y3sccIdhxsEI=; b=oDBTwOCwRuZcZOi818HTIN7+jsmyZoeNvlwY6qJZFkNT3zHQeryqFyJo y/hs7S4FniUuRZEEQNsPjKDULW1T1+ASlRhJ2GJ07DlvJ1VXChtLYqthA yQ06+eHmQYzJWfN7LSznTJnOlmwaDxyn2kFJ8w3X5MCMLOYkIqecIUDve WgFs2lV17Q5cOM1L9+ic+GPWZg9FC/c8SOcR7V1BMHLvwa9ZQt47ZL3/8 UFibqq7nnfnG0TMI+Ex7WgiZ/lDpUvQ22h22svzmErAshlNIBNpv/eaYq kRUDvTSm2Tam370iiq9+O6h1fImxznbzavTZ02ubqAMUm+cmGna2hCNGz g==; X-IronPort-AV: E=McAfee;i="6600,9927,11003"; a="4305223" X-IronPort-AV: E=Sophos;i="6.06,205,1705392000"; d="scan'208";a="4305223" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2024 21:33:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,205,1705392000"; d="scan'208";a="9217264" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orviesa010.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 04 Mar 2024 21:33:28 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 4 Mar 2024 21:33:27 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 4 Mar 2024 21:33:27 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 4 Mar 2024 21:33:27 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 4 Mar 2024 21:33:27 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F1rOCEdWi3rTWIYt4tNQicrmuezfiA7soPDxUexb+/aIJcRXSOhSvfOqqKWW2ddkp6AU+esfzFaj+dQ+DvkzKbIrv9IXyFC1UHDiCIDyT/7IUJoVVM0EBelHmRb2wyC//wh7XdEeLw0HGIPy2eaEP7FlTZv+BgoKKgNgllROhB4RMfEHCJHPFm7IC4P99FgVq9RtVVeNqYPHaQc7XXF44R+Iw6dtGoWLCzAjnNl12dS7CkwYC6ID2iVzTQ2tbDr/sr+y/B1ukmCYMdlr50AVSpwJSqmF1CsKfY/jFYUhMBMI+1mxYn4uLuIyBFplcmU1GdmSydeE6fvWE5fEWhcVMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s50DdfIw9DR6rvxwqo2JXlpUaZ0B75vtB3Ktc3m80b8=; b=jTFntL7TABPEY8Uqfp18t48DNFVOlHEoS41ScC7+R6vYBP/RS8JZYylUGjnrP9hah7wj+kLVwkkZFA9EEdbup6h5a3OIoUyPO/BNTiHOHXs6Cd8rbQUzghASEKXPfRieWP/SWb4qQLc+RhMxALtxSpdugWQwU/yED0+sZgTc8yXUKx9cgMoOSuqGpDYUDpt4ycbV4nBP71JcyMU9wy4YV7uZ0N9mKVZzfrGkQIw9bPYl5L4n/Mh30jfF6bdIRKzm3kCklo9h0zbpF8qu4ri+NyeXetX6VP0uquS1dFuUcqR7CNUswuxq1vM4+Qgcx/gDtQNtkZNHh0FyNKASLrVWaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CH3PR11MB7937.namprd11.prod.outlook.com (2603:10b6:610:12c::15) by SN7PR11MB7510.namprd11.prod.outlook.com (2603:10b6:806:349::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.22; Tue, 5 Mar 2024 05:33:25 +0000 Received: from CH3PR11MB7937.namprd11.prod.outlook.com ([fe80::f1a:a315:bd44:113d]) by CH3PR11MB7937.namprd11.prod.outlook.com ([fe80::f1a:a315:bd44:113d%6]) with mapi id 15.20.7362.010; Tue, 5 Mar 2024 05:33:25 +0000 From: "Dai, Jianhui J" To: FFmpeg development discussions and patches Thread-Topic: [PATCH v1] avcodec/cbs_vp8: Improve the bitstream position check Thread-Index: AdpPI2nmVPdD6Fl2TZKSQ05lzo+fBAWzbiQAAjM8gVA= Date: Tue, 5 Mar 2024 05:33:25 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR11MB7937:EE_|SN7PR11MB7510:EE_ x-ms-office365-filtering-correlation-id: 4b29cc08-144d-4647-aeec-08dc3cd5c798 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qZ8Mf6fwj4rocrKw8qjyjSyoodA5EWRJOnlWeJWLw7lJdd9uwHblJPov8Bj/SQFkUEUR5gzS5BhGu06PI2YloDNoSbsZj00W/CbIUEP1AMGle/TaikNwmMSLYRS+SLCx/1rDC0l230QbocFjbmciyjr4zFG6tIJ1kEhoBhfkEb50GNzk3fBA9/ZtCtn9t7Vo+T1qVkqvs1n0uXr+ehI+07dJly2qDJ/Y/axpPpX08q23LvA2IgJiVnnIv74B9SXN5UQNOUuPiN6IGxXaFP64n7AGdpKu3+vMCH/K3VDbwlkPZFVIKz0A0oBBYt3VDYqzzEQERtmyCgucduOUMqXf63Djd1PYj/XGD3YT4/JFfTHaXAQentTCEDDM9Ay/qPFxN7L2LNXCwLGzf8I+gk4noj/yrDgnttnNtaAOH7k0Dl7X3+2AyGSWnZAUga7SrjdmsCkccsvjvQhARXE2a5IiuDQuE82VVrqiwbfTf3CEDjPBjetbCO8jjX1PVvnUTkyXnbhB91hhznkb7VGzKusuVxk/1s7mqEf3/05evd3sdXLcxey5ceGuKgGlauBABinB/LtmIexywWf7M293S3/kouPqO1F+m2uBzFe1/M/YSe2tapF9NVAcIoGbP/edZJwoqlv1f4i82G13um2Bt6dbnHOVfOU3LGgLXJrVXaDNFds= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR11MB7937.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?zeBpWhNJLgqrlmGzyRsLU7QrPsuX58V7pMSC2LhLwjc+6bW5dNgtIk93pe5e?= =?us-ascii?Q?bfLzlzI/lTzLVfViDM25bz5htcEmitxFNmzZ1q9wYJxXtyCrJOyW0nj+cvda?= =?us-ascii?Q?Bbg/1hMWc0zobfj8MuwC4BBSr8qJENOkJBdfpNiLVw8g0cyZoRecxQcr+q3D?= =?us-ascii?Q?ajCrK5uCQ2StNpKOdfEbLM7Ywt3v9pVNI9PGmoyJ7L8km0nE74QSujurcV/U?= =?us-ascii?Q?+kRQ7V7ILnbaswRqe0pgY8eygn6yBUbHPIK9G3Dm1MKS8MjVGoRTdNsXykva?= =?us-ascii?Q?vsMUapKuVNT0AjDdecNlRUwnYUEUzwqY7WlbDDc4NESE+FPqHgJAZ5ref0m+?= =?us-ascii?Q?9tv7Eqy9H86N8VVwZu5An306ro8T52kTZzXe6kzh1XxkoAVmKWs2MIZasz34?= =?us-ascii?Q?KHVJWuP1h+gcDcjH4q25X2dbgjol7bckQwTpveV/IB6H+9V6DW/9FENS9CnL?= =?us-ascii?Q?bveJVOsVhU+Pnwkq6+JbHNMcmr4zB16SC4l92/hDLOC0rX1qOqJ0TpI5i7m5?= =?us-ascii?Q?F9Bk5JSbEabI0iSIi13fziGSgDDobakG5mXS/TuH9GGflP+kplXlG7TPmGEF?= =?us-ascii?Q?8gTOsaBMetjQ/+1qbQOaEkBvIhTkvhjuk8cevhLo7xh8lTiGj6ldfdEbu5Q6?= =?us-ascii?Q?wXANgg+xCXyS5IfqnvA2X7dIDNYFTwA0w87cGTuRzY9hrF2fYn+7Cw2jKwkd?= =?us-ascii?Q?WaCs36NO0ZZdtMRYHfarpGV2AGAE7Z2+F8bZTA9WsRgPsURfIEcXgQ5XG7b6?= =?us-ascii?Q?TYehXPCIWwlnMl1AF9J5P34lYe8EhwLhZppjyGqojJJLhwkexaNZjz7Zo/lA?= =?us-ascii?Q?SvHvfACg7DTL16PrL8tSLBPwNanUkR/oJ05s6eDrXQA1+RwDuRkEEF+H5XRt?= =?us-ascii?Q?lRuf+0UcqIaxwMNKif0mXhRHfGo3/gAAWc7ADMGKsNyYnqIZkGHXjFxqCsQg?= =?us-ascii?Q?Y9jj09Ec4yk5y9e8xPHPEOzzsZdIWm1pOJbrYiLR95lf4FRE1R8Xlg+BDyUl?= =?us-ascii?Q?OSX7dDDX7Dw2iNanc6IMDAO7Ws5R7L4lndBOAyoD1KIDQTHyFI2F3k8ioBNy?= =?us-ascii?Q?Eo/wOwKlL9Y/ZbJR/NiEzYRUcLvAxS3JewVETQ+BaI9SsmvQ5MUAmvf6qqJG?= =?us-ascii?Q?8aetjfMvzThKy1jHZS5LDzStp/qh6QQg13pyurVOLfnAbulCdSnuYmGbOXYC?= =?us-ascii?Q?ABn7peBFZkuX5Cpe/caeARn6jj+EYl4IOg74c641uxmoEfHoPXXGgYoPNd1V?= =?us-ascii?Q?xrIfrTQYQ7ANym6KxyqLytCagbN36CkDqc7bV8A9vxzJGuMDbfYqNOtcTytB?= =?us-ascii?Q?visH1MRXyRFIu8vu323YM02nDEng5I2FyqaLe8MXmQCtGsG5/pGAVbRLznKE?= =?us-ascii?Q?PXQPiWrn4z04S1xXQaY9X7buWEYr98s5n3AsApYmxqA8mnpC1iX2Ve1qbqcE?= =?us-ascii?Q?zvWGOia0dbRvxD9kb3HI6rgsBfOqqz+1gibNUbuRSwtlPg4obyaK2eURyDVx?= =?us-ascii?Q?UP+/ktZeRyYZ95DouwIRLcRGUX6PeJN8j0ldeHOEUrdCO5b8SND0gqUbDlID?= =?us-ascii?Q?dhEi7kklPt+5jDcF13piSI1Mzj6fGmhjxacHTSrc?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR11MB7937.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4b29cc08-144d-4647-aeec-08dc3cd5c798 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Mar 2024 05:33:25.3623 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dTW11CXNzT3vnTig/gjiAdUP6hKE/aGIO8eGN5v20qfVIEoZ6n2oXg+VM39wOdERsc3xMYP8lNbjPQ2eBHEX9g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7510 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v1] avcodec/cbs_vp8: Improve the bitstream position check X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of Dai, > Jianhui J > Sent: Friday, February 23, 2024 8:43 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH v1] avcodec/cbs_vp8: Improve the > bitstream position check > > > > > -----Original Message----- > > From: ffmpeg-devel On Behalf Of Dai, > > Jianhui J > > Sent: Thursday, January 25, 2024 8:54 AM > > To: ffmpeg-devel@ffmpeg.org > > Subject: [FFmpeg-devel] [PATCH v1] avcodec/cbs_vp8: Improve the > > bitstream position check > > > > The VP8 compressed header may not be byte-aligned due to boolean > > coding. Use bitwise comparison to prevent the potential overread. > > > > Signed-off-by: Jianhui Dai > > --- > > libavcodec/cbs_vp8.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/libavcodec/cbs_vp8.c b/libavcodec/cbs_vp8.c index > > 065156c248..13acad3724 100644 > > --- a/libavcodec/cbs_vp8.c > > +++ b/libavcodec/cbs_vp8.c > > @@ -327,9 +327,10 @@ static int > > cbs_vp8_read_unit(CodedBitstreamContext > > *ctx, > > if (err < 0) > > return err; > > > > + // Position may not be byte-aligned after compressed header; using bits > > + // count comparison for accuracy. > > pos = get_bits_count(&gbc); > > - pos /= 8; > > - av_assert0(pos <= unit->data_size); > > + av_assert0(pos <= unit->data_size * 8); > > > > frame->data_ref = av_buffer_ref(unit->data_ref); > > if (!frame->data_ref) > > Ping reviewers to help to apply. > > The review history can be found here: > https://patchwork.ffmpeg.org/project/ffmpeg/patch/CH3PR11MB793797554CD > B411074364733B1742@CH3PR11MB7937.namprd11.prod.outlook.com/ @Ronald (rsbultje@gmail.com), @Andreas (andreas.rheinhardt@outlook.com) Could you please help to apply these 2 fixes? [FFmpeg-devel,v1] avcodec/cbs_vp8: Improve the bitstream position check - Patchwork https://patchwork.ffmpeg.org/project/ffmpeg/patch/DS7PR11MB7949CF2C01F31B4B8597EC61B17A2@DS7PR11MB7949.namprd11.prod.outlook.com/ [FFmpeg-devel,v1] avcodec/cbs_vp8: Use little endian in fixed() - Patchwork https://patchwork.ffmpeg.org/project/ffmpeg/patch/DS7PR11MB79499AF0B5FB03FBF1876EFCB17A2@DS7PR11MB7949.namprd11.prod.outlook.com/ > > > -- > > 2.25.1 > > > > _______________________________________________ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > To unsubscribe, visit link above, or email > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org > with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".