From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 99F2048A0E for ; Fri, 23 Feb 2024 00:44:11 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2DD3068C0A2; Fri, 23 Feb 2024 02:44:10 +0200 (EET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3DB9568BDD3 for ; Fri, 23 Feb 2024 02:44:03 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708649048; x=1740185048; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=gpxlQ6SmD/eqNVM4NNKA40XSFqKkIk+IilhTUG5M08E=; b=SrjhC0JHKPoWwYW4RAcda7iOnUGeV+7Pt/AAXkf/0Osj5wBxNW6DgNmW oJAuiffxhDC+npyoNBCG8ManvVDQDm109P3Qhos9qGURsb9F00WYy30s6 xF3QOKsml0ADwdRccEXBFwYE7eKJoeqfz/X4OkTMZGIiQGC3iUp8OeQPL UKj2hLiSwUSnmHMaMtQYOfn7JJ6wBjAAsib8rbN5rwzLXr6uU9dZD/x9u d99N2998iMybdjQAHZZbA2tOIy/gezRvFJri9EhOxSBmQqTwh+k75OLmU x32aUkjKcYhPxuYDX9Os6fHDy/hcn81svtP+8Fmu0MccBhvYEGmgSQv2w A==; X-IronPort-AV: E=McAfee;i="6600,9927,10992"; a="14350861" X-IronPort-AV: E=Sophos;i="6.06,179,1705392000"; d="scan'208";a="14350861" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2024 16:44:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,179,1705392000"; d="scan'208";a="36514294" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orviesa002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 22 Feb 2024 16:44:02 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 22 Feb 2024 16:44:00 -0800 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 22 Feb 2024 16:44:00 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 22 Feb 2024 16:44:00 -0800 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.40) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 22 Feb 2024 16:43:59 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PMWk1vSm1KmcVj5tEwIljaJyNqs0k9hZUv/Y2L7B/Qn9I2YJ9RGTeWBeKrlWD+OpZUfn/2j8stWajqMbksc4H4silWV2W4bh8adldl6wRqDmVCvHUfkVu7svJp+h2LmKFZdhshmC1b/hvIqSWKoomNPcC00yAIwUIH9i4jRn7I7q0ATVOJL4nJvB0n+VVx0Nv8+xSUDmoinyr/ImrVdEyaXZED8POiNm7E+Xh3cD+7DA7jWcrzz0wb3te9pstvu+NZFyut4ezKu3ToMKeDBP7FTTJxb9+yldfPmCUje8HwPOrdtHTggC8UOxgXsXh3DTv5R05N8zowhguJoY00ke8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dP1Emj/IDFkTY1ctcLWm0R9g0oGfVYkS9T7eaiNoCA8=; b=XLPugXKElzZD1tHWkQnjpHhrgbzTvCC+oiZrEWhqtwPFhFJk+LPa4+CXt7+eZ+RQkUzmYvpf7EE5E/hZeSbZM60BsLlFGSCqoAIJbnzfh6q7gwnp9cQ3RVkrc7vU4EWFqwbrdx10C/jOrymHRnKJLY5CRir8WmBwcUJ9ULKzYNf1JymkT0ijYFY1+9fc3q9Oh/ajluVYUf81UuYOJ5Gg1TBtjLwhYCt2NXCbcLaygbewuPs3JKHixXuOKc/l5BN022+xfVj3cZalgSb1Y62sZmMpdHBqFn+At+pvDc5wXSCK0Kkiygf72YiGHZFPOPCLZjl5KQNvI+XS8wUHqdcIrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CH3PR11MB7937.namprd11.prod.outlook.com (2603:10b6:610:12c::15) by SJ2PR11MB8324.namprd11.prod.outlook.com (2603:10b6:a03:538::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.10; Fri, 23 Feb 2024 00:43:57 +0000 Received: from CH3PR11MB7937.namprd11.prod.outlook.com ([fe80::3d58:ec91:73d2:1925]) by CH3PR11MB7937.namprd11.prod.outlook.com ([fe80::3d58:ec91:73d2:1925%4]) with mapi id 15.20.7292.036; Fri, 23 Feb 2024 00:43:57 +0000 From: "Dai, Jianhui J" To: FFmpeg development discussions and patches Thread-Topic: [PATCH v1] avcodec/cbs_vp8: Use little endian in fixed() Thread-Index: AdpPJmtl+hVJnj6GT7KGrE3McpyjKwWyuObA Date: Fri, 23 Feb 2024 00:43:57 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR11MB7937:EE_|SJ2PR11MB8324:EE_ x-ms-office365-filtering-correlation-id: 50211c55-52cf-4d8f-3978-08dc34088511 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rFYB/KdiUxOAx34ZosU8SAq7SP+KedFmlWKK2Cc6gYJt2Ef5iLaTYVEtMfcGOgNZgN+k9ghJrdaJ5k4bVaubgElHk4LUxj4WPHiGfwSdoiEoZ/6yscCTRdENo476v/JcwwQiFzXUksdlP6ZEXFkt3Bm9BvisA2z22g6Psj7NE691ZFIyjTUdz8Us/FMyWsLZt0QKl+qUSDK3oqcyLb0ZniGAKc7HJUdIxDe1PYzMuTcLRqwF7EvrZ+TDJsge6SOPkXm7q2QmUbWVjuYqNTn1JOgLo+w5pvXwcRSHsnrhTjUElYMZ2nSpQ6yIkPQ3boW8CntHMM0wjln3IvvRuaUU/WxzLiYd08wHewjMTdd8bc52+chQFcn9e0jK8ecPKPLXrxTTlQZHi2Q1CCJivqfuSSB/7bI017/c5Lx+/In7FYDuuYG2QcqNiCfwDg+LmUzAEFZxvh+nJoYybgnEcoBxh0/ZhP4Xl2O+SLvX62dgQjkhHILT6Z8bkDNoLtJBuSdIShKdoG2D8VTycv1QHo2AkYwr/1f4a026wg5mc+LoRcGp7O9YaMZ2EyagVr/qs1XYlrMxkT6RxxbDEWxMD80Qs+GkWJTNoq8Aoiijc5Y3ojk= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR11MB7937.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5jn3gq5e2YjhL7ELJ/HE+m3ZYIS6ZAmqxrzqPXL7aEUFrzi2C/M3AU4/8oI/?= =?us-ascii?Q?ZePxDTo4URvF7mQsnm5kxfZrC7V7BYxFB9gW16XHinq0tmEkE8it1A2pP4x0?= =?us-ascii?Q?5TeftT0Ggo+VgXNbSq92snEUFbceJIU8Qt4phtd92O5+M1OA7+nKXyapxMVf?= =?us-ascii?Q?q13koWY8J/rJaCBSZ5eT0cnLPBY6MZLGhOy+sz/vtWtZ2EqubqmQzRHOIhnI?= =?us-ascii?Q?Mpvs0qUrtlKUraC8LHUBr3u4+XiVY/bWZlT+dWmqTKKQ7QSS/zBy1y8sy69d?= =?us-ascii?Q?J6Aiq35dkBHelSICE7SZojfTupiT9BNe2PcFiIc4hg2UjTj1pqw7Kkav9x4k?= =?us-ascii?Q?GDvieeg3zAafdB5WHw9INN1xbu7WoATnww3TTfuXso3jVXkKYr0dw31Wt4j5?= =?us-ascii?Q?L28oDJ0U6l6gVycaN3vxDNVCqoJx+WGYVcmA+rgCJcHMCFlWMTZeT7D8oF0V?= =?us-ascii?Q?dxwjkUvhTXoTdbL3XQvswIUjkz9JiMlFb+CfEoUgPYoXYJciYKJFCCRLmq0F?= =?us-ascii?Q?KISOsI/2MQOfjt51o0yfqdH6ZVaf3UxUU1QKP4wsyzR8orFp0iAf4SlS3Nmm?= =?us-ascii?Q?Rzi/D4JunX27BocxZbeOs4UkLV0x9sMIFtMAX+HXJNWk20fKcGksaVwChmv1?= =?us-ascii?Q?mkLqyh4khvtjCNf/SOwr1hxl3WsCgr8dfrtlJlsUzQiGHkfxufgVrmIGY9hx?= =?us-ascii?Q?EOBbVPQc5jJ8u51JG7F8EII8FegqKfM9ocUyKKo6lhsScKtMR14zJjXalE12?= =?us-ascii?Q?Q4+SnWX0BcBqOfhADXCe1cgT8pgyjfeEUt13el+I2iBZnzBxmm3QIa+6XXr5?= =?us-ascii?Q?SJ6c0NWtdQ2/GfUmY9v7Im9+K9ydBj+rt6jfvX8cOrm/9pH2obaiKP+aV7Vu?= =?us-ascii?Q?+U1lUaxI4iV7MtF0zHFX8Ved8ee6IdAl8xapupvN2vUE1Y+KgqEhdmn9Ov9N?= =?us-ascii?Q?D8EKFqe786PEk8OjcwCEWKZjo7kn72jH1pbr1S3lxBs6IScvilyvLozzuUWV?= =?us-ascii?Q?tI/VGCYAvsMvZov9NlfGGR6R82wSwLUnLlgd3Kw78OI0RmpNsr92mUsGHKDT?= =?us-ascii?Q?SoLiwMZqIhODgud4saCKbZVcqw8Yqpo32O3dnCMVxPHlxeIoyZIhUTxMSsLR?= =?us-ascii?Q?nGXHgX/AJWVJjXHRRjKmsDB9RV6JDRBoO4dLCOr2626ZU3gWDT/MJVr6sdt2?= =?us-ascii?Q?yoQiNo53MGY0UyRax6aJl9/b0JetQw5ct5ZZ5uSigIstv/fZ6eggO+FalmSR?= =?us-ascii?Q?6/dX1XpPP9rOM54ZaWViKayea/OMAIP61g2ZXzUeHOJtDpNt5HMO+A7DBBvm?= =?us-ascii?Q?/KMkBlJv+jChN7AER5Vp9e1Qz6FVlLb+mzKg1uvNFql6hxt5BH1dSkCKocCx?= =?us-ascii?Q?EFrOj6aI5YjXeoXrAJo6AxrXjgeu97mdL/lOAkExwvsuRHhEaIIzeowlNuxS?= =?us-ascii?Q?nYiDUlbXiBcf6zFeAGoWdKZff1IIpt3x8xylv5Bry4p7vNOu4yjKugwj4rmI?= =?us-ascii?Q?TEt86pKsad7uXn4pkbMI4JULXWeJFTOc6InQb90YmRFNTGKlauw6LaEUcsXl?= =?us-ascii?Q?3dVrSEfzVCrUoKB4UotRQZ+JLWNgzsXdoVRXhKJU?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR11MB7937.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 50211c55-52cf-4d8f-3978-08dc34088511 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Feb 2024 00:43:57.4889 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3ACcNB9tCuswa/njr9VBcyvIAXKTvLeuFo960YbqE2EgGeiU6Jmp8uHaCKeHDgOUxSrZSGZdTjbkp4FIAF6ZmQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB8324 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v1] avcodec/cbs_vp8: Use little endian in fixed() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of Dai, > Jianhui J > Sent: Thursday, January 25, 2024 8:54 AM > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH v1] avcodec/cbs_vp8: Use little endian in fixed() > > This commit adds value range checks to cbs_vp8_read_unsigned_le, migrates > fixed() to use it, and enforces little-endian consistency for all read methods. > > Signed-off-by: Jianhui Dai > --- > libavcodec/cbs_vp8.c | 23 +++++++++++++++++------ > 1 file changed, 17 insertions(+), 6 deletions(-) > > diff --git a/libavcodec/cbs_vp8.c b/libavcodec/cbs_vp8.c index > 065156c248..7a0752019b 100644 > --- a/libavcodec/cbs_vp8.c > +++ b/libavcodec/cbs_vp8.c > @@ -181,9 +181,11 @@ static int cbs_vp8_bool_decoder_read_signed( > return 0; > } > > -static int cbs_vp8_read_unsigned_le(CodedBitstreamContext *ctx, > GetBitContext *gbc, > - int width, const char *name, > - const int *subscripts, uint32_t *write_to) > +static int cbs_vp8_read_unsigned_le(CodedBitstreamContext *ctx, > + GetBitContext *gbc, int width, > + const char *name, const int *subscripts, > + uint32_t *write_to, uint32_t range_min, > + uint32_t range_max) > { > int32_t value; > > @@ -200,6 +202,14 @@ static int > cbs_vp8_read_unsigned_le(CodedBitstreamContext *ctx, GetBitContext *g > > CBS_TRACE_READ_END(); > > + if (value < range_min || value > range_max) { > + av_log(ctx->log_ctx, AV_LOG_ERROR, > + "%s out of range: " > + "%" PRIu32 ", but must be in [%" PRIu32 ",%" PRIu32 "].\n", > + name, value, range_min, range_max); > + return AVERROR_INVALIDDATA; > + } > + > *write_to = value; > return 0; > } > @@ -246,15 +256,16 @@ static int > cbs_vp8_read_unsigned_le(CodedBitstreamContext *ctx, GetBitContext *g > do { \ > uint32_t value; \ > CHECK(cbs_vp8_read_unsigned_le(ctx, rw, width, #name, \ > - SUBSCRIPTS(subs, __VA_ARGS__), &value)); \ > + SUBSCRIPTS(subs, __VA_ARGS__), &value, \ > + 0, MAX_UINT_BITS(width))); \ > current->name = value; \ > } while (0) > > #define fixed(width, name, value) \ > do { \ > uint32_t fixed_value; \ > - CHECK(ff_cbs_read_unsigned(ctx, rw, width, #name, 0, &fixed_value, \ > - value, value)); \ > + CHECK(cbs_vp8_read_unsigned_le(ctx, rw, width, #name, 0, &fixed_value, \ > + value, value)); \ > } while (0) > > #define bc_unsigned_subs(width, prob, enable_trace, name, subs, ...) \ Ping reviewers to help to apply. The review history can be found here: https://patchwork.ffmpeg.org/project/ffmpeg/patch/CH3PR11MB793797554CDB411074364733B1742@CH3PR11MB7937.namprd11.prod.outlook.com/ > -- > 2.25.1 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with > subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".