From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 8EF1E4D253 for <ffmpegdev@gitmailbox.com>; Wed, 16 Apr 2025 10:58:59 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 89F31687DEF; Wed, 16 Apr 2025 13:58:57 +0300 (EEST) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02olkn2089.outbound.protection.outlook.com [40.92.15.89]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4F376687D11 for <ffmpeg-devel@ffmpeg.org>; Wed, 16 Apr 2025 13:58:51 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=am17mXRm71hdYLmaQ3le8gGlQPx3qpo1lDAwbi+tt+SxpvxYZvf+GVqzph7BH0vATwU1IZgvyV2smd+Tumuks83QaaMuepQ35231JTy6yI4dyMXN+ZhkLS0YTWWg/2F5pAppCxvpP3l3TOwaAKmYb3pbkJZ3/gimIlkq+PlcFmtgrbIjJKOghsyTNm6zJFmasmQ9vFXXhgA4Jq1mQqCeqh+sMcXTXdGCNYMBAvipHR+OzI2teGHYwgL0KTFBCj6TuYM7lGvbLFPXdZzJG7mUoxuzVXzh7RY8/Wol0+1W3BTOeY/DDAcwyz5dAwz/Km90nuvn/oNivCRm9VRZBQRlyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hPNWChdoVXeGgfcwjLOTxHfHejk2gt2gdTEihu+AtYs=; b=CPpbctqQs2MklEWsONh4znxMJcYDiBO53vYUppiM3ZH5u5O0xeWg6GG5i3/u4LxxR9GxqxVGnY9dUU2CHHwLIJr3Zv64gC+b/50nRytgqtaQocGneBvkxehwuRq/sayQ/lf2FJuRyBPxp6mFwHSIIX3mit1OmKqoGcLk5sNLJ1vHexmTzcBM3hQzMN0Uh2j4g8bfw2V57ZYII1JrW8H4ZxE0IsmaKTJRl+VLX37+MzsUZgVdVAd5ANQrggSNXFQ4xUovnr130441NyRtg8n5rwH1ZcUuF3JzOuenhS6f2QvgfDez+dmeVwNbWd0P1JVgXu3IiJEMt4aZMl/TB4CFvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hPNWChdoVXeGgfcwjLOTxHfHejk2gt2gdTEihu+AtYs=; b=md/WeTFkMJvBcxqSyjcv/3FeqaLfMK+QnY8PM/+pZUEJruwrRTMn3vX8GEuL9/RYiAM64cEzRXftLBskDg9V+XlZU1uQjv6P+702OGdLlk54nTogBrw4G2zpRe+WJNfSx0QzYYIB1iArdbOah66uqOtNMmzZSnKbpiIy0WlHGmkqEAD+IOuDganWubRFW+hmfzXO1LFhKyMgn/Lsl3I673aPbKI2cFT9/OC1Nd9r+D4oJRodbLlKJ6l3/MJSpfk0emZ/1TVHIp30cbnfHRco+NCavWCYcGl537m5moTsIfYsSNPnBfpvL7+e2C6h0k5pVa/8Y1U7TIUuD7/9WPwVCA== Received: from CH0P223MB0363.NAMP223.PROD.OUTLOOK.COM (2603:10b6:610:e8::16) by EA2P223MB0935.NAMP223.PROD.OUTLOOK.COM (2603:10b6:303:25e::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8632.34; Wed, 16 Apr 2025 10:58:47 +0000 Received: from CH0P223MB0363.NAMP223.PROD.OUTLOOK.COM ([fe80::1c4f:8a7e:d292:81bc]) by CH0P223MB0363.NAMP223.PROD.OUTLOOK.COM ([fe80::1c4f:8a7e:d292:81bc%3]) with mapi id 15.20.8632.036; Wed, 16 Apr 2025 10:58:47 +0000 From: "softworkz ." <softworkz-at-hotmail.com@ffmpeg.org> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Thread-Topic: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that decode_str() did advance Thread-Index: AQHbqzD6b8QhS9IB3U2xSLilkCUpvrOfQsxwgASOQgCAAAZwAIABQhQAgAAFo+CAADvZgIAAAb7QgAAop4CAAACN0IAAAsaAgAAU7BCAAId6gIAAARQQ Date: Wed, 16 Apr 2025 10:58:47 +0000 Message-ID: <CH0P223MB03637BB27A48476C081F2F69BABD2@CH0P223MB0363.NAMP223.PROD.OUTLOOK.COM> References: <20250414231950.GN4991@pb2> <DM8P223MB0365928500AB53069869DC99BAB32@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> <20250415185538.GR4991@pb2> <DM8P223MB0365E10D38EF9174A32557DFBAB22@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> <20250415225001.GW4991@pb2> <DM8P223MB0365EFE83DE448577271D852BAB22@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> <20250416012145.GE4991@pb2> <DM8P223MB0365836071D915E428907879BABD2@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> <20250416013339.GF4991@pb2> <DM8P223MB03658C2F1D76A2E9901E6F77BABD2@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> <20250416105325.GH4991@pb2> In-Reply-To: <20250416105325.GH4991@pb2> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH0P223MB0363:EE_|EA2P223MB0935:EE_ x-ms-office365-filtering-correlation-id: 61145420-bc0d-4bc1-7fa9-08dd7cd5a9d5 x-microsoft-antispam: BCL:0; ARA:14566002|8060799006|15080799006|7092599003|461199028|8062599003|19110799003|440099028|3412199025|102099032|41001999003; x-microsoft-antispam-message-info: =?us-ascii?Q?cfBuxY1L6FP92M+JdXVhI4enaZvmz+KmWfkQcRPgymr1gRUdc0+iS8DWNEO1?= =?us-ascii?Q?jNmk1+mNU+KM3+qlrQmBw38QKMU5hqVPzxB8ZYEORBw3h6DRxEcnLRpxQGvN?= =?us-ascii?Q?S9IIm776EvkSb6aG9zhJcCsUhkSjQIZ4nklzYIYXwu+nbpQpu4cpo1DQDHoO?= =?us-ascii?Q?6tJ+1CuHLXzN9tLcRlODHov3/TI/Ka/+kOENUzzYWhawHhYcmE55hHJMPjFK?= =?us-ascii?Q?7E7PznpYdzBNR31GZ/xkyuJB6rl6OsYEoTvT1RBGmGMCjCnRYKKNYvBSNiA4?= =?us-ascii?Q?FCGOcx2UD6DCDwwNk11zvAzAzDrH1sBRE4hJCO600wCVYrShcPWCEWCAl1Gj?= =?us-ascii?Q?H/xaLW1Q6UB5qOXzytilMbHYWO8mqh+p9mpOSVG3cyCh5dZTeEvrzJtvjt3A?= =?us-ascii?Q?P99SUWZkxbFnoUROeQ3oIG0KKxEGfa0YTkPUbWhVU6N/M639/AScSgYyDfRj?= =?us-ascii?Q?aNd8OOY/f7bAR6elxPWhVuLICqVDYv1YQlIxImlj2cIUAIpVfeDmRc+jyu0V?= =?us-ascii?Q?vkSVXzGUo/KY8ajST0z4dMzDHyPGKd46DoGCKa2NH1F255KRQH8ldAuxL7nE?= =?us-ascii?Q?owFv2XJmytGn9q4l88NVdYBX8EB1W29Y72iyt+XaBF73XMw1OlzaFyt5VHze?= =?us-ascii?Q?Stmah3REvm2i0j1BR9I4eA6d1AKfpuI94MShvRwr+yzvoy3I2roKAGI+P2h0?= =?us-ascii?Q?No+yE6WhP+3DTPhwWfGirl6/H1KnPCfTdXSuYVz3qyaiTiTGvD6/yQ4qiHLD?= =?us-ascii?Q?FZLR/tyu3dDjABXDblGUmnG6YPC81ZVZwxLpgnIvZSVkv887/YmJS9hA0mwu?= =?us-ascii?Q?AN0SGo5qY6i9nIDptMfud8SHvq+nOhXONx6ArkAkD6TXoF9cSyCnLvzyj+7V?= =?us-ascii?Q?vbYLnkI5GfryImFakUV5Qpy42dRHhFYwUaR6HdH62vr83/ROf6ErGVVGlryV?= =?us-ascii?Q?3J5TyrLY3LkSsFSnNWNv7Tyo1aM8YTQN74kmgHqu6Kg3kRjq9ovLPdeGoM+5?= =?us-ascii?Q?3tBhn728vX4njCg+ocHqstbmmxE61ZvybjooFlNtoFZ5QLMxvLZstMIVpHun?= =?us-ascii?Q?bjBjnTwy7jKlrBl7DMfPyROPVrBw/qZMS/bmStQM9lOtNt2RBfMhRxUmlcgK?= =?us-ascii?Q?NhBYIUMO2or3rbHOThEeyFdHVeT1s2J7nA=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?IRkNuK6yzxkphFgL0jWVl8I2+xssYHO+pZ7tAir81m3KnSDKmsKpkzNsHTfC?= =?us-ascii?Q?NsNcy/luwg2POCP4TWqzKkxWVdSTxvzhcvQ2HlbO3uFpj7d0bmco/40P6Ewt?= =?us-ascii?Q?Qzqn1w1pLXxG5mbc8xEFDQa5mXWxbs5ZwyuVoFxrwNRTZj/hZ6gitO0AETtJ?= =?us-ascii?Q?7rdbBt/glOh4lBK4xB5Gs3LSwMSLOaF18f0+Jv/+2BB8vpXS5uMC5YbuLDSe?= =?us-ascii?Q?MAkkKCbbi0/kqy40/g2spOczB8Zx1yUdBWOYOKMbyumZmLx6Bkj1E0KqgJD2?= =?us-ascii?Q?Sr2MWAd1CsmeAJ+rcqunPISNFAMSAlkn0fTYyZkay4CJCFLWsgR5XFaYhSF8?= =?us-ascii?Q?VRJcCYT/si4NAHHaXBKOt2D9Rju1HmXg0QOTb3Ks4FCw8uL/gLTqXGzfKucs?= =?us-ascii?Q?ISMDXF7trQo4uTNu9h9EskUXysseRGMy4gQY1x5KRCwQCDIa8/md2Wv1qTo3?= =?us-ascii?Q?gMj4A+KmXiBPfGXhJP5gh9kQHE7c79VHAQVsvciRlDF13CcZ1m08rL9cAAwT?= =?us-ascii?Q?S7F6fRa19LflLdiB7twsXaH7S3CWCkoN86upL4mJwD/fz7C7TjN29x2xvude?= =?us-ascii?Q?t7/JEMNHS2WV76vxPDwShLcCnRp8gPj/ZjbP9xpnX+WOWZaIQFSVe6P9uw/4?= =?us-ascii?Q?nmqcx/K1y6Ma0lnr6UVIdmmnPFcxX7ycSaT0+94baOQtB41Lm2FAHSgYMPpg?= =?us-ascii?Q?l0Dkx6mvNYwtyVKPmtzYCdKBYe0zkyK8V4Qw6r7eFYaqFD64bwHbn2CLprfK?= =?us-ascii?Q?CLiLyaqNTjm1VtTxGOeYOdyjYm1mtScxEjzV/UDdCrwFr99iH52/OkY/3opg?= =?us-ascii?Q?62O0oW12olcVnZJ0BQUkbUq7qHNgOf+FZfnDl62bCLS+Nsbb2hm6Buytwo9L?= =?us-ascii?Q?ereZdOA8f6ffxSmGwfUIlosfNSyvsPVsoUoR1UY28lEPsipXSMLj58EKyqd9?= =?us-ascii?Q?cAZ2P0WgOwYuphER+GduHwx1xEyEWOHm7on5qqTsKQoEGDrUOoMNtRTvnuK2?= =?us-ascii?Q?wpu6rdEfX3B/if/kMAkiOTAoBy0MF3mlnkuMkV0a7aLW+ZqKcO5H69xptOT3?= =?us-ascii?Q?rXu0ewfbA9kJ+dkHZ8gZfffllk3U35FST+qpW+UTWgf5m/YbHKJZwOP1eznD?= =?us-ascii?Q?MyE6VMileXIf36b+4N5H9azKu7ctndf6IYIFK37W0mMiDt9Zpd7EtyR+TZ7f?= =?us-ascii?Q?8/dVw2ceRfz+kGAfs6Yjto5VCtM8QZRrdWp39NIyZ4KEXg5u1EhAPEIHBNY?= =?us-ascii?Q?=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH0P223MB0363.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 61145420-bc0d-4bc1-7fa9-08dd7cd5a9d5 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Apr 2025 10:58:47.5599 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: EA2P223MB0935 Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that decode_str() did advance X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org> List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe> List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel> List-Post: <mailto:ffmpeg-devel@ffmpeg.org> List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help> List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe> Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org> Archived-At: <https://master.gitmailbox.com/ffmpegdev/CH0P223MB03637BB27A48476C081F2F69BABD2@CH0P223MB0363.NAMP223.PROD.OUTLOOK.COM/> List-Archive: <https://master.gitmailbox.com/ffmpegdev/> List-Post: <mailto:ffmpegdev@gitmailbox.com> > -----Original Message----- > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of > Michael Niedermayer > Sent: Mittwoch, 16. April 2025 12:53 > To: FFmpeg development discussions and patches <ffmpeg- > devel@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that > decode_str() did advance > > Hi softworkz > > On Wed, Apr 16, 2025 at 02:52:21AM +0000, softworkz . wrote: > > > > > > > -----Original Message----- > > > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of > > > Michael Niedermayer > > > Sent: Mittwoch, 16. April 2025 03:34 > > > To: FFmpeg development discussions and patches <ffmpeg- > > > devel@ffmpeg.org> > > > Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that > > > decode_str() did advance > > > > > > On Wed, Apr 16, 2025 at 01:29:02AM +0000, softworkz . wrote: > > > [...] > > > > > > This will cause deserialization errors for many people in > the > > > world > > > > > > who are processing FFprobe data. > > > > > > > > > > As said, ffprobe should not produce troublesome output > > > > First of all, any patch MUST NOT introduce behavior that goes > > against our own specifications. > > > > From avformat.h: > > > > /** > > * @defgroup metadata_api Public Metadata API > > * @{ > > * @ingroup libavf > > * The metadata API allows libavformat to export metadata tags to a > client > > * application when demuxing. Conversely it allows a client > application to > > * set metadata when muxing. > > * > > * Metadata is exported or set as pairs of key/value strings in the > 'metadata' > > * fields of the AVFormatContext, AVStream, AVChapter and AVProgram > structs > > * using the @ref lavu_dict "AVDictionary" API. Like all strings in > FFmpeg, > > * metadata is assumed to be UTF-8 encoded Unicode. Note that > metadata > > * exported by demuxers isn't checked to be valid UTF-8 in most > cases. > > * > > * Important concepts to keep in mind: > > * - Keys are unique; there can never be 2 tags with the same key. > This is > > * also meant semantically, i.e., a demuxer should not knowingly > produce > > * several keys that are literally different but semantically > identical. > > * E.g., key=Author5, key=Author6. In this example, all authors > must be > > * placed in the same tag. > > * - Metadata is flat, not hierarchical; there are no subtags. If > you > > * want to store, e.g., the email address of the child of > producer Alice > > * and actor Bob, that could have > key=alice_and_bobs_childs_email_address. > > * - Several modifiers can be applied to the tag name. This is done > by > > * appending a dash character ('-') and the modifier name in the > order > > * they appear in the list below -- e.g. foo-eng-sort, not foo- > sort-eng. > > * - language -- a tag whose value is localized for a particular > language > > * is appended with the ISO 639-2/B 3-letter language code. > > * For example: Author-ger=Michael, Author-eng=Mike > > * The original/default language is in the unqualified > "Author" tag. > > * A demuxer should set a default if it sets any translated > tag. > > * - sorting -- a modified version of a tag that should be used > for > > * sorting will have '-sort' appended. E.g. artist="The > Beatles", > > * artist-sort="Beatles, The". > > > > > > Especially: > > > > * E.g., key=Author5, key=Author6. In this example, all authors > must be > > * placed in the same tag. > > > > I think, this tells very clearly how it's gotta be and how not. > > This is written by me 16 years ago > and it made sense at the time. Our APIs did not support multiple > values per > key. > The API supports multiple values per key since 9 years. Using said API But it wasn't enabled for metadata, only the recombs patch enabled that, no? (but, see next message) sw _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".