From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 24EEF4D273 for <ffmpegdev@gitmailbox.com>; Wed, 16 Apr 2025 11:12:09 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 350B9687DB9; Wed, 16 Apr 2025 14:12:07 +0300 (EEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12olkn2056.outbound.protection.outlook.com [40.92.23.56]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0CD40687D4E for <ffmpeg-devel@ffmpeg.org>; Wed, 16 Apr 2025 14:12:01 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mW1ftv8GyV0doZaWU1xXjR36YjH76NZz68FWIiH9ZaVVJXSyxZkb4NTUdPi1tKqct3+y4U+qRzn+ggNGTbtNYJPsiEujOEJTVRBJQPGuQySgA3IBCBU72hUQvcwvYtTNDHBy2zk0JrjF8qk5/uFGgIokUNj5D2zPN28JmWk7bv1GAYaPrRlJNWlpT1ggU5Np+1m5MPhg+Nk7jCWNUtbF6GekAehSQffv/FNCmP6U7E5KRNCdcheSjooGIhvBec4Q5hckLD+eYJtjhZbw8HcuiwbGggab8rGCs1mYKrPsbsjliJfPHW1jBAtsXTHnugn0vja6i55AxrA9I8L6km7JAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kyWJ7xyzLcCcgNpUz0Kwaq/iujzn0X2CnaSPA3c4zG4=; b=AYBONrPSp/C+UHme0Z5bwb3fEovVbp1NwLbZ7UvpFSlrZs7xE6O7GOZX+8PnvIBiRj3rTtznQO3t+TmKspzV3TUmCUZrZVpSrrIzGJ3UHz+SR4jIe+IPGqNyh8yhfSBFpf+ABl26SSfG6mtZqmrJ5udJvnnIct5R7N77snPZ7BEumTYaPjCqxeWiHoeTz2xMzbIZdZlApIt0AuByQGXza1ZA7kvAFgQYXEu7u5crHrnXAz9FHyJxiVQfriuZR+51xvhasBge0/m/7TLjFWca3BeDkRYh6wmaHXCXJVns9IIsEV+7OFSJdHU9KG8wQcfeYwB4ssZF/xE8xk9TO/zi3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kyWJ7xyzLcCcgNpUz0Kwaq/iujzn0X2CnaSPA3c4zG4=; b=ETLfjww8QI3j1s0NAy5KqlOV5b02R0cw2Z4KZiwsF/4EzB5oebJ40LoefAV0YOCXRsJGzZJY8IktBI6v2ckmPpLLYFtuWaC6nr/baH5Ru890TnktdXco7NeDMNfVZAcEaNM7/pOy8l04eW+PeUxqugA4bms+S2rbxTM37Cf3vWaRby3Mvnh4fUyBV/MVgp+PGzXgIHzhxHqY/ceHSygbbV42X2iAUMSvuk80w9ZOfkdHibcVCvT2cHaQPqCT3A44lTEu3juZQ5lFdt0DqFk5iRn1p7b/4bcI8lOOroWoufDDbP57i7LmgCZX5IrInjpfqwUl917AxulmhaGNSefGtw== Received: from CH0P223MB0363.NAMP223.PROD.OUTLOOK.COM (2603:10b6:610:e8::16) by CH2P223MB1402.NAMP223.PROD.OUTLOOK.COM (2603:10b6:610:284::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8655.21; Wed, 16 Apr 2025 11:11:57 +0000 Received: from CH0P223MB0363.NAMP223.PROD.OUTLOOK.COM ([fe80::1c4f:8a7e:d292:81bc]) by CH0P223MB0363.NAMP223.PROD.OUTLOOK.COM ([fe80::1c4f:8a7e:d292:81bc%3]) with mapi id 15.20.8632.036; Wed, 16 Apr 2025 11:11:57 +0000 From: "softworkz ." <softworkz-at-hotmail.com@ffmpeg.org> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Thread-Topic: [FFmpeg-devel] [PATCH v2 04/10] fftools/tf_internal: Use ac_default_item_name Thread-Index: AQHbrrgcqOJ7Tnf5jEyDqy7CSZJYJLOmHVqAgAAFFTA= Date: Wed, 16 Apr 2025 11:11:57 +0000 Message-ID: <CH0P223MB0363788C767678E1A17F27C3BABD2@CH0P223MB0363.NAMP223.PROD.OUTLOOK.COM> References: <pull.66.ffstaging.FFmpeg.1744634826.ffmpegagent@gmail.com> <pull.66.v2.ffstaging.FFmpeg.1744798340.ffmpegagent@gmail.com> <a1b358f5c598d7d1708cdaeb0e87a6cfc25eda01.1744798340.git.ffmpegagent@gmail.com> <GV1P250MB0737CBB9790D7B5D9BEDCBF38FBD2@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM> In-Reply-To: <GV1P250MB0737CBB9790D7B5D9BEDCBF38FBD2@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH0P223MB0363:EE_|CH2P223MB1402:EE_ x-ms-office365-filtering-correlation-id: 5a8194b8-7540-40bc-4d5b-08dd7cd7808d x-microsoft-antispam: BCL:0; ARA:14566002|15080799006|461199028|19110799003|8060799006|8062599003|7092599003|102099032|440099028|3412199025|41001999003; x-microsoft-antispam-message-info: =?us-ascii?Q?ds454I9D4etWMKIAzvJ3orEhyyNr9UsG8VodhBtJLfl1y8VPbTzmspR0tQtA?= =?us-ascii?Q?Y0UYvjX/Fv5V9ZGF702Ypy6B4tB86VEje2hLRvyyZM5xb+RXkhGDotLBtIWY?= =?us-ascii?Q?VM9bOTI4PtIwsPPOVBl6HL6k3/xu/blUW/k8PKgXgRljSHZqRf69QtFkwcMg?= =?us-ascii?Q?MeUDooGnOHxkG6O6p7K4B3vXxGT3t5GZYmdZtmlIbD4zn7jEcK+So13wWPEp?= =?us-ascii?Q?q1jXzjhVcCe7t9P8uAfVisQ8PL2xjc54qiziLSm0vj5goPS1v1pUfuirZRPK?= =?us-ascii?Q?EeP5x3si2IGteoFQCzg7ZHZ6pfmkuA+NttiMaHRO1WIHDMnyvJyDXjnUJFeJ?= =?us-ascii?Q?hCv2Ldqo1yua3NUwkDiUzPh4qYI2KsPyTjrWNK3E1gNQDQ3bAqJN+4xjP8Qi?= =?us-ascii?Q?bopZ7MiODwLUtl2l2qw0lVl998s7krvNIpizVs1tfTopRpKEHmXBxVMbTB0w?= =?us-ascii?Q?A4x+xBvOGymDN108BzuqWU1q1xZI+TcbFSvYJnu1zYvAns/n/6a+aKtcnuBv?= =?us-ascii?Q?DRgfdrrQZk8mWVU55H+5f99ceGtOgQGrrC9RFncxubgTqK+vpwnFAXF9sp//?= =?us-ascii?Q?BkoR1dm59GVoGf3jpYssz/aBKiw5fZoOrz+/ASJ4tAZZ6Tjo+ny9phTIkxsD?= =?us-ascii?Q?nvU/W05V0t6esUlfeghESAL55y9Y71TkDwV6hJzm9lH3ERY3TL0jhPGrR0Wy?= =?us-ascii?Q?g8Q7eb+Wzbq0LKsZ0NiBLQFdnp5s/YYr/NcdxKhWNEku4ChEYMVCLqFeGUSx?= =?us-ascii?Q?5ZUFSQ0ErjMmR5XvMnbylYvFR+MxkiF+Kwr1UCGLVyyzdWb/XhjqE8LPV65V?= =?us-ascii?Q?0KthlOa2EX914aY+WXumXOFBaFqiaCHN7q6914vrC+1owGUnSx5VBW/8tIZ/?= =?us-ascii?Q?KU6MoHK5A8KeEg3inVftjYMTMpPP+o791oBuaPqYnxHPqr9bcEW/fUT4NpLj?= =?us-ascii?Q?06CirKSQ4qBD8pUP15GRkCW04Twvx9vSlsVCHAjCTXMJHN0Ij31BBwz4o7G+?= =?us-ascii?Q?JfKg884eYDjuqFiJkHi3sPStRXjbHdOlome9oB3bGamfvpXEoQn8b/n1/sM7?= =?us-ascii?Q?Bg7ldYyM5zJRTyS3xARKB5Gzwgn+9ihQDY2XCvjXL9zlgB36MCOazq0LGGBL?= =?us-ascii?Q?5wU7ygpP5tnZGpcCepPk9w2Z5EqnHsSqEw=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?d04y7Grh5Wbxk+eJXAgO8mwa91qAlVy73KRvSWulhd2s+wUlGSNE3pjZYRko?= =?us-ascii?Q?HEUcnD5bEzeDJT1YeAZlDjfylinaBlTsJlqhp/bQ0MzMWlHgt4p+KDaea9iq?= =?us-ascii?Q?o7acQmTTNm8HuvFavtb1jKBhxuijt9Z4UcbmPaSlJvk9myIAIV/8q12oeIfW?= =?us-ascii?Q?RRw9VtrMnNuK26tdWjldD6Be+ppQK84cqbzb0YnuJE4qUkE3ob1RPL4YEUIO?= =?us-ascii?Q?U2yxqjUwW/5l978g8nSmO2OmLH4K99pFC+sSDjTI80+UrjTvMxBR3+QenD7Y?= =?us-ascii?Q?/CwTdJKu0/DuJkpcEnll4LX17mHGlGfiEE9J4LUoGRqbdgH9/iXDdyAnSYQb?= =?us-ascii?Q?bVKeC07mcYSgkwDqUJML81QnjkDezxdONi0qZceD3lWFx3c8ZuqE9dys0fEB?= =?us-ascii?Q?OlSkcOTco/IZVx6a1cbSWWpEk1kHHHjT0/CcfR8p+PaFIMttUCuho4KEGKm5?= =?us-ascii?Q?A+ctDdfEW814f/TTIxTVIf3jivJ6rWeziJei05Yck3QPsmBjVcIC1GMv6pHo?= =?us-ascii?Q?2WDAFFTWP5P/3pKsL3v2R1WODaRxNk56btNkKKIpO3q6PdrBxgdMrbNZgVSh?= =?us-ascii?Q?Yu35l19TgtciPPgTWZcjFgcrDzcEkSmOjpte9+UQ09vpuABlsZT2hunttPlp?= =?us-ascii?Q?SUa6fT/vU6kLCybEJ33dI93Q+6vKXGNIQQdxjNQG6zOuZMV/2K5ngof6P2m2?= =?us-ascii?Q?euZmzVfc7K6ruzZ3S6imAdoZiHmJTDBGg1P70Yvg6Ek1wmvv1jbHTHTbkEiv?= =?us-ascii?Q?ZZzHFD7XnNmSZ5+xR3Aa8bVkqhawLbwzQMd5x3jA8PNg5VJ7QGMK0glDSc3k?= =?us-ascii?Q?x4AwItbICiQA728X4E12iMB0aUq5QG/K6dAl5fLW1G73tFYQp+GSICxNKJ02?= =?us-ascii?Q?DZd9bdPPk+28LhV1j1kvBRGi8PwnC8yPDg9XNjHT+gDDTp99kEd2UYIguJ7+?= =?us-ascii?Q?i4tU7D6MneeA1aGAXLIzJ2ZeeNWKR40UOj+xQ6gtjFFwhkFQ3kFGyDvMnbxX?= =?us-ascii?Q?bbHUhLZmt/+80c/eG2x7fSBNyzabi5FLD5Rg2qim1gAkl590XM2eWvQn/wtz?= =?us-ascii?Q?zdSVfnvkBeGYnHj+5iEP2EjfwzsykpDrGH/OkbqkUdi89Hskkqt5ikQCgWxp?= =?us-ascii?Q?CeMNUNVsnbQPYZE997knoNNmwJP9BbIL40ArziD/Gr+TQ99PvLq0oPJBzT63?= =?us-ascii?Q?Rya58bsJpdoFx+nHQIktYy+btaVbnCmGxfKcsgGlXo2BzVUJ5zgv2zGfFHM?= =?us-ascii?Q?=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH0P223MB0363.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 5a8194b8-7540-40bc-4d5b-08dd7cd7808d X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Apr 2025 11:11:57.2541 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2P223MB1402 Subject: Re: [FFmpeg-devel] [PATCH v2 04/10] fftools/tf_internal: Use ac_default_item_name X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org> List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe> List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel> List-Post: <mailto:ffmpeg-devel@ffmpeg.org> List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help> List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe> Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org> Archived-At: <https://master.gitmailbox.com/ffmpegdev/CH0P223MB0363788C767678E1A17F27C3BABD2@CH0P223MB0363.NAMP223.PROD.OUTLOOK.COM/> List-Archive: <https://master.gitmailbox.com/ffmpegdev/> List-Post: <mailto:ffmpegdev@gitmailbox.com> > -----Original Message----- > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of > Andreas Rheinhardt > Sent: Mittwoch, 16. April 2025 12:51 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v2 04/10] fftools/tf_internal: Use > ac_default_item_name > > softworkz: > > From: softworkz <softworkz@hotmail.com> > > > > Signed-off-by: softworkz <softworkz@hotmail.com> > > --- > > fftools/textformat/tf_internal.h | 6 +----- > > 1 file changed, 1 insertion(+), 5 deletions(-) > > > > diff --git a/fftools/textformat/tf_internal.h > b/fftools/textformat/tf_internal.h > > index 7b326328cb..e145bc83bb 100644 > > --- a/fftools/textformat/tf_internal.h > > +++ b/fftools/textformat/tf_internal.h > > @@ -29,13 +29,9 @@ > > #include "avtextformat.h" > > > > #define DEFINE_FORMATTER_CLASS(name) \ > > -static const char *name##_get_name(void *ctx) \ > > -{ \ > > - return #name ; \ > > -} \ > > static const AVClass name##_class = { \ > > .class_name = #name, \ > > - .item_name = name##_get_name, \ > > + .item_name = av_default_item_name, \ > > .option = name##_options \ > > } > > > > I really don't know why you want to do this yourself instead of just > using my patch. > > - Andreas I don't understand. Your patch is making changes to the DEFINE_FORMATTER_CLASS macro in every single tf_* file. But these are already consolidate and removed from those files, so your patch patched something that is removed in the new patchset. What am I missing? Thanks, sw _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".