Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Steven Liu <lq@chinaffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Steven Liu <lq@chinaffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avutil/hwcontext: check the null pointer input value before use it
Date: Thu, 10 Feb 2022 20:22:00 +0800
Message-ID: <CF94B368-B186-4D12-BC0A-ABB6902DA077@chinaffmpeg.org> (raw)
In-Reply-To: <20220210122049.70641-1-lq@chinaffmpeg.org>



> 2022年2月10日 下午8:20,Steven Liu <lq@chinaffmpeg.org> 写道:
> 
> because the src, src->hw_frames_ctx and src->hw_frames_ctx->data can be
> set to null when the user calling av_hwframe_transfer_data, this will
> get crash if they are null.
> 
Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
> Signed-off-by: Steven Liu <lq@chinaffmpeg.org>
> ---
> libavutil/hwcontext.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/libavutil/hwcontext.c b/libavutil/hwcontext.c
> index 31c7840dba..b42a3a6d4d 100644
> --- a/libavutil/hwcontext.c
> +++ b/libavutil/hwcontext.c
> @@ -396,10 +396,13 @@ int av_hwframe_transfer_get_formats(AVBufferRef *hwframe_ref,
> 
> static int transfer_data_alloc(AVFrame *dst, const AVFrame *src, int flags)
> {
> -    AVHWFramesContext *ctx = (AVHWFramesContext*)src->hw_frames_ctx->data;
> +    AVHWFramesContext *ctx = NULL;
>     AVFrame *frame_tmp;
>     int ret = 0;
> 
> +    if (!src || !src->hw_frames_ctx || !src->hw_frames_ctx->data)
> +        return AVERROR(EINVAL);
> +    ctx = (AVHWFramesContext*)src->hw_frames_ctx->data;
>     frame_tmp = av_frame_alloc();
>     if (!frame_tmp)
>         return AVERROR(ENOMEM);
> -- 
> 2.25.0
> 

Thanks

Steven Liu

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2022-02-10 12:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-10 12:20 Steven Liu
2022-02-10 12:22 ` Steven Liu [this message]
2022-02-10 12:27 ` James Almer
2022-02-11  1:43   ` Steven Liu
2022-02-11  2:01     ` James Almer
2022-02-11  2:03       ` Steven Liu
2022-02-11  2:10         ` James Almer
2022-02-11  2:16           ` Steven Liu
2022-02-11  2:39             ` James Almer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CF94B368-B186-4D12-BC0A-ABB6902DA077@chinaffmpeg.org \
    --to=lq@chinaffmpeg.org \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git