From: Christian <chris10317h5@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v4 1/1] avcodec: add external enc libvvenc for H266/VVC
Date: Tue, 4 Jun 2024 16:33:59 +0200
Message-ID: <CCD889CE-B98F-4079-9354-4396F9B72526@gmail.com> (raw)
In-Reply-To: <171749286758.28895.2799827626320724798@lain.khirnov.net>
> On 4. Jun 2024, at 11:21, Anton Khirnov <anton@khirnov.net> wrote:
>
> Quoting Christian Bartnik (2024-05-28 18:26:29)
>> +static const AVOption options[] = {
>> + { "passlogfile", "Filename for 2 pass stats", OFFSET(stats), AV_OPT_TYPE_STRING, {.str = NULL}, 0, 0, VE},
>> + { "stats", "Filename for 2 pass stats", OFFSET(stats), AV_OPT_TYPE_STRING, {.str = NULL}, 0, 0, VE},
>
> These option names conflict with ffmpeg CLI options.
I´m aware of this and I´m using exactly the same approach as libx264 does.
passlogfile is overwriting the CLI option to make the generated passfile filename from the CLI availalbe to the codec.
In the review of my latest version of my patch I was told to use the 'passlogfile' option.
Please let me know how I should pass the passlogfile filename from the CLI to the codec implementation.
>
> --
> Anton Khirnov
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2024-06-04 14:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 16:26 [FFmpeg-devel] [PATCH v4 0/1] Add support for H266/VVC encoding Christian Bartnik
2024-05-28 16:26 ` [FFmpeg-devel] [PATCH v4 1/1] avcodec: add external enc libvvenc for H266/VVC Christian Bartnik
2024-06-03 13:23 ` Nuo Mi
2024-06-03 13:54 ` Andreas Rheinhardt
2024-06-04 9:21 ` Anton Khirnov
2024-06-04 14:33 ` Christian [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CCD889CE-B98F-4079-9354-4396F9B72526@gmail.com \
--to=chris10317h5@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git