From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AA16E47299 for ; Sun, 3 Sep 2023 16:46:07 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9224268C6CB; Sun, 3 Sep 2023 19:46:05 +0300 (EEST) Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BF35A68C051 for ; Sun, 3 Sep 2023 19:45:59 +0300 (EEST) Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-1bf11b1c7d0so9127055ad.0 for ; Sun, 03 Sep 2023 09:45:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693759557; x=1694364357; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=kdjERAiBsdqTeY6hGt9ReNjpcL7I6SqbK/MBLARnqr8=; b=C6mgzzl3neyW8g0Bqh2RCfdFdOCniQaLQMcANY2KdItLuRiMJO2B/6lww9kED9gios wlTUH/WWQzdS+vlLJbprjvwV0uGWfIgqqlEwzmqeKqIcWvSh3VXpu7+DP1dWM04KaCF7 k6YhGzPxqTjoimJvzPgz0bddDEUDU1T1CPwklV0n9LTuTg9nlDpyD+ThtCWyI66lmKFI OkJvZ4SOtrzl4Yayg/rXyrp40Ib4GhDaxuijUwsb3YXVfgWx8JKbcO8/jEjvtLLQGQPs YQLFGHO9efQmKqqqPom+z5sviLmgmdbIGtkFSvou24CjvB5fnYTd+07lsNZ1bCVMHDoG +egg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693759557; x=1694364357; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kdjERAiBsdqTeY6hGt9ReNjpcL7I6SqbK/MBLARnqr8=; b=JIZJrhF1fPKOgWegFI4EGVO/i5v42t52XZ62JCxCTzUhhGiIPSpXzgr1ePC7Cjr4vh Sgj7OnR6wuZi0ZK67ra2+0QHK3agnNY3htBMWM7yRqGrAVAzoEueSL17WVSvESGUTL3Z LKZyoWmKlIwAN0MxPQHlGkhZTqQpZ8IRvnm88k1x4gik+5EQ+dl9EMhORWjmalnwRsEf +P3O4cHBQJ7l4s0c9oDJE/wbsaNqdjc9YjwfP29U9/Pre8c1efI4qV1WjGN6jd64N7ge GgYvcjPGiQdspJRF0PsOSQdBK0nBWZiXaWY/zIlb44KUUo9+RQ3URL5owUHnV+HcAP0E VjpQ== X-Gm-Message-State: AOJu0YygoqcEkDUKpzifSb7feETJcQhoHlLs8ddR2OfWPqovQZVZrS3F +OSMfGYRJIpL1yb5xMUWqvMFjbw85kNIHolzEzzULaoWkXS/Nw== X-Google-Smtp-Source: AGHT+IErFwdSN/UlT/sBs5G9BxeP3PXkeTkfhxP6IP+2dsOUG+fy9ZbHA9CGzkqWL4Eg1kblqTBuEcOswj0R0wIdaeA= X-Received: by 2002:a17:90b:d94:b0:267:f8f4:73ab with SMTP id bg20-20020a17090b0d9400b00267f8f473abmr10504056pjb.16.1693759556707; Sun, 03 Sep 2023 09:45:56 -0700 (PDT) MIME-Version: 1.0 References: <20230903160013.833742-1-aler9.dev@gmail.com> <9f409f1d-12cd-bc1d-3df0-50ee14486881@gmail.com> In-Reply-To: From: aler9 Date: Sun, 3 Sep 2023 18:45:45 +0200 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH v2] avformat/vpcc: fix VP9 metadata in FLV and RTMP X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: I looked again at your previous comment and you suggested to explicitly mention that this patch will affect FLV too, which i did in the title. I didn't see any request to change the code. Do you have any suggestion regarding the code? Il giorno dom 3 set 2023 alle ore 18:17 James Almer ha scritto: > On 9/3/2023 1:15 PM, aler9 wrote: > > sorry, to git add what? > > You say you integrated my comment, but the contents of the patch are > exactly the same. > > > > > Il giorno dom 3 set 2023 alle ore 18:02 James Almer > ha > > scritto: > > > >> On 9/3/2023 1:00 PM, Alessandro Ros wrote: > >>> I integrated James A. comment and fixed patch format. > >> > >> I think you forgot to git add. > >> > >>> > >>> In order to send VP9 tracks with FLV or RTMP, the enhanced RTMP > >>> specification tells that VPCodecConfigurationRecord, a.k.a. vpcC > >>> ISO-BMFF box, must be inserted into a metadata message. However, the > >>> function responsible for generating vpcCs currently returns invalid > >>> boxes, that are lacking the Version and Flag fields, inherited from > >>> FullBox. For some reason, both flags were being added manually in > >>> movenc. This patch fixes the issue. > >>> > >>> Signed-off-by: Alessandro Ros > >>> --- > >>> libavformat/movenc.c | 3 --- > >>> libavformat/vpcc.c | 2 ++ > >>> 2 files changed, 2 insertions(+), 3 deletions(-) > >>> > >>> diff --git a/libavformat/movenc.c b/libavformat/movenc.c > >>> index 7ef6cef46a..696ae5a6c9 100644 > >>> --- a/libavformat/movenc.c > >>> +++ b/libavformat/movenc.c > >>> @@ -1441,10 +1441,7 @@ static int mov_write_vpcc_tag(AVFormatContext > *s, > >> AVIOContext *pb, MOVTrack *tra > >>> > >>> avio_wb32(pb, 0); > >>> ffio_wfourcc(pb, "vpcC"); > >>> - avio_w8(pb, 1); /* version */ > >>> - avio_wb24(pb, 0); /* flags */ > >>> ff_isom_write_vpcc(s, pb, track->vos_data, track->vos_len, > >> track->par); > >>> - > >>> return update_size(pb, pos); > >>> } > >>> > >>> diff --git a/libavformat/vpcc.c b/libavformat/vpcc.c > >>> index ea66959abf..256407dd6d 100644 > >>> --- a/libavformat/vpcc.c > >>> +++ b/libavformat/vpcc.c > >>> @@ -208,6 +208,8 @@ int ff_isom_write_vpcc(AVFormatContext *s, > >> AVIOContext *pb, > >>> if (ret < 0) > >>> return ret; > >>> > >>> + avio_w8(pb, 1); /* version */ > >>> + avio_wb24(pb, 0); /* flags */ > >>> avio_w8(pb, vpcc.profile); > >>> avio_w8(pb, vpcc.level); > >>> avio_w8(pb, (vpcc.bitdepth << 4) | (vpcc.chroma_subsampling << > 1) > >> | vpcc.full_range_flag); > >> _______________________________________________ > >> ffmpeg-devel mailing list > >> ffmpeg-devel@ffmpeg.org > >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > >> > >> To unsubscribe, visit link above, or email > >> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > >> > > _______________________________________________ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > To unsubscribe, visit link above, or email > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".