From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7125446B74 for ; Sun, 3 Sep 2023 16:15:30 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0437668C74A; Sun, 3 Sep 2023 19:15:27 +0300 (EEST) Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id ACDBD68BC71 for ; Sun, 3 Sep 2023 19:15:20 +0300 (EEST) Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-5694a117254so493495a12.0 for ; Sun, 03 Sep 2023 09:15:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693757718; x=1694362518; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=IUG2SAI2VOz+uPGiKgNwUYmxhfUo/ErAkKvPNCYy4Wk=; b=h7fhsEBgHFE+JQBUgf9yH+iuWAsvLdEG26Jff6EBC5wNc7FcI7Ou4bJ3HDH4HukP0H JyUw4N53dUzA0jLIb0ljC+2aoYoRsVAti5hrcP+hos3TbS07BuMaQ65/2xfIqf0hdj96 mM1lNVstaEhInTZbL+Fob2dI8luLhkPhSAtRX5OOh4doPMa93JAUKaAKt9uNfjSwYYk8 2tif+joz9qDzkSaAUGzSctOOolzy40ek1Ydzf1xQ3JUNBDrkT4BW7gahMaInfp6pp6Ub 5iI8dXuFS46mhYrFmRqrAOEQMiyRISYb8gk+pyDN3TSrl0cJ5gT+IdDATK8kstt9K6VE jhJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693757718; x=1694362518; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IUG2SAI2VOz+uPGiKgNwUYmxhfUo/ErAkKvPNCYy4Wk=; b=CrKFvkwV013H1Zr9s0GiFU28AnmQWyLLUF9O/xOvtBXbM18uFlNYBpw5Vafg4qjPQv q2k+h+44v2aL0ZL0HQYj6Us5ZpI1GAbMsYEHgLmIfN/7ioPIFt/OcZbewGkV13t7aWp9 kEbCzxlUa8cvlrxT7C6s5k5nesMiJbF/Mx+hIWYjfgeQ5SbD8s7alvMVb9jtfV6cIQkX mB17GmOrEc2zaEOQHjpLmMxg5J6Zv2aRbgaWVNeFsts1gijW3U5wQ/pFRn3XRsK4gGoS vYPFzvtITqCgbWRwBWUupsKaG3grZfFYdc/C6dzjNJwi1XcGKmlh7iwiVm3LB545pbdV mqWA== X-Gm-Message-State: AOJu0Yx4g9/bg6SHcNbO6zZiBO3aV1GD1VycpyYvbrC7c9Z/L292ZzhJ tkFwcBC94AGgNg65wvRKtADFfc6k/lpACoWCmBEm2ZR8LJU= X-Google-Smtp-Source: AGHT+IEk1vWADGm0DVpRP6OVtfor8bMs1eIaQUtoAepyur4lCCEcHQ5fLRsUS2T6tiZic9cES1wnvPoS3p0WubtTUoM= X-Received: by 2002:a17:90b:3b90:b0:268:3ea0:7160 with SMTP id pc16-20020a17090b3b9000b002683ea07160mr7208767pjb.0.1693757718308; Sun, 03 Sep 2023 09:15:18 -0700 (PDT) MIME-Version: 1.0 References: <20230903160013.833742-1-aler9.dev@gmail.com> <9f409f1d-12cd-bc1d-3df0-50ee14486881@gmail.com> In-Reply-To: <9f409f1d-12cd-bc1d-3df0-50ee14486881@gmail.com> From: aler9 Date: Sun, 3 Sep 2023 18:15:06 +0200 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH v2] avformat/vpcc: fix VP9 metadata in FLV and RTMP X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: sorry, to git add what? Il giorno dom 3 set 2023 alle ore 18:02 James Almer ha scritto: > On 9/3/2023 1:00 PM, Alessandro Ros wrote: > > I integrated James A. comment and fixed patch format. > > I think you forgot to git add. > > > > > In order to send VP9 tracks with FLV or RTMP, the enhanced RTMP > > specification tells that VPCodecConfigurationRecord, a.k.a. vpcC > > ISO-BMFF box, must be inserted into a metadata message. However, the > > function responsible for generating vpcCs currently returns invalid > > boxes, that are lacking the Version and Flag fields, inherited from > > FullBox. For some reason, both flags were being added manually in > > movenc. This patch fixes the issue. > > > > Signed-off-by: Alessandro Ros > > --- > > libavformat/movenc.c | 3 --- > > libavformat/vpcc.c | 2 ++ > > 2 files changed, 2 insertions(+), 3 deletions(-) > > > > diff --git a/libavformat/movenc.c b/libavformat/movenc.c > > index 7ef6cef46a..696ae5a6c9 100644 > > --- a/libavformat/movenc.c > > +++ b/libavformat/movenc.c > > @@ -1441,10 +1441,7 @@ static int mov_write_vpcc_tag(AVFormatContext *s, > AVIOContext *pb, MOVTrack *tra > > > > avio_wb32(pb, 0); > > ffio_wfourcc(pb, "vpcC"); > > - avio_w8(pb, 1); /* version */ > > - avio_wb24(pb, 0); /* flags */ > > ff_isom_write_vpcc(s, pb, track->vos_data, track->vos_len, > track->par); > > - > > return update_size(pb, pos); > > } > > > > diff --git a/libavformat/vpcc.c b/libavformat/vpcc.c > > index ea66959abf..256407dd6d 100644 > > --- a/libavformat/vpcc.c > > +++ b/libavformat/vpcc.c > > @@ -208,6 +208,8 @@ int ff_isom_write_vpcc(AVFormatContext *s, > AVIOContext *pb, > > if (ret < 0) > > return ret; > > > > + avio_w8(pb, 1); /* version */ > > + avio_wb24(pb, 0); /* flags */ > > avio_w8(pb, vpcc.profile); > > avio_w8(pb, vpcc.level); > > avio_w8(pb, (vpcc.bitdepth << 4) | (vpcc.chroma_subsampling << 1) > | vpcc.full_range_flag); > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".