From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3787248FFC for ; Wed, 31 Jan 2024 09:49:06 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6BCB968D130; Wed, 31 Jan 2024 11:49:03 +0200 (EET) Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9F71068C3E8 for ; Wed, 31 Jan 2024 11:48:57 +0200 (EET) Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-29359a09b1bso2560331a91.2 for ; Wed, 31 Jan 2024 01:48:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706694535; x=1707299335; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=eu4OwmxyJAi49/BtwWQBQEFIcqA3fSQUQHr7hkM0vNs=; b=Y+GUDjbRSKIYygLWSp2oYxTbw0Bwe16d1b292rIj90DhDKuQnLfw4xXwGQ0Dse5s68 qeId1PV/ucLwiS5rZfCluZLqExBQ8h6cijnuKbjlpjFVz8Y8vlt59qEU6Ei9G0KFWIXL 4nhW2PE+p8i8uazrKSpbkMtO9BbspWj/lfGYzqfwuGGd4YEFTMZ9rUGK0V4rFt5Tt8qO c+U5VpC2yEld9wab9N4xCDTnjK/gEkSt13uaeajr5rUc0lT6h8m7m/Y6cGlMXXTexUxR mvJKDWCpkECMCedDrjvEbzaXd/tZlEBcfVhL6UYPWW5StOcjJRuOmdH83TUnaEtmMZAh q0MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706694535; x=1707299335; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eu4OwmxyJAi49/BtwWQBQEFIcqA3fSQUQHr7hkM0vNs=; b=DxNuMD2oB+XE1huhQ9jDtkhXUztzb0d1jbufj+IHr2p4NOONASDUPVNS56J/T4BB5f bPBLXVVzvjUS7rYgzrCtxvCchDVBBrX0nP7umCbrI2CqmCWx5QrAVY0ovJ6Rnr6tseO7 BxkPOsw58V3j5Da39x7wnTgReJ2Vnl1dpq8CBkfMq6if8SQwAstlJCybXP0rc0g1UTDt WXJ0DThMnw8b/On+QNO4bICXjBI7fezjiVj9ESwxvnavqHbWSnjzy+vZXLTwvnSazlNj eA2rwwgx2MSC/NHVnzvHU+dU5BdOwMf0Ej2pg71SiPCW6653bR95TqmRBmCtUk0V/ILv RSUA== X-Gm-Message-State: AOJu0YwyRvMFJZSZv2OTR+7ZqSVk5I9RQt1eEHpV5mVXtYPbg2TJ9aM4 Lw2WhQLkEOmK9VpPfw49ExYKxC73mMlTCNpjQhVqZsQ9c3o1gozasXf2u8lUVOf6LXrMGgr9Muj T9nAmLYbL/1KkH1Hb0gDJ4DhdDBcRAguB X-Google-Smtp-Source: AGHT+IEbbKMSwHU3NcF8YsdNr5M6ap2os8/sIG2H8z4wN+bWBg9VwcbmxLKF5+ldb6R1NmI2BDmE3XFWWhtHTB2Y+7M= X-Received: by 2002:a17:90b:182:b0:290:e010:2f90 with SMTP id t2-20020a17090b018200b00290e0102f90mr1113834pjs.30.1706694535033; Wed, 31 Jan 2024 01:48:55 -0800 (PST) MIME-Version: 1.0 References: <20240121151620.214187-1-aler9.dev@gmail.com> In-Reply-To: <20240121151620.214187-1-aler9.dev@gmail.com> From: aler9 Date: Wed, 31 Jan 2024 10:48:43 +0100 Message-ID: To: ffmpeg-devel@ffmpeg.org X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] flv: fix stereo flag when writing PCMA/PCMU X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Hello again, i'm bumping this patch since currently it's impossible to stream 16khz or stereo G711 tracks with RTMP, as these are always marked as 8khz, mono tracks. Please consider merging. Thanks. Il giorno dom 21 gen 2024 alle ore 16:16 Alessandro Ros ha scritto: > Currently, when writing PCMA or PCMU tracks with FLV or RTMP, the > stereo flag and sample rate flag inside RTMP audio messages are > overridden, making impossible to distinguish between mono and stereo > tracks. This patch fixes the issue by restoring the same flag mechanism > of all other codecs, that takes into consideration the right channel > count and sample rate. > > Signed-off-by: Alessandro Ros > --- > libavformat/flvenc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavformat/flvenc.c b/libavformat/flvenc.c > index 874560fac1..772d891136 100644 > --- a/libavformat/flvenc.c > +++ b/libavformat/flvenc.c > @@ -208,10 +208,10 @@ error: > flags |= FLV_CODECID_NELLYMOSER | > FLV_SAMPLESSIZE_16BIT; > break; > case AV_CODEC_ID_PCM_MULAW: > - flags = FLV_CODECID_PCM_MULAW | FLV_SAMPLERATE_SPECIAL | > FLV_SAMPLESSIZE_16BIT; > + flags |= FLV_CODECID_PCM_MULAW | FLV_SAMPLESSIZE_16BIT; > break; > case AV_CODEC_ID_PCM_ALAW: > - flags = FLV_CODECID_PCM_ALAW | FLV_SAMPLERATE_SPECIAL | > FLV_SAMPLESSIZE_16BIT; > + flags |= FLV_CODECID_PCM_ALAW | FLV_SAMPLESSIZE_16BIT; > break; > case 0: > flags |= par->codec_tag << 4; > -- > 2.34.1 > > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".