Thanks for the clarification, attaching an updated patch. The only change is the one comment on qrencode.c. Thank you, Nil On Fri, Mar 7, 2025 at 7:28 PM Michael Niedermayer wrote: > > On Tue, Mar 04, 2025 at 10:17:25AM -0800, Nil Fons Miret via ffmpeg-devel wrote: > > I'm not sure I understand what documentation you'd like to add. The > > behavior of ff_draw_init* is documented in drawutils.h, would you like > > me to add a comment where these functions are called with no risk of > > failing (as far as I can see, only qrencode.c)? My worry is that such > > a comment can easily become outdated. In any case, once I understand > > your request I'm happy to add any more documentation. > > yes, if you add a check that is unreachable and that is intentional > it should receive a comment. > Otherwise it can confuse the reader, also it can be removed when someone > realizes it is unreachable > > thx > > [...] > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > Nations do behave wisely once they have exhausted all other alternatives. > -- Abba Eban > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".