Re: [FFmpeg-devel] [PATCH] libavfilter: guard against ff_draw_init/ff_draw_init2 failures

[Nil Fons Miret via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>]

I'm not sure I understand what documentation you'd like to add. The
behavior of ff_draw_init* is documented in drawutils.h, would you like
me to add a comment where these functions are called with no risk of
failing (as far as I can see, only qrencode.c)? My worry is that such
a comment can easily become outdated. In any case, once I understand
your request I'm happy to add any more documentation.

Thank you,
Nil

On Mon, Mar 3, 2025 at 5:09 PM Michael Niedermayer
<michael@niedermayer.cc> wrote:
>
> On Mon, Mar 03, 2025 at 05:05:58PM -0800, Nil Fons Miret via ffmpeg-devel wrote:
> > From what I can see, that one time it is called with constants in
> > qrencode.c will never fail. I can remove that check, but I am a bit
> > worried it will make it brittle if the internals of ff_draw_init*
> > change later on, e.g. to introduce more failure modes. In fact, I ran
> > across this issue while upgrading an old ffmpeg that did not have some
> > of these checks, so it was one of the new checks that caused the
> > segfault. Let me know what you think, I am open to changing it.
>
> I think the important bit, is it should be documented.
> Its not so important if theres a check. Even with a check it
> could be documented that the case cannot occur currently
>
> thx
>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Everything should be made as simple as possible, but not simpler.
> -- Albert Einstein
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".