From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id EFDAA403DF for ; Fri, 25 Mar 2022 09:14:06 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 127A268B1CB; Fri, 25 Mar 2022 11:14:04 +0200 (EET) Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2790668A43D for ; Fri, 25 Mar 2022 11:13:57 +0200 (EET) Received: by mail-lj1-f170.google.com with SMTP id o6so9461000ljp.3 for ; Fri, 25 Mar 2022 02:13:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NHPpiv3kx30/ZbZ42+79nv5LbvkQN8zq5qujPvrqR7s=; b=pzrrlOh8QTlMDzECf6ov4tsj+XrDs99wBGNCDWY714IslnWQ9fo2VBcbcrFDZrYD+S pkPNWtOXiYojwYnD59Uwg+t9YGlWXSHgStVhCo23fVkqgHExsdM59QaI1vqdhdT5J1Xw /sEzry8g7wCL8esPI++yTXsLiLx9phntgDZunlU6gR0mJY1FB++stXQ/9ulrIg7Mf36E 8AIxnEWrpxlPxJPjgAyvQarX2u0ri/Opq51aBDedqkpjvnZJrqA+iFnzAsTWYJ2kCHCG RBfjTQy7SUBC7t7DC3aRNCYTw/lUEu48la8U4Zoc6vnD6893xd/rlkAi9bCp2fu/c5RQ tDGQ== X-Gm-Message-State: AOAM5316f33AZGFaDkSkf9vBIH4uI6HMrH/Qyx3GMxrsIGlMZexy9gRi WGWrFtreqMaAY5EkAUrGdwSSdaYE8Wu84Q== X-Google-Smtp-Source: ABdhPJwDzE8DbCdlxMw7uVLm3p/wNgICRK9brUJSIwAtVUAoV5Jr/CvLGsDA4IzSJTQavh4FXS2HLw== X-Received: by 2002:a2e:a788:0:b0:248:69c:16ef with SMTP id c8-20020a2ea788000000b00248069c16efmr7461971ljf.374.1648199635672; Fri, 25 Mar 2022 02:13:55 -0700 (PDT) Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com. [209.85.208.181]) by smtp.gmail.com with ESMTPSA id z11-20020a2e7e0b000000b00249a0b136f3sm611927ljc.8.2022.03.25.02.13.55 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Mar 2022 02:13:55 -0700 (PDT) Received: by mail-lj1-f181.google.com with SMTP id c15so9448036ljr.9 for ; Fri, 25 Mar 2022 02:13:55 -0700 (PDT) X-Received: by 2002:a2e:bc22:0:b0:249:80b6:55fd with SMTP id b34-20020a2ebc22000000b0024980b655fdmr7600913ljf.135.1648199634875; Fri, 25 Mar 2022 02:13:54 -0700 (PDT) MIME-Version: 1.0 References: <20220322182511.7747-1-kevin@muxable.com> In-Reply-To: <20220322182511.7747-1-kevin@muxable.com> From: Kevin Wang Date: Fri, 25 Mar 2022 05:13:16 -0400 X-Gmail-Original-Message-ID: Message-ID: To: ffmpeg-devel@ffmpeg.org X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] rtpenc_vp8: Use 15-bit PictureIDs X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: martin@martin.st, Kevin Wang Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Hi, ping on this patch? It's quite simple, happy to answer any questions. On Tue, Mar 22, 2022 at 2:25 PM wrote: > From: Kevin Wang > > 7-bit PictureIDs are not supported by WebRTC: > https://groups.google.com/g/discuss-webrtc/c/333-L02vuWA > > In practice, 15-bit PictureIDs offer better compatibility. > > Signed-off-by: Kevin Wang > --- > libavformat/rtpenc_vp8.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavformat/rtpenc_vp8.c b/libavformat/rtpenc_vp8.c > index 671d245758..655d44517e 100644 > --- a/libavformat/rtpenc_vp8.c > +++ b/libavformat/rtpenc_vp8.c > @@ -35,7 +35,8 @@ void ff_rtp_send_vp8(AVFormatContext *s1, const uint8_t > *buf, int size) > // partition id 0 > *s->buf_ptr++ = 0x90; > *s->buf_ptr++ = 0x80; // Picture id present > - *s->buf_ptr++ = s->frame_count++ & 0x7f; > + *s->buf_ptr++ = ((s->frame_count & 0x7f00) >> 8) | 0x80; > + *s->buf_ptr++ = s->frame_count++ & 0xff; > // Calculate the number of remaining bytes > header_size = s->buf_ptr - s->buf; > max_packet_size = s->max_payload_size - header_size; > -- > 2.34.1 > > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".