From: Mark Gaiser <markg85@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 5/5] Fix review feedback
Date: Mon, 31 Jan 2022 17:33:26 +0100
Message-ID: <CAPd6JnHmXk8HxfE4yxWYcdhb-3TO7Xxihaa1QJZD4AXyK-5wyw@mail.gmail.com> (raw)
In-Reply-To: <20220131154626.GI2829255@pb2>
On Mon, Jan 31, 2022 at 4:46 PM Michael Niedermayer <michael@niedermayer.cc>
wrote:
> On Mon, Jan 31, 2022 at 02:51:16PM +0100, Mark Gaiser wrote:
> > Little bit of consistency in punctuations.
> >
> > Signed-off-by: Mark Gaiser <markg85@gmail.com>
> > ---
> > libavformat/ipfs.c | 12 ++++++------
> > 1 file changed, 6 insertions(+), 6 deletions(-)
>
> Review fixes should be integrated into the patches when they are not
> applied
> yet. not done as a seperate patch on top
>
> also there are some tabs and trailing whitespace in the earlier patches
> which should be fixed too
>
> Thank you, Michael, that's much appreciated! I will fix those in V2.
> thx
>
>
> [...]
>
> --
> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Into a blind darkness they enter who follow after the Ignorance,
> they as if into a greater darkness enter who devote themselves
> to the Knowledge alone. -- Isha Upanishad
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-01-31 16:34 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-31 13:51 [FFmpeg-devel] [PATCH 0/5] Add IPFS and IPNS protocol support Mark Gaiser
2022-01-31 13:51 ` [FFmpeg-devel] [PATCH 1/5] Early version of IPFS " Mark Gaiser
2022-01-31 15:59 ` Michael Niedermayer
2022-01-31 16:06 ` James Almer
2022-01-31 16:34 ` Mark Gaiser
2022-01-31 20:26 ` Lynne
2022-01-31 22:04 ` Mark Gaiser
2022-01-31 13:51 ` [FFmpeg-devel] [PATCH 2/5] Fix up IPNS support Mark Gaiser
2022-01-31 16:00 ` Michael Niedermayer
2022-01-31 13:51 ` [FFmpeg-devel] [PATCH 3/5] Merge IPNS and IPFS handling Mark Gaiser
2022-01-31 13:51 ` [FFmpeg-devel] [PATCH 4/5] Implement logic to determine the IPFS gateway Mark Gaiser
2022-01-31 13:51 ` [FFmpeg-devel] [PATCH 5/5] Fix review feedback Mark Gaiser
2022-01-31 15:46 ` Michael Niedermayer
2022-01-31 16:33 ` Mark Gaiser [this message]
2022-01-31 15:52 ` [FFmpeg-devel] [PATCH 0/5] Add IPFS and IPNS protocol support Tomas Härdin
2022-01-31 16:31 ` Mark Gaiser
2022-01-31 20:22 ` Tomas Härdin
2022-01-31 22:00 ` Mark Gaiser
2022-02-01 16:39 ` Tomas Härdin
2022-02-01 21:18 ` Mark Gaiser
2022-02-02 12:51 ` Tomas Härdin
2022-02-02 13:32 ` Mark Gaiser
2022-02-01 10:06 ` Michael Niedermayer
2022-02-01 16:43 ` Tomas Härdin
2022-02-02 13:48 ` Michael Niedermayer
2022-02-04 10:28 ` Tomas Härdin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPd6JnHmXk8HxfE4yxWYcdhb-3TO7Xxihaa1QJZD4AXyK-5wyw@mail.gmail.com \
--to=markg85@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git