From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 389184132F for ; Mon, 28 Mar 2022 16:35:47 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8D91368B24B; Mon, 28 Mar 2022 19:35:44 +0300 (EEST) Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id EB84A68B23A for ; Mon, 28 Mar 2022 19:35:37 +0300 (EEST) Received: by mail-wm1-f43.google.com with SMTP id i131-20020a1c3b89000000b0038ce25c870dso436958wma.1 for ; Mon, 28 Mar 2022 09:35:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=kxwjnUoQOvPtEpZDTfBnVj9Di68Re8lcWkwxd3mNJnI=; b=L+s6TpWicG+xEm44QakboP0DfPHmaG1YAz4wmKJrxO5CXWSLA/Jxx0Vd5Uc+rfqbEO c29OZLS1fSANf5PybgOacC1Wl6WS85wgpB0f4OZDr9kzIHd92+CuRj+Q28875SOCvl8L glHTAiAF10+Cw5ip5BjiWpdiuOnBePOOXIwErNh5WAhM5NxH9rLJKq7ol971OA5V3iTL xkf1PA9dMtk/VHopjsNKeX3mmcBemYL+cO3Ui/MNRox29tgee+ARJbscCdAFlkCLHA8Q qNpIENIxChmywPbvU/rLSi0jKIXpJfA/eu2PUY6Cu8eySbABYRVYlpPvl/vinZ5Y524O otxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=kxwjnUoQOvPtEpZDTfBnVj9Di68Re8lcWkwxd3mNJnI=; b=i0ndYz6+G+idq9oeom+6QI4YXNsxMGWGlSsPlZa/PvP06nKKWDvtPBdCkWB11JJAXN vNHgusyEqFMu7aVbkuB2rwRyjr1vKWyrXOR23rAxOBdcGR1RX+5BJHEgitpM4WK90/nZ QeYZ+MSspLIthFgsxC+I8pqgTHb62tGxTkGH9ZRFLu1KpTtzJ3YZ5gsNADqpr30z1+tp u7H0fXNSJkkD5sahZUh0oBUzGjhQiDmmsxjz66RUrQEvx9EZ9pveVmv2Tci5MxhWikbY O0Abd/sS0yneJap/7XnVTS4YiI11G+d5O4semFfDpJUu9rmk9qyht02993iKqoy3zpQM muFA== X-Gm-Message-State: AOAM531+qyqICRhUtb0zmVHgfzBw4rcRZkR0/XykTw7jiezuy6/D2xMk ybHDBqSrWBlIcaFa8VCr/LW+ENZMEJOMBwxldZwD/OsF X-Google-Smtp-Source: ABdhPJwV26vliKXRRtjxsqajqnH9lmLwTDKu5mg3IUBratZEvNw5YiErOeri3EL/mTho23fhHI50LX8DN0lgfunnjqE= X-Received: by 2002:a05:600c:4401:b0:38c:8df8:9797 with SMTP id u1-20020a05600c440100b0038c8df89797mr36810071wmn.13.1648485336641; Mon, 28 Mar 2022 09:35:36 -0700 (PDT) MIME-Version: 1.0 References: <20220318145005.241414-1-markg85@gmail.com> <20220318145005.241414-2-markg85@gmail.com> <20220328161900.GG2829255@pb2> In-Reply-To: <20220328161900.GG2829255@pb2> From: Mark Gaiser Date: Mon, 28 Mar 2022 18:34:33 +0200 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH v9 1/1] avformat: Add IPFS protocol support. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, Mar 28, 2022 at 6:19 PM Michael Niedermayer wrote: > On Fri, Mar 18, 2022 at 03:50:05PM +0100, Mark Gaiser wrote: > > This patch adds support for: > > - ffplay ipfs:// > > - ffplay ipns:// > > > > IPFS data can be played from so called "ipfs gateways". > > A gateway is essentially a webserver that gives access to the > > distributed IPFS network. > > > > This protocol support (ipfs and ipns) therefore translates > > ipfs:// and ipns:// to a http:// url. This resulting url is > > then handled by the http protocol. It could also be https > > depending on the gateway provided. > > > > To use this protocol, a gateway must be provided. > > If you do nothing it will try to find it in your > > $HOME/.ipfs/gateway file. The ways to set it manually are: > > 1. Define a -gateway to the gateway. > > 2. Define $IPFS_GATEWAY with the full http link to the gateway. > > 3. Define $IPFS_PATH and point it to the IPFS data path. > > 4. Have IPFS running in your local user folder (under $HOME/.ipfs). > > > > Signed-off-by: Mark Gaiser > > --- > > configure | 2 + > > doc/protocols.texi | 30 ++++ > > libavformat/Makefile | 2 + > > libavformat/ipfsgateway.c | 310 ++++++++++++++++++++++++++++++++++++++ > > libavformat/protocols.c | 2 + > > 5 files changed, 346 insertions(+) > > create mode 100644 libavformat/ipfsgateway.c > > Theres some trailing whitespace which needs to be removed > our git scripts block trailing whitespace in most files > > [...] > > +static int ipfs_close(URLContext *h) > > +{ > > + IPFSGatewayContext *c = h->priv_data; > > + av_free(c->gateway); > > this results in a double free > I believe one of the earlier feedback rounds told me to put it here. It's not free'd anywhere else. Then again, in those earlier rounds I was manipulating c-gateway which right now isn't the case at all anymore. If all that's stopping it from merging is this single line, could you perhaps merge it and remove this line while at it? I'm kinda reluctant to make another patch and wait 1-2 weeks again... > [...] > > thx > > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > Complexity theory is the science of finding the exact solution to an > approximation. Benchmarking OTOH is finding an approximation of the exact > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".