From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AAC1E42B10 for ; Wed, 13 Apr 2022 13:14:34 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AF39068B3C7; Wed, 13 Apr 2022 16:14:31 +0300 (EEST) Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DEE9B68B05A for ; Wed, 13 Apr 2022 16:14:24 +0300 (EEST) Received: by mail-wr1-f46.google.com with SMTP id c10so2600836wrb.1 for ; Wed, 13 Apr 2022 06:14:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=EzueSDcg+NksaCSGg5er0xhA+22zPlUDzF6UIj+ppJc=; b=fSMKv+ILCfsV1rAmpFOlIlnz7xSmu2vicw+5VrZOvdVq9R4YC54hACms9wx9F4O6K/ 4TIopNlPplickZqdRubejuq3wZ4cc9cNfaAJBxt6pS6upfY0bd3xtMbamg1ZIdjfLDs7 1iHiMfrd5IB/Dt8IDSc/w0Oi9Z5TEfen8TuPDxzj4B9Lh4E0LA7lAulQGMHhWoGzsa3L 6oAx22Gwsq+94AHo/efLKNeqzFIbsmOS+I3xzUD4j2fjoZ/qSafV6PeVzKKwNL6d5ZX4 MpeFBIAGxZTqQdm80byFW1vid2j3OcQl13eo59MboRPvn4Mt6VQ5JiaDP9B9CMiXgWvo OnEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=EzueSDcg+NksaCSGg5er0xhA+22zPlUDzF6UIj+ppJc=; b=f6u4Vf1LY7y5sYL+qv+K+Osl/lc3Lt3RclnWrcy9+w+6uYvBMYNvBEUHp+Ufu/NVN0 pGWl8lMD2LbTD5nM2I3Z7kiQY9+p97dY0UPUxzsT9DnMekrgVXVaR9D3ULUdC4BxJrS0 9vKkS/exPAmxJpxm2F+JVQ2piaR8glDqW7Fv/OlrsxhXKmltoamP941RxF0Tvid1Httc hc3RswybTsuLbNw4tqEGXDo8bIx1Y6CQxNwAOHhtG0vYjAx5Yn0nwcE4ftuq6xpo9NwN QfQ0lc8i20qjOA6azi6qi85evHlNSES8GlO+AUEwf578V1SvLprRwNhymdxls36Ox9oA d/aQ== X-Gm-Message-State: AOAM530MnUwuEjlYV9CAsQHpjS4bMFqhFeTxX7/TGCFMTmJx0i2Oz+24 wDnMIlhXqu3ozonayKuo8p/QMp+PHZ1zXT8/5TdeNll9 X-Google-Smtp-Source: ABdhPJwHtWThxElQ0kmWcyCzSJSYLl8RaqFQzHTKBdycmYx6eU7wx5H+51ksxM5saew2Z3H8QthLgywsQo/R6IhmkAY= X-Received: by 2002:a5d:4311:0:b0:205:f26b:fb98 with SMTP id h17-20020a5d4311000000b00205f26bfb98mr33326999wrq.202.1649855663879; Wed, 13 Apr 2022 06:14:23 -0700 (PDT) MIME-Version: 1.0 References: <20220406120056.10537-1-markg85@gmail.com> <20220406120056.10537-2-markg85@gmail.com> <20220410144127.GD2829255@pb2> <20220412180257.GL2829255@pb2> In-Reply-To: From: Mark Gaiser Date: Wed, 13 Apr 2022 15:14:08 +0200 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH v13 1/1] avformat: Add IPFS protocol support. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, Apr 13, 2022 at 2:28 PM Andreas Rheinhardt < andreas.rheinhardt@outlook.com> wrote: > Mark Gaiser: > > On Wed, Apr 13, 2022 at 1:10 AM James Almer wrote: > > > >> > >> > >> On 4/12/2022 3:02 PM, Michael Niedermayer wrote: > >>> On Sun, Apr 10, 2022 at 04:41:27PM +0200, Michael Niedermayer wrote: > >>>> On Wed, Apr 06, 2022 at 02:00:56PM +0200, Mark Gaiser wrote: > >>>> [...] > >>>> > >>>>> + if (stat_ret < 0) { > >>>> > >>>>> + av_log(h, AV_LOG_INFO, "Unable to find IPFS folder. We > >> tried:\n"); > >>>>> + av_log(h, AV_LOG_INFO, "- $IPFS_PATH, which was > >> empty.\n"); > >>>>> + av_log(h, AV_LOG_INFO, "- $HOME/.ipfs (full uri: %s) > >> which doesn't exist.\n", ipfs_full_data_folder); > >>>> > >>>> The 3 av_log() can also be combined > >>>> > >>>> If nothing else is found then ill change that myself and apply in a > day > >> or 2 > >>> > >>> applied > >>> > >>> thx > >> > >> This broke msvc > >> > >>> C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(36): > >> error C2065: 'PATH_MAX': undeclared identifier > >>> C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(36): > >> error C2057: expected constant expression > >>> C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(46): > >> error C2065: 'PATH_MAX': undeclared identifier > >>> C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(46): > >> error C2057: expected constant expression > >>> C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(46): > >> error C2466: cannot allocate an array of constant size 0 > >>> C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(46): > >> error C2133: 'ipfs_full_data_folder': unknown size > >>> C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(47): > >> error C2065: 'PATH_MAX': undeclared identifier > >>> C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(47): > >> error C2057: expected constant expression > >>> C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(47): > >> error C2466: cannot allocate an array of constant size 0 > >>> C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(47): > >> error C2133: 'ipfs_gateway_file': unknown size > >> > >> PATH_MAX seems to be POSIX only. > >> > > > > Seriously? > > > > Shouldn't that define work on windows too? > > For "that define" to work that define needs to exist. Windows has > MAX_PATH, but it is pretty small (260). > > > And why didn't patchwork catch this? > > > > Because there is no MSVC patchwork box. > > > What is the intended define to use for this? > > Note that it used to be a fixed number in the code itself (4096?) but I > > changed it to PATH_MAX as per review suggestions.... > > Then how about just adding > #ifndef MAX_PATH > #define MAX_PATH 4096 > #endif > or something like that. > I'm fine with that but given past feedback I'll wait a little longer for a 2nd opinion too. > > > I grepped over the ffmpeg source. This code is indeed the first cross > > platform code in ffmpeg that uses it. The sole other user is v4l2_m2m.h > but > > that's obviously for windows only. > > You mean "not for Windows". > Oops. Yes, exactly! > - Andreas > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".