From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 581FC40FCD for ; Wed, 13 Apr 2022 15:14:14 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AE43068B3C1; Wed, 13 Apr 2022 18:14:11 +0300 (EEST) Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 81ADB68AEE2 for ; Wed, 13 Apr 2022 18:14:05 +0300 (EEST) Received: by mail-wr1-f52.google.com with SMTP id k22so3118339wrd.2 for ; Wed, 13 Apr 2022 08:14:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=s0CLSkV1tPT+hEJ1yosgB4L6tD7y1zML7o45WqKxAHM=; b=IxSKyAq5abpiQQwkUTH6END5rH3bGjbRoF2YM9TO5zj0T82KUMD0KBrKWtRseT2AMc 93veBiDO8tyzG6BuRrVnJojxh6VqXHRaru8qQz08zzR5qRwmVN5Fnmd4oj3lOoBaQ/X+ ooGxouOqffNhcsB00ab2noXkJG+lBSD0BjqEKWbOvyQ/YWjT3LsNYGJ/n12b/S+1VAa9 49b3S8BdVHUK0J/i5PMFy/Bu3LqOpw7qy0y8muaj7vLSE2kFwlxuTJuNev8Bdg/ndqzc DhCF24mGXXmtzK9PQhqSyarFnDdtzvXv/GB36OMvQ+k5IvZrAgcmVR8i3bu9AJcwkR2p yO3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=s0CLSkV1tPT+hEJ1yosgB4L6tD7y1zML7o45WqKxAHM=; b=elHE7dnB4LoJRHDepJovgKXVVSYu7X//xYHcTbczHoboLQJyXkCvzWy9qR4Q/48D7w GfcD8iCAO7dSS0prnOXq9e7RoUt4a4l739icIHvEJazPszxjYssYSFL9iXG7SnhgXrMo dDZ6Y3P6pbl5l+sR8d79lDInQM7sNnAMckIMpxPq26j/ckY2UcEfvZv8a6pth7fkogrv nGc+hZsHvIyQiZeMmbusWHLKRBCAa8NiUzbDVdPmda+dt8tTAgYv2IcW+cgkUhdwGd4f Zg/iElVZJeW1JKHYR8KsNfkKdVf48Plnlu1xt6GAXm9/cMshQorctkfFtH9nSl7ev9/K eXqA== X-Gm-Message-State: AOAM530cWuJ/os4r67gO4saCbXCVR2CW1QY5cgMhTNAq0CxmJaXjwgEl THC95W9xO5Gwp4cYwh++JyBIzVTu/6DDmjrQfmpASuEz X-Google-Smtp-Source: ABdhPJzSmdp4ZAKYmxn3E3tuErMIdRm7+e+t1mmMyJM9eQEnGsnUzVr23mfjVUqdabo2O5V3N6/1zZD53TJo//IPhy0= X-Received: by 2002:a5d:6c61:0:b0:207:81ec:9471 with SMTP id r1-20020a5d6c61000000b0020781ec9471mr27180004wrz.30.1649862844282; Wed, 13 Apr 2022 08:14:04 -0700 (PDT) MIME-Version: 1.0 References: <20220406120056.10537-1-markg85@gmail.com> <20220406120056.10537-2-markg85@gmail.com> <20220410144127.GD2829255@pb2> <20220412180257.GL2829255@pb2> In-Reply-To: From: Mark Gaiser Date: Wed, 13 Apr 2022 17:13:49 +0200 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH v13 1/1] avformat: Add IPFS protocol support. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, Apr 13, 2022 at 4:45 PM Hendrik Leppkes wrote: > On Wed, Apr 13, 2022 at 3:14 PM Mark Gaiser wrote: > > > > On Wed, Apr 13, 2022 at 2:28 PM Andreas Rheinhardt < > > andreas.rheinhardt@outlook.com> wrote: > > > > > Mark Gaiser: > > > > On Wed, Apr 13, 2022 at 1:10 AM James Almer > wrote: > > > > > > > >> > > > >> > > > >> On 4/12/2022 3:02 PM, Michael Niedermayer wrote: > > > >>> On Sun, Apr 10, 2022 at 04:41:27PM +0200, Michael Niedermayer > wrote: > > > >>>> On Wed, Apr 06, 2022 at 02:00:56PM +0200, Mark Gaiser wrote: > > > >>>> [...] > > > >>>> > > > >>>>> + if (stat_ret < 0) { > > > >>>> > > > >>>>> + av_log(h, AV_LOG_INFO, "Unable to find IPFS folder. > We > > > >> tried:\n"); > > > >>>>> + av_log(h, AV_LOG_INFO, "- $IPFS_PATH, which was > > > >> empty.\n"); > > > >>>>> + av_log(h, AV_LOG_INFO, "- $HOME/.ipfs (full uri: %s) > > > >> which doesn't exist.\n", ipfs_full_data_folder); > > > >>>> > > > >>>> The 3 av_log() can also be combined > > > >>>> > > > >>>> If nothing else is found then ill change that myself and apply in > a > > > day > > > >> or 2 > > > >>> > > > >>> applied > > > >>> > > > >>> thx > > > >> > > > >> This broke msvc > > > >> > > > >>> > C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(36): > > > >> error C2065: 'PATH_MAX': undeclared identifier > > > >>> > C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(36): > > > >> error C2057: expected constant expression > > > >>> > C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(46): > > > >> error C2065: 'PATH_MAX': undeclared identifier > > > >>> > C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(46): > > > >> error C2057: expected constant expression > > > >>> > C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(46): > > > >> error C2466: cannot allocate an array of constant size 0 > > > >>> > C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(46): > > > >> error C2133: 'ipfs_full_data_folder': unknown size > > > >>> > C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(47): > > > >> error C2065: 'PATH_MAX': undeclared identifier > > > >>> > C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(47): > > > >> error C2057: expected constant expression > > > >>> > C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(47): > > > >> error C2466: cannot allocate an array of constant size 0 > > > >>> > C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(47): > > > >> error C2133: 'ipfs_gateway_file': unknown size > > > >> > > > >> PATH_MAX seems to be POSIX only. > > > >> > > > > > > > > Seriously? > > > > > > > > Shouldn't that define work on windows too? > > > > > > For "that define" to work that define needs to exist. Windows has > > > MAX_PATH, but it is pretty small (260). > > > > > > > And why didn't patchwork catch this? > > > > > > > > > > Because there is no MSVC patchwork box. > > > > > > > What is the intended define to use for this? > > > > Note that it used to be a fixed number in the code itself (4096?) > but I > > > > changed it to PATH_MAX as per review suggestions.... > > > > > > Then how about just adding > > > #ifndef MAX_PATH > > > #define MAX_PATH 4096 > > > #endif > > > or something like that. > > > > > > > I'm fine with that but given past feedback I'll wait a little longer for > a > > 2nd opinion too. > > > > master is currently broken, waiting is a luxury for another time. > Fine. Patch incoming. > - Hendrik > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".