From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E4D9F42ADA for ; Tue, 12 Apr 2022 23:23:33 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0D32668B375; Wed, 13 Apr 2022 02:23:31 +0300 (EEST) Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1F23668B2BB for ; Wed, 13 Apr 2022 02:23:25 +0300 (EEST) Received: by mail-wr1-f46.google.com with SMTP id u3so243728wrg.3 for ; Tue, 12 Apr 2022 16:23:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=78oaQQ5LgBUTg8FyZ+/bDi2cu+L7A9NbaFHhSEvyUkU=; b=DzAQWTmwtZE2WXZLUqdHokES2VBn1lsZhxhVMepEV50MtUa2Lgq7L8ZWXbzcpuiK5u E16wi2BRWKQZiMFDo3SXbBaNx6p3IdmNR/0GaoqFGdGIWi6EingTPFI5zXAAz0Ldh+uQ En8pJ3uTJc68QJmXCeHS5llADekB2E9KwZqBLWJUDt4JtWV348zfHlrmUh1bsofqsRqh pLzdwu7vIyp24u1r0n4sY6xRvkQmGDCkK7K/R4rkA6TRmpmjkZZi39wyZoxOtWLsM2/s MDC8vqqf/cmE9Pw1qE+9WcSMSQU87cqwK4/4Y4M053A+A9P5f8XMtlh4UiHi4lo54L0F CSLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=78oaQQ5LgBUTg8FyZ+/bDi2cu+L7A9NbaFHhSEvyUkU=; b=SqDBeVETXIBwA4gms38+w/JHLonvvSffa6pZ9Fgbp7REnmdH27VD3Ck6ZH6REahnNx +Ky2ky2qbt+lKL0mn2S2DWglX3ey7Avc9HPqTyaCk2jXc/2KpHj2LcInZdCvmuH5BfwY La8SegZycp6ZSmz7v+2yFb8oN5bD0ZbG1lLR4EPGHo0r0wzWC5V1GN+g681nmMkbz1Oo AeQkfP/xGDwGUpBhYLEGwgf89DxnrCASfh8BAowAuJH3M3/8u8IW/7EE1HCxG7B4GjHg 8BLbco2KnWDADcOrLXjW1sAyyO6+hJwMlqmIkeY7T9/zW8TMLP36NNbEfCIL4QwLFXMm iomA== X-Gm-Message-State: AOAM533htgIWbD1FazetPVol+HSEPLw3+jVEw66gHzyo0OzxQRRgZO/K 2Y+saiqLZ3k6nSWX70E8sP5ZPxh4Kw8gVW+HVxW/Tt9h X-Google-Smtp-Source: ABdhPJxcFUchwws/VHWtAMHUw5m/gqvlNC0bRoItRrdTzjF3+GXda2LIZreJdCirLZyDpEt+Xs+QjTUtm2O+1ldL2fU= X-Received: by 2002:adf:ea8e:0:b0:207:9a4a:6061 with SMTP id s14-20020adfea8e000000b002079a4a6061mr17245677wrm.42.1649805804034; Tue, 12 Apr 2022 16:23:24 -0700 (PDT) MIME-Version: 1.0 References: <20220406120056.10537-1-markg85@gmail.com> <20220406120056.10537-2-markg85@gmail.com> <20220410144127.GD2829255@pb2> <20220412180257.GL2829255@pb2> In-Reply-To: From: Mark Gaiser Date: Wed, 13 Apr 2022 01:23:10 +0200 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH v13 1/1] avformat: Add IPFS protocol support. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, Apr 13, 2022 at 1:10 AM James Almer wrote: > > > On 4/12/2022 3:02 PM, Michael Niedermayer wrote: > > On Sun, Apr 10, 2022 at 04:41:27PM +0200, Michael Niedermayer wrote: > >> On Wed, Apr 06, 2022 at 02:00:56PM +0200, Mark Gaiser wrote: > >> [...] > >> > >>> + if (stat_ret < 0) { > >> > >>> + av_log(h, AV_LOG_INFO, "Unable to find IPFS folder. We > tried:\n"); > >>> + av_log(h, AV_LOG_INFO, "- $IPFS_PATH, which was > empty.\n"); > >>> + av_log(h, AV_LOG_INFO, "- $HOME/.ipfs (full uri: %s) > which doesn't exist.\n", ipfs_full_data_folder); > >> > >> The 3 av_log() can also be combined > >> > >> If nothing else is found then ill change that myself and apply in a day > or 2 > > > > applied > > > > thx > > This broke msvc > > > C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(36): > error C2065: 'PATH_MAX': undeclared identifier > > C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(36): > error C2057: expected constant expression > > C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(46): > error C2065: 'PATH_MAX': undeclared identifier > > C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(46): > error C2057: expected constant expression > > C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(46): > error C2466: cannot allocate an array of constant size 0 > > C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(46): > error C2133: 'ipfs_full_data_folder': unknown size > > C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(47): > error C2065: 'PATH_MAX': undeclared identifier > > C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(47): > error C2057: expected constant expression > > C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(47): > error C2466: cannot allocate an array of constant size 0 > > C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(47): > error C2133: 'ipfs_gateway_file': unknown size > > PATH_MAX seems to be POSIX only. > Seriously? Shouldn't that define work on windows too? And why didn't patchwork catch this? What is the intended define to use for this? Note that it used to be a fixed number in the code itself (4096?) but I changed it to PATH_MAX as per review suggestions.... I grepped over the ffmpeg source. This code is indeed the first cross platform code in ffmpeg that uses it. The sole other user is v4l2_m2m.h but that's obviously for windows only. > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".