From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3063F40842 for ; Mon, 31 Jan 2022 22:05:50 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 32B9368B143; Tue, 1 Feb 2022 00:05:48 +0200 (EET) Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CE90068AFE1 for ; Tue, 1 Feb 2022 00:05:41 +0200 (EET) Received: by mail-wr1-f53.google.com with SMTP id c23so28149528wrb.5 for ; Mon, 31 Jan 2022 14:05:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=UiuLK5XUjrNahcV66JiuDg+p0I95txmWbbrwV7Q7shU=; b=kJUTfdR2SIZ98GWlVXI2dd93mCDiirgkGkaA+n5Ec5AAZx0iVglYCt4p9JM2OpdMxS l43aLy74nNFbxRB3BlH/6c6m2HpdyqyVrUcR/0Vb7+1S912Z1dw2onk90+XHu2KZQPoU ajGO3ZyLcwvlOn/2G/hD/vVmyeK7WrnVPUsXuVWwaN2yko/PsRnU5G2QdBR91uuylslg new6u0MqExzIPLeybTMQc42wOnjkreKu2CEW5FkglcWLRMMdJxmp5bKAiHNkgKNwQhHk tOJW6sREHrc8GDa5KSSPiUIx5MwpQax3zkWrsoQQLeL9fT8MsPX6VtFBXEP/vjH/PJVh cKIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=UiuLK5XUjrNahcV66JiuDg+p0I95txmWbbrwV7Q7shU=; b=gw6OCHtlGfmhgnUz26GQCD0BsMKy8miAOzggjffh/o/wH2KRJ4jxxyV5CBxltiS6Pd v8dAd1L3j095FmPbjdcurhK45CopHlazwyUv5LdpQ0I52ervLCZ7byHaXSxE/Idp6zzC zPvRWugoyXrJf4xMjgLdpH2ba0CindmJzebuks45x746qyze6KgbrPSHaOPrJBuJWjD3 pjqKFOyxi0nazte6eMLrZw7iygjKWIP0lPVA29MlCowbRheTPexkBNO0r0uKcGQPn4Yy 5VRAYTs/YloqaVoTkmq3DsrCqdQL0REOgU4N1pqkDbfWf9ojD95bjRFx3YuE/lAwZrgB tcAQ== X-Gm-Message-State: AOAM531kdCVVHMBCRNOVDsdLRYEA4gQ1Wx+i5DEsnum31NER2IPzXp1y EF4QfzFnbyQMLBVbLE9zp9jswt9LWGTFHDabq/pqqqKk8sE= X-Google-Smtp-Source: ABdhPJz0lMOL0TFdGOvoMwingEKIE7fDaKr14MF3HKJxRgu8ZZ3TEM2E4WmyUDztZhMQtrHh5D9MTNxkLLX0yvffrTI= X-Received: by 2002:adf:fb0f:: with SMTP id c15mr19827787wrr.42.1643666740964; Mon, 31 Jan 2022 14:05:40 -0800 (PST) MIME-Version: 1.0 References: <20220131135116.14035-1-markg85@gmail.com> <20220131135116.14035-2-markg85@gmail.com> In-Reply-To: From: Mark Gaiser Date: Mon, 31 Jan 2022 23:04:25 +0100 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH 1/5] Early version of IPFS protocol support. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, Jan 31, 2022 at 9:26 PM Lynne wrote: > Jan 31, 2022, 14:51 by markg85@gmail.com: > > > Signed-off-by: Mark Gaiser > > --- > > configure | 1 + > > doc/protocols.texi | 30 ++++++ > > libavformat/Makefile | 1 + > > libavformat/ipfs.c | 202 ++++++++++++++++++++++++++++++++++++++++ > > libavformat/protocols.c | 2 + > > 5 files changed, 236 insertions(+) > > create mode 100644 libavformat/ipfs.c > > > > + > > +static int ipfs_open(URLContext *h, const char *uri, int flags, > AVDictionary **options) > > +{ > > + const char *gatewaysuffix; > > + int ret = 0; > > + Context *c = h->priv_data; > > + > > + if (!av_strstart(uri, "ipfs://", &gatewaysuffix) && > > + !av_strstart(uri, "ipfs:", &gatewaysuffix)) { > > + av_log(h, AV_LOG_ERROR, "Unsupported url %s\n", uri); > > + ret = AVERROR(EINVAL); > > + goto err; > > + } > > + > > + char* ipfs_gateway = "https://ipfs.io/ipfs/"; > > > > That's a no from me. I'd rather have native support rather > than depend on some third party service. Users can just convert > the link themselves if they want to. Surely the IPFS project > has libraries one could use instead. > I'm sorry, that part isn't in the final version. I had sent the patches as I made the implementation. This kinda made this part (and a couple others) weird because a later patch gets rid of it. I'll send the v2 revision as a single patch which will give a clear picture of the changes. No fixed url is in it. Just a little oops from a first time contributor :) > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".