Re: [FFmpeg-devel] [PATCH v8 1/1] avformat: Add IPFS protocol support.

[Mark Gaiser <markg85@gmail.com>]

On Fri, Mar 4, 2022 at 7:09 PM Michael Niedermayer <michael@niedermayer.cc>
wrote:

> On Thu, Mar 03, 2022 at 03:58:53PM +0100, Mark Gaiser wrote:
> > On Tue, Mar 1, 2022 at 11:01 PM Michael Niedermayer <
> michael@niedermayer.cc>
> > wrote:
> >
> > > On Mon, Feb 28, 2022 at 02:09:15PM +0100, Tomas Härdin wrote:
> > > > sön 2022-02-27 klockan 15:29 +0100 skrev Mark Gaiser:
> > > > > Ping 2....
> > > > >
> > > > > I'd really like to get this merged!
> > > > > This kinda blocks me right now from proceeding with IPFS
> integration
> > > > > in
> > > > > Kodi, MPV and VLC. Implementations in those (who rely on ffmpeg)
> are
> > > > > significantly easier once this patch is finally landed in ffmpeg.
> > > >
> > > > I'd like to hear at least one other dev chime in on this one
> > >
> > > what exactly are you not sure about ?
> > > what exactly needs a 2nd look ?
> > >
> >
> > My assumption.
> > In general just a second look by someone other than Tomas.
> > And, as he was skeptical about this patch at first, likely another
> opinion
> > if this makes sense to add in ffmpeg.
> > To me it does very much but i'm biased :)
>
> ipfs support makes sense to be added to ffmpeg. ive seen ipfs urls and ive
> already been annoyed that some tools dont "just" work with them.
> While if i compare this to many other formats which i have never seen
> outside the context of FFmpeg. So from this biased single sample that i
> am, ipfs seems more widespread and thats why iam in favor of its support
>
> thx
>
> Great to have your support :)
Reading that is quite motivating to work on it, no joke!

Just to be clear here. Having this in ffmpeg won't make it "just work" yet.
For a minimal feeling of "hey, it works out of the box" you'd need:
- The next or version after the next IPFS.
- MPV support which relies on this patch to even be supported in mpv
- Have a node running locally

Once you have those then a "mpv ipfs://<cid>" works without any additional
configuration.
We're getting there and this is one (admittedly very significant) step in
that direction.

Lastly. merge time?
Could you do the honors? As I don't have the required permissions.



> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Everything should be made as simple as possible, but not simpler.
> -- Albert Einstein
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".