From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 06E1743DA3 for ; Fri, 9 Dec 2022 12:55:28 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 51E0C68BCB6; Fri, 9 Dec 2022 14:55:26 +0200 (EET) Received: from mail-vk1-f179.google.com (mail-vk1-f179.google.com [209.85.221.179]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CD1C568B52B for ; Fri, 9 Dec 2022 14:55:20 +0200 (EET) Received: by mail-vk1-f179.google.com with SMTP id l17so2078660vkk.3 for ; Fri, 09 Dec 2022 04:55:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=ta//dj2xoZUEJ8ypZUUSILiU8Crl8gKv0pLOjutjU70=; b=hK+N/r1tLkj4JPnhdstfITmo9J6P6doqDII/eqZPKkdVMquXQMHAml5K/mG86GfsA9 iylt8kM+SuHtBmLBn3YPULsOVQb3Cu+2yckeLHU4+z8jsQq8DV6e5wp181GEOp74jn+i YfW+Tl9gEbquTHenChcL/qVci5tn0oCrwSQy4ML/5b+WyXELq22BfQdu+Hk/RQpmwBeL pAT7wETcrRi7kCoxxBhZoDAtdapPs/2Ue6jyMcnCF1xioWpAJsfDxqTdeZn6V6/1VLhi 4QlM/LsPcC9xSuQHLxH6q0VJxCTARYilALncK5UwR5N51WefQJoFnmQnZMZW3EvfryUt L6Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ta//dj2xoZUEJ8ypZUUSILiU8Crl8gKv0pLOjutjU70=; b=3uicmsyphpI6h3cMeoiRCD8q9euXGDJcJ5CEFapXPEg/WvFFMnAvZwJr/gkITmekXS v9WqK/FuJU4tUYn+3yzSuXJZ25DWaYOT8nfM7iljZ36grYmjDdOzBGwTlME1oL150Rv4 t/ijiWWkTdhcrxIXbrrrLimvRl+vvkA9g/DMHWIcmGzcAZwVUBpmHV6SDkBB4OBsBSKL 4bvtepNZJmoBrC2OjvsE4ECfJM229sI41lnkM4+jn8MsSsdQQEdOIaunxkSV09DaiMms wABiUEuJlBWH1Vp0lhgjiamh7xn0/3y/Q2MT/P9h8TGBq8KOqtDWCfxM6Pk/5J2VRzI+ 7ufg== X-Gm-Message-State: ANoB5plsTAEB7YwGYg1dk/ZxY3qObnTe3e1marNqOpvKUBbRnnDjJdAW nWhD1+TMzKGPkt4DTdLBEqGhvbmPONkBgjzWD+c7dzq0 X-Google-Smtp-Source: AA0mqf5goRNyWKaC6GKZW5uwZXUq7Si1UkQ+RE28Dpcwvu603ZqVJSfRYuuRtog3t7t1XobieG+mjZuPdOSCieIXC8M= X-Received: by 2002:a1f:9e08:0:b0:3b7:82e4:f3a1 with SMTP id h8-20020a1f9e08000000b003b782e4f3a1mr52468495vke.17.1670590519012; Fri, 09 Dec 2022 04:55:19 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a05:612c:2428:b0:32a:5eaa:92e4 with HTTP; Fri, 9 Dec 2022 04:55:17 -0800 (PST) In-Reply-To: <20221209134526.GB119445@haasn.xyz> References: <20221209124941.GB66771@haasn.xyz> <20221209134526.GB119445@haasn.xyz> From: Paul B Mahol Date: Fri, 9 Dec 2022 13:55:17 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] Towards YUVJ removal X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 12/9/22, Niklas Haas wrote: > On Fri, 09 Dec 2022 13:10:02 +0100 Andreas Rheinhardt > wrote: >> This is incorrect: Here are the pixel formats advertised by the mjpeg >> encoder: >> >> .p.pix_fmts = (const enum AVPixelFormat[]) { >> AV_PIX_FMT_YUVJ420P, AV_PIX_FMT_YUVJ422P, AV_PIX_FMT_YUVJ444P, >> AV_PIX_FMT_YUV420P, AV_PIX_FMT_YUV422P, AV_PIX_FMT_YUV444P, >> AV_PIX_FMT_NONE >> }, >> >> ffmpeg only inserts the swscale filters, because said list is overridden >> in get_compliance_normal_pix_fmts() in fftools/ffmpeg_filter.c. See >> 059fc2d9da5364627613fb3e6424079e14dbdfd3. >> Also notice that the encoder errors out if fed with limited range data >> depending upon strict_std_compliance (see >> ff_mjpeg_encode_check_pix_fmt()), which is very similar to the first >> approach below; the override being in fftools implies that the breakage >> of the first approach would be confined to users of fftools. > > Oh, you are right. So that presents an alternative to 4 - rather than an > encoder flag, we can tie the auto-conversion in fftools to be tied to > the strict_std_compliance check. > > I will try implementing this approach, it may be the best compromise in > that it presents a clear upgrade path that doesn't break the common > case. > > That said, there still is an encoder that has this problem: "amv". > Currently, this only advertises YUVJ, but after YUVJ removal, it would > be treated equivalently to mjpeg when `strict_std_compliance` is enabled. > > But given that this is a less common format, I think, such a regression > would not be as big a concern. (And we can still special-case it in > fftools, if we want to) Sounds too much hackish. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".