From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 11AC543F8C for ; Tue, 23 Aug 2022 12:33:16 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A5E0768B984; Tue, 23 Aug 2022 15:33:13 +0300 (EEST) Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com [209.85.128.175]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B383868B96C for ; Tue, 23 Aug 2022 15:33:06 +0300 (EEST) Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-324ec5a9e97so374534507b3.7 for ; Tue, 23 Aug 2022 05:33:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc; bh=lAk7QyIqzffZR9wcZVnQntNXKkNn2jLrTANyvOVDevI=; b=gHJIkPWVXcFTzIGSZUBQHf6jqsfGnEyg5ecFN4j8GJiZBMiUrRAhRxjspgAJatgLyT gb2nkGNDi02jlf/csr5PqUtJOSg4Iu2F8tDfrIr5WeDQK0MJ9Fo/m8+9jkZqrxLz+FNA IUQrbtv+sb9vVY/6WGaUP02c0LqsKGGRxkPuallJth5JqCAJZvAZXl+lGmy/JFfY0lWf RRClnPIDgliXRo9cIL1aj7RpGeuULT0nEO9G/amyv6eH+2hgnJTHstqR5Cu1eM0pbPcT jLngXkkgJlLV7G6ru9I4PDaDuiM1bL7pqqmPKYwuJ/T0hHtJ8mzpNUtcARtGNz9N1tM9 RjjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc; bh=lAk7QyIqzffZR9wcZVnQntNXKkNn2jLrTANyvOVDevI=; b=DuJ/eWAc7G34kuw8UhmpZnyb1MFs1m3fjDsS9MRywlQB7AJASgdRC4j1vkn4m6YbKr +kiY8+/YEJY3aDmPIa715/5kvt1hGpW+9ZlTIFMk5DLwSyhjKvZ6sT2KIcD53xsXUqvF 4KppHvoM/C0cMgRzJuib5FhZp4oeFFXPGQIZdTttW9LF5JrO50WRnXHoc0bM8jCtDesC 7Z5GtCzCuj/gP4vbFFRffRGme5WkPyN2IU3YEwCmeWG2qCoYun5Gqosfe2Ti70Q8TK7c K85aqV1XxZS9QMUS/COL/eKCKZ73UWngXE63nz8gi8k6zNCj+hMCJuigkFCykCbOhUgB JsUQ== X-Gm-Message-State: ACgBeo1xEXJ7ADTrJidl7W+hU/m+Ri/LAiJAJU79d7I92BzYbF8LL+4u /AwLJkBlHQj4y5PEnOT6/nJAOdbDRwiT9fpnYIo3LigD X-Google-Smtp-Source: AA6agR7ET0DqC4DBqUoyIxYrlzGuRm6YKXpqpTkYJfTyoV4cMUDSh89Rt2C8TZNqZPKUAMuAnAJAPQ5puSvT4lICGOo= X-Received: by 2002:a25:4115:0:b0:695:5414:97fb with SMTP id o21-20020a254115000000b00695541497fbmr17417460yba.49.1661257984988; Tue, 23 Aug 2022 05:33:04 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Paul B Mahol Date: Tue, 23 Aug 2022 14:36:18 +0200 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/gif: fix duration of last packet/frame X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, Aug 23, 2022 at 2:18 PM Andreas Rheinhardt < andreas.rheinhardt@outlook.com> wrote: > Paul B Mahol: > > Hi, > > > > patch attached. > > > > return ret; > > } > > > > + pkt->duration = av_rescale_q(pict->duration, (AVRational){ 1, 100 }, > > + avctx->time_base); > > pkt->size = outbuf_ptr - pkt->data; > > if (s->image || !avctx->frame_number) > > pkt->flags |= AV_PKT_FLAG_KEY; > > Where does the magic 1/100 timebase come from? For encoding, the > AVFrame's time base is supposed to be AVCodecContext.time_base. This > could actually be done generically for all video-encoders without delay. > (I know that AVFrame has a time_base of its own that is currently unset > and unused.) > > It is from gif demuxer/"container", it uses 1/100 timebase. Similar thing is done for audio encoders. > - Andreas > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".