From: Paul B Mahol <onemda@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/gif: fix duration of last packet/frame
Date: Tue, 23 Aug 2022 14:36:18 +0200
Message-ID: <CAPYw7P7yW_KLY6X97dAE4qDBBtFuBMHOceKG8=NPJkv5JcCyew@mail.gmail.com> (raw)
In-Reply-To: <DB6PR0101MB22143D059F6D533964467E1A8F709@DB6PR0101MB2214.eurprd01.prod.exchangelabs.com>
On Tue, Aug 23, 2022 at 2:18 PM Andreas Rheinhardt <
andreas.rheinhardt@outlook.com> wrote:
> Paul B Mahol:
> > Hi,
> >
> > patch attached.
> >
> > return ret;
> > }
> >
> > + pkt->duration = av_rescale_q(pict->duration, (AVRational){ 1, 100 },
> > + avctx->time_base);
> > pkt->size = outbuf_ptr - pkt->data;
> > if (s->image || !avctx->frame_number)
> > pkt->flags |= AV_PKT_FLAG_KEY;
>
> Where does the magic 1/100 timebase come from? For encoding, the
> AVFrame's time base is supposed to be AVCodecContext.time_base. This
> could actually be done generically for all video-encoders without delay.
> (I know that AVFrame has a time_base of its own that is currently unset
> and unused.)
>
> It is from gif demuxer/"container", it uses 1/100 timebase.
Similar thing is done for audio encoders.
> - Andreas
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-08-23 12:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 9:56 Paul B Mahol
2022-08-23 12:18 ` Andreas Rheinhardt
2022-08-23 12:36 ` Paul B Mahol [this message]
2022-08-23 12:37 ` Andreas Rheinhardt
2022-08-24 16:15 ` Tomas Härdin
2022-08-24 16:23 ` Paul B Mahol
2022-08-23 12:56 ` Andreas Rheinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPYw7P7yW_KLY6X97dAE4qDBBtFuBMHOceKG8=NPJkv5JcCyew@mail.gmail.com' \
--to=onemda@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git