From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C946444465 for ; Sat, 10 Sep 2022 19:43:50 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2D86768BB22; Sat, 10 Sep 2022 22:43:47 +0300 (EEST) Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com [209.85.128.173]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1BC0A68BA2B for ; Sat, 10 Sep 2022 22:43:41 +0300 (EEST) Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-3454b0b1b6dso56036387b3.4 for ; Sat, 10 Sep 2022 12:43:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :from:to:cc:subject:date; bh=dGu9FFKCVAazhSS1acSaiSuHBbstlUiiOPAm1K+BgsM=; b=P1PNiR3RBc+AWw8Hk9LBN3TeVArvK1dOjNG7Zdf3cwHYGUsT1u+Rj/Y/ijLdVfaHjb cctGJS7y//4Sbq8TMbti0sub3fq2Cubj77/l7I54k8+vJId8/9GqLO1ZFf+obRIYGTA0 ptB4JzX2g0sFZVj+7/3ocHF/SAU1CmNDDaI0e94Qh/ZDeH2Hi143CLzE+SxzbU6AhJ6w XuuAm4M7FHmVED/KZgqjOJHwhVx4vN8d7IHjgxRZxPPYTT/SrypZ+puL8WzgVuttRCed qi/X4whtwyFsbhLINnbx9tOLahqta2SxZ9BvYbU/z77Lk3HIUFFyK02QVOZ661+UiAEq wTOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :x-gm-message-state:from:to:cc:subject:date; bh=dGu9FFKCVAazhSS1acSaiSuHBbstlUiiOPAm1K+BgsM=; b=nxMupPD82SN+0PSVcMkYM5L71jUzXsAP0qEJxuN7NuPBqwL0wgMB0gu3+naMMHvWJZ z9TcDF0dkTsddPDtd6Qff/XkpevTNpHgQMgccbdmKWwlVPLuSxU1XR8VX/duKb/m4Wrq KmMwDS8kB8EJiLfglKEX8ranwj74ZuG1Q3GXBbHbMUl7cH2awz/HJq0HyAFYV7Ek6Qb9 NoPbdLfWye58TGXXYhmwUeuscm2yigaVt+e463eG2zlD6A8ORycWJnkbdfM5YJthNSqU fMKEoXRtuyfYciT17RgDiCGzyGwV/UISpFPADps+b+pKxM6KAJiNulTkzJRammBv72OE eHzg== X-Gm-Message-State: ACgBeo0ndCAQJeFmoq4zyJDnVHfgcdEtrzO3U0BFTVz8r2wKpUphfpjh mAom+/VFhLvXD9Co4vQZYC+GqtEfiJ5a9D5pBPHkgwIH X-Google-Smtp-Source: AA6agR6VYj4IfOdV3Rs9/u7VeGy1UUh5Wpj35LZtMFu6JLn0uadnFL/9lw4TGFsEciH692FsZXnxZSvz0TGRm7nAbnY= X-Received: by 2002:a0d:dbc4:0:b0:345:65d1:aabb with SMTP id d187-20020a0ddbc4000000b0034565d1aabbmr16309721ywe.221.1662839019565; Sat, 10 Sep 2022 12:43:39 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a81:7402:0:0:0:0:0 with HTTP; Sat, 10 Sep 2022 12:43:39 -0700 (PDT) In-Reply-To: <3404efdf-af40-201a-ad29-3e5c0e2028ee@gmail.com> References: <75911db2-2335-ec54-02c7-7ef77f7b5649@gmail.com> <3404efdf-af40-201a-ad29-3e5c0e2028ee@gmail.com> From: Paul B Mahol Date: Sat, 10 Sep 2022 21:43:39 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avcodec: Micronas SC-4 decoder and parser X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 9/10/22, James Almer wrote: > On 9/10/2022 4:11 PM, Paul B Mahol wrote: >> On 9/10/22, James Almer wrote: >>> On 9/10/2022 3:27 PM, Paul B Mahol wrote: >>>> Patches attached. >>> >>> This looks like it would fit in adpcm.c as an ADPCM codec. >> >> Nope > > nibble, step, prediction. All terminology taken straight out of adpcm, > down to the decoding process. > The entire decoder can surely be implemented in adpcm.c and named > adpcm_msc4, and unless you have a good reason not to I'd really like you > doing so, because once the AVCodecID is added renaming it becomes a PITA. It have parser, and if you look actually carefully different layout in packets, not sharing anything with adpcm.c code. So please refrain from non-constructive comments. > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".