From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6A99040D8B for ; Thu, 10 Mar 2022 18:45:43 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2852668B1B7; Thu, 10 Mar 2022 20:45:41 +0200 (EET) Received: from mail-yb1-f180.google.com (mail-yb1-f180.google.com [209.85.219.180]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 070EC68A718 for ; Thu, 10 Mar 2022 20:45:35 +0200 (EET) Received: by mail-yb1-f180.google.com with SMTP id j2so12812972ybu.0 for ; Thu, 10 Mar 2022 10:45:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YfqjLrnlepzi2Z4P0lWpAgdX55Eq4IWCi2xnzbiUyBU=; b=ptAc26lgeZjQRoECtSMBkvGWRYu94fzwP5B7IjY6Bc6l3sV6LgeqQDMsPf0oWyB5XZ rQ3YvWL3MvbXLzNa8ynI1f2ZtB9DhPdbhVIX4Fo6+VY53CVyfrzaO0tJuriPH3JxZHC9 WEE2zpkliLpaWfldujenlUYoOMkOCoCR1fYBQYIX60d9PIvxU/cDFpEvbATSBwboslEz t/Vb7vq1ohCvhhF9STs6dcdN9/Q65k7em7RfB9AXd+BuZEb3QcdUZjVvKiReZEBx5Sk1 ZVlshVZGdwoBUiB3uhimtp/l8alsk4nLHO9Xn9Gj9sHJtXw2zND2DUe1TXsFi3AWEdri yTjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YfqjLrnlepzi2Z4P0lWpAgdX55Eq4IWCi2xnzbiUyBU=; b=x85FA4QZBaabxnOj+8pZ/fV/kPLf5gzCOpe6aXufKVgM8YY5Pou/B85SzO1meqBmIZ spT5REaFPkQAODgt0scWdtMk1y8zqUzvRPunLUHHFgN8th/92oXJHWU8ZC2oSPmOwv22 ExWk3F0MjuuBnxMIsB+YMdlzt5u0orfwSsNr996/WHqsdxZi9b30Ppcwczcz9nvhQ68r aOPAYi/Xu1+v65SYwvsAEQXLBZmz/whE1S1RnZRqEw8jqWR5VEaTRxe5nMjGm6NNdpjY nC/Ta2Acm0phIK69vnKF33LTPbjbZv4yR/rWcCWRSETpZzJND9aK0/hWuQhD7+fUYABZ PxbA== X-Gm-Message-State: AOAM532vvhpiF3PVoqlzsZ6XUPUlZAyjKOnBSQGTEy+7w2NFR1j0vg/V okirvDrX5iVCxl4VE5XwEhjpRkgYzjO1jsSsL80= X-Google-Smtp-Source: ABdhPJyoU+BFMT8fhh7707rIS/G1LB9JvXmWgFE0KlmoAKLjSI0nmz36LitDfXnGrLYTAfNSqfDH6vLuOZKPQYmnlcY= X-Received: by 2002:a25:8551:0:b0:62c:2928:6f06 with SMTP id f17-20020a258551000000b0062c29286f06mr5133679ybn.586.1646937933585; Thu, 10 Mar 2022 10:45:33 -0800 (PST) MIME-Version: 1.0 References: <20220219135809.1447-1-Victoria.Zhislina@intel.com> In-Reply-To: From: Paul B Mahol Date: Thu, 10 Mar 2022 19:47:14 +0100 Message-ID: To: Victoria Zhislina X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] libavfilter: zscale performance optimization >4x X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, Mar 10, 2022 at 7:41 PM Victoria Zhislina wrote: > Paul and all, do you have any chances to view my patch from Feb,19? I > assume I'\ve fixed all you've kindly pointed out and even more. Please > correct me if I'm wrong. The only question remaining is - are you ok > with the combination of threading and conditional filter operation (= do > something if it is really required only) or you prefer to split it to 2 > separate corresponding patches. I'd prefer the first option because it > makes git ffmpeg repo and ffmpeg development cleaner not dirtier... > Patch was already applied and some found issues fixed. > > On Tue, Feb 22, 2022 at 11:15 AM Paul B Mahol wrote: > >> On Tue, Feb 22, 2022 at 9:15 AM Paul B Mahol wrote: >> >> > >> > >> > On Tue, Feb 22, 2022 at 6:25 AM Lynne wrote: >> > >> >> 19 Feb 2022, 14:58 by niva213@gmail.com: >> >> >> >> > By ffmpeg threading support implementation via frame slicing and >> doing >> >> > zimg_filter_graph_build that used to take 30-60% of each frame >> processig >> >> > only if necessary (some parameters changed) >> >> > the performance increase vs original version >> >> > in video downscale and color conversion >4x is seen >> >> > on 64 cores Intel Xeon, 3x on i7-6700K (4 cores with HT) >> >> > >> >> > Signed-off-by: Victoria Zhislina >> >> > >> >> >> >> Can't you patch such a feature into the upstream instead? >> >> >> > >> > zscale already have own threading ability, but is very hard to use it, >> > last time i tried. >> > >> >> I mean zimg. >> >> >> > >> > >> >> _______________________________________________ >> >> ffmpeg-devel mailing list >> >> ffmpeg-devel@ffmpeg.org >> >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> >> >> >> To unsubscribe, visit link above, or email >> >> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". >> >> >> > >> _______________________________________________ >> ffmpeg-devel mailing list >> ffmpeg-devel@ffmpeg.org >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> >> To unsubscribe, visit link above, or email >> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". >> > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".