From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7840440297 for ; Mon, 19 Dec 2022 19:35:57 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3F76B68B461; Mon, 19 Dec 2022 21:35:54 +0200 (EET) Received: from mail-ua1-f47.google.com (mail-ua1-f47.google.com [209.85.222.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 77EAD680CE8 for ; Mon, 19 Dec 2022 21:35:48 +0200 (EET) Received: by mail-ua1-f47.google.com with SMTP id n9so2324817uao.13 for ; Mon, 19 Dec 2022 11:35:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=Dx/OLE5Iztg314Pw1WVA1ZII5V60OGXZlw8UCbW18SA=; b=SkqL6CtomD39QlCryQEuDZL5ggxHU+URyyoB/rXhRZJ/sR9r29OFrmPehcgbxtIIqo zyKi9iGw5bpHMfH3cYomU8eUYK7wxEY0WHRRjNo6dZtVsp8XwxagjOMLfqiVLOI2ortL ymSWZAChqAToBnpkCEJaI4yP7+9iPyaMpmKtUu+AfqFzz2mejjiYQ31kM7WPELX67cJx nu8mOLg2lwoaXeB5M4QA9/GkshaLEJUT3aGQWqTd99MNN7FQOEJufJq8r96mjYFyFhdP dHN3PpD6hpd4Q/oC96J2AkY6/Hn2TSfm5zkVKGC9TxRUEunfR6nYgmjWAjSneEvvuu8l JAgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Dx/OLE5Iztg314Pw1WVA1ZII5V60OGXZlw8UCbW18SA=; b=AlELNcpXp2g5n9c1Nwr84fXJtfPhfdP+So0SDxtHRO/tNTniLBodutNGpkUuI68Ccm kWQynPF+iWAw/Ihjjt+LSHZ1VTWJ2pdrsI1A/k2nbIDcLjkHDnY3TLlsVggRt0D1UXKb k1rh1ynD4ulQ9cQP+O031J+VuZwxAmaHWowadAlluL4ss1lMqBIUZ194gxzo/2t/5qJp /F60qzpGoxxyUAd+LPLXhhfNltB5R/rZNQm5WbNiSfLaJBp/tPaCxjM6kZyd1W/+PkWH gE0foCHMpmntVssScxE30rv/0Lgpwc5eRJ14Ps//sWzX2MSLoI87RXm4al7LRyBrFbu+ FlYg== X-Gm-Message-State: ANoB5pkpZS/UDGvXiQWhWeYRbxxdN0fyP7himWF7wbJHA1yZvrqPgDyD r6vv6xHA7eRUFSw+DsTpjsORw6jtdI4BSPjcv6Q8KYb9 X-Google-Smtp-Source: AA0mqf6GDRHVdwI2sirsV5XCnpDgLhCXYHABF/JpRBJNcoxObUuuEcaFCF71YpZNCCXxWVe10FvFv6oZl0cXLZbW24o= X-Received: by 2002:ab0:64d1:0:b0:418:f948:259f with SMTP id j17-20020ab064d1000000b00418f948259fmr39632403uaq.38.1671478546486; Mon, 19 Dec 2022 11:35:46 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a05:612c:2428:b0:32a:5eaa:92e4 with HTTP; Mon, 19 Dec 2022 11:35:45 -0800 (PST) In-Reply-To: <20221218170823.32130-3-michael@niedermayer.cc> References: <20221218170823.32130-1-michael@niedermayer.cc> <20221218170823.32130-3-michael@niedermayer.cc> From: Paul B Mahol Date: Mon, 19 Dec 2022 20:35:45 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 3/5] avcodec/apac: Sanity check bits_per_coded_sample X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 12/18/22, Michael Niedermayer wrote: > Fixes: signed integer overflow: 2147483647 + 1 cannot be represented in type > 'int' > Fixes: > 53931/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APAC_fuzzer-6072913738727424 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavcodec/apac.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/apac.c b/libavcodec/apac.c > index 030f81adce..2501209681 100644 > --- a/libavcodec/apac.c > +++ b/libavcodec/apac.c > @@ -75,7 +75,9 @@ static av_cold int apac_init(AVCodecContext *avctx) > avctx->sample_fmt = AV_SAMPLE_FMT_U8P; > > if (avctx->ch_layout.nb_channels < 1 || > - avctx->ch_layout.nb_channels > 2) > + avctx->ch_layout.nb_channels > 2 || > + avctx->bits_per_coded_sample > 32U > + ) > return AVERROR_INVALIDDATA; > > for (int ch = 0; ch < avctx->ch_layout.nb_channels; ch++) { > -- > 2.17.1 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > Pretty sure bps cant be <8 and >16 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".