From: Paul B Mahol <onemda@gmail.com> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Subject: Re: [FFmpeg-devel] [PATCH v4 0/3] s/RUNTIME/POST_INIT_SETTABLE/ Date: Sat, 6 Jul 2024 12:40:07 +0200 Message-ID: <CAPYw7P7jQ21EDzJfZFAVb5S1nMXChaLyX=APwfRjmPnNeFbhrg@mail.gmail.com> (raw) In-Reply-To: <ZokQTzkL6ZqI/c3g@mariano> On Sat, Jul 6, 2024 at 11:44 AM Stefano Sabatini <stefasab@gmail.com> wrote: > On date Tuesday 2024-07-02 10:08:37 +0100, Andrew Sayers wrote: > > Some notes about this version: > > > > As previously mentioned, I think this is better with all three patches, > > but can live without #2. > > > > I think I've followed the deprecation instructions, but editing > APIchanges > > seems to imply needing a minor version bump? This patch includes said > bump. > > > > > Zhao Zhili argued this bothers users for too little benefit - > > I'd argue it's beneficial to confirm they haven't misused this feature > > in a way that causes bugs in their code, but the old deprecation message > > didn't make that clear enough. This version rephrases the @deprecated > message > > to speak directly to the maintainer. > > I agree the rename is a net improvement in the long term, giving that > this will remove the developer cognitive load and possibly mistakes > due to the misleading name, while the effort required to make the > mechanical rename should be rather small - also there is no evidence > that users are really using this API in their application code so > probably the overall effort is close to zero in this case and it is > only benefits the developers. > > While I agree with Anton that we should avoid duplication, for the > usual arguments that a reference should avoid duplication of content > as much as possible, which inevitably leads to inconsistent content > when it is updated partially, leading to inconsistent information. > Pointless and utterly stupid rename, its much more text to type too. > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-07-06 10:40 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-06-05 13:18 [FFmpeg-devel] [PATCH] lavu/opt: Mention that AVOptions is not reentrant Andrew Sayers 2024-06-05 13:34 ` Paul B Mahol 2024-06-05 13:43 ` Andrew Sayers 2024-06-05 13:46 ` Ronald S. Bultje 2024-06-05 14:22 ` Andrew Sayers 2024-06-05 23:17 ` Michael Niedermayer 2024-06-06 8:29 ` Andrew Sayers 2024-06-06 14:24 ` Michael Niedermayer 2024-06-06 15:16 ` Andrew Sayers 2024-06-06 15:21 ` Andreas Rheinhardt 2024-06-06 15:43 ` Andrew Sayers 2024-06-05 13:50 ` Paul B Mahol 2024-06-06 16:02 ` [FFmpeg-devel] [PATCH v2] lavu/opt: Discuss AV_OPT_FLAG_RUNTIME_PARAM more explicitly Andrew Sayers 2024-06-16 16:04 ` Stefano Sabatini 2024-06-16 17:08 ` [FFmpeg-devel] [PATCH v3 0/3] s/RUNTIME/POST_INIT_SETTABLE/ Andrew Sayers 2024-06-16 17:08 ` [FFmpeg-devel] [PATCH v3 1/3] lavu/opt: Rename AV_OPT_FLAG_RUNTIME_PARAM to ...POST_INIT_SETTABLE_PARAM Andrew Sayers 2024-07-01 22:33 ` Stefano Sabatini 2024-07-02 3:58 ` Zhao Zhili 2024-07-06 9:47 ` Stefano Sabatini 2024-07-02 9:08 ` [FFmpeg-devel] [PATCH v4 0/3] s/RUNTIME/POST_INIT_SETTABLE/ Andrew Sayers 2024-07-02 9:08 ` [FFmpeg-devel] [PATCH v4 1/3] lavu/opt: Rename AV_OPT_FLAG_RUNTIME_PARAM to ...POST_INIT_SETTABLE_PARAM Andrew Sayers 2024-07-02 9:49 ` Anton Khirnov 2024-07-06 9:50 ` Stefano Sabatini 2024-07-02 9:08 ` [FFmpeg-devel] [PATCH v4 2/3] lavu/opt: Mention AV_OPT_FLAG_POST_INIT_SETTABLE_PARAM in more places Andrew Sayers 2024-07-02 9:52 ` Anton Khirnov 2024-07-02 10:13 ` Andrew Sayers 2024-07-02 10:16 ` Anton Khirnov 2024-07-02 10:49 ` Andrew Sayers 2024-07-02 9:08 ` [FFmpeg-devel] [PATCH v4 3/3] all: s/AV_OPT_FLAG_RUNTIME_PARAM/AV_OPT_FLAG_POST_INIT_SETTABLE_PARAM/g Andrew Sayers 2024-07-06 9:37 ` [FFmpeg-devel] [PATCH v4 0/3] s/RUNTIME/POST_INIT_SETTABLE/ Stefano Sabatini 2024-07-06 10:40 ` Paul B Mahol [this message] 2024-07-06 16:49 ` Michael Niedermayer 2024-07-06 18:03 ` Andrew Sayers 2024-07-06 10:41 ` Andrew Sayers 2024-06-16 17:08 ` [FFmpeg-devel] [PATCH v3 2/3] lavu/opt: Mention AV_OPT_FLAG_POST_INIT_SETTABLE_PARAM in more places Andrew Sayers 2024-06-16 17:08 ` [FFmpeg-devel] [PATCH v3 3/3] all: s/AV_OPT_FLAG_RUNTIME_PARAM/AV_OPT_FLAG_POST_INIT_SETTABLE_PARAM/g Andrew Sayers 2024-06-16 17:22 ` [FFmpeg-devel] [PATCH v3 0/3] s/RUNTIME/POST_INIT_SETTABLE/ Paul B Mahol 2024-07-01 22:26 ` Stefano Sabatini
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAPYw7P7jQ21EDzJfZFAVb5S1nMXChaLyX=APwfRjmPnNeFbhrg@mail.gmail.com' \ --to=onemda@gmail.com \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git