From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C3D2C41032 for ; Sat, 12 Feb 2022 12:31:43 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 69C0968B2AD; Sat, 12 Feb 2022 14:31:41 +0200 (EET) Received: from mail-yb1-f173.google.com (mail-yb1-f173.google.com [209.85.219.173]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9F92F68AFA1 for ; Sat, 12 Feb 2022 14:31:35 +0200 (EET) Received: by mail-yb1-f173.google.com with SMTP id j12so10347810ybh.8 for ; Sat, 12 Feb 2022 04:31:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=XYxVgW11sicTuDNfaEnMtEO7uqVnbNLZXD5kLSAfbFQ=; b=dWTmwlQy2FIS5GziMjK11nDJGgYqjKAAnwDtsPnxmjd5xY38Gedx9ORuikk6ZpDtI8 QWf1w1pqb1gYc3yS9xggIHGNDwQqBvB/4CvlY7PHC+4UVC8PGIQj/jHqxiXl78ZpnEqg dAq+8C+edUWU/X87CRkbFlpPHJvT/ZX0JMQJDAA+GP+byTKqazZ9KQ0o5h0ddc3wn8CA SX97o4ujgT8YUMkbMS6aodoA+PinuDY44KkjkoPP5PL4hO87q/gB2DtMOcmgnMqDU1s7 5sxx9y6H0nxPc3d/BeenciDJHaE4rFxAhwN2ay8DYJGTFXURL2CxO735vsvzJFXngasg PVtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=XYxVgW11sicTuDNfaEnMtEO7uqVnbNLZXD5kLSAfbFQ=; b=LuWVvLnc/d5FhSpfOCNj/lYLRMn8y3m4B649ce2/EEfDDxlVozN7O4HIc6AxtPLEPK E8Gdu29pKm11uk8ooykwjc278cVPacth7ABrYQjDFmPmTAlZ8noqkz2Z2N/pQEE6WRxz 0oEK9IZpP0oL7t83rXnc9u0Xc4xJNPj8N5vAQFKVbg1PqIjk7ELkmA5n3iaIGzYN99K/ g+CYIFM9JlWCAo/uE34sOYZhZG3SwWsZQwlIdPV6G4cXU6aDBQd6i8c6JlbEM7syqHwd YPBoK3oCoQLd+pBmibDDuir6fEzgs8Npu/5LIX8k480bZG9qVeDB3K4sY1eL5/IoBzh8 4CyA== X-Gm-Message-State: AOAM5316Pn7zLFqHDsJbtzkx/Eg7SuS7A3E7lc6v30b5RgNtOPtOvYDN nA+Hpl0TkHgAxnFFqB7XzWIeqftt0ngh0P4rqr5Y6L46msk= X-Google-Smtp-Source: ABdhPJzlsavLRabH2QV4YboP0m2Jn2Eie0xCw6ar7tSFdhhDbGs9LM9rE4vZ58wOrt6sQgMM3A+aWGBjm/eEeTVusbI= X-Received: by 2002:a81:e549:: with SMTP id c9mr6173770ywm.34.1644669093947; Sat, 12 Feb 2022 04:31:33 -0800 (PST) MIME-Version: 1.0 References: <20220212001301.4090-1-jamrial@gmail.com> <6024556c-3f09-768a-0567-0ab8f8ba47aa@gmail.com> In-Reply-To: <6024556c-3f09-768a-0567-0ab8f8ba47aa@gmail.com> From: Paul B Mahol Date: Sat, 12 Feb 2022 13:32:08 +0100 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [RFC][PATCH 1/4] avutil/frame: add an internal field to store the size of AVFrame X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sat, Feb 12, 2022 at 1:28 PM James Almer wrote: > On 2/12/2022 9:25 AM, Paul B Mahol wrote: > > On Sat, Feb 12, 2022 at 1:14 AM James Almer wrote: > > > >> This is unfortunately needed to remove (or reduce the awfulness) of > certain > >> modules violating the AVFrame API and using sizeof(AVFrame). > >> > > > > Which modules? > > Anything using wrapped_avframe, so wrapped_avframe decoder and encoder, > and vapoursynth demuxer, which exports wrapped_avframe packets. > > I gave porting the latter into a video source filter some time ago a > try, which would let us remove the "demuxer", but never sent a patch. I > can dig it and do that, but it will not change the fact both the > wrapped_avframe decoder and encoder are still using sizeof(AVFrame). > There was some talk that out VS demuxer is slower than it should be. > > > > > > >> With this, the sizeof(AVFrame) value of the libavutil loaded at runtime > >> can be > >> used instead of the compile time value of whatever library included > frame.h > >> > >> Signed-off-by: James Almer > >> --- > >> This is sucks, but at least less so than the current situation. > >> > >> I don't see wrapped_avframe going away anytime soon, so something must > be > >> done, > >> and last time i tried to change how the packets are generated my > approach > >> was > >> shut down, so here's another attempt. > >> > >> libavutil/frame.c | 3 +++ > >> libavutil/frame_internal.h | 33 +++++++++++++++++++++++++++++++++ > >> 2 files changed, 36 insertions(+) > >> create mode 100644 libavutil/frame_internal.h > >> > >> diff --git a/libavutil/frame.c b/libavutil/frame.c > >> index 8997c85e35..a63d2979db 100644 > >> --- a/libavutil/frame.c > >> +++ b/libavutil/frame.c > >> @@ -23,6 +23,7 @@ > >> #include "cpu.h" > >> #include "dict.h" > >> #include "frame.h" > >> +#include "frame_internal.h" > >> #include "imgutils.h" > >> #include "mem.h" > >> #include "samplefmt.h" > >> @@ -33,6 +34,8 @@ > >> (frame)->channels == \ > >> > av_get_channel_layout_nb_channels((frame)->channel_layout)) > >> > >> +const size_t avpriv_avframe_size = sizeof(AVFrame); > >> + > >> #if FF_API_COLORSPACE_NAME > >> const char *av_get_colorspace_name(enum AVColorSpace val) > >> { > >> diff --git a/libavutil/frame_internal.h b/libavutil/frame_internal.h > >> new file mode 100644 > >> index 0000000000..07c246f86a > >> --- /dev/null > >> +++ b/libavutil/frame_internal.h > >> @@ -0,0 +1,33 @@ > >> +/* > >> + * This file is part of FFmpeg. > >> + * > >> + * FFmpeg is free software; you can redistribute it and/or > >> + * modify it under the terms of the GNU Lesser General Public > >> + * License as published by the Free Software Foundation; either > >> + * version 2.1 of the License, or (at your option) any later version. > >> + * > >> + * FFmpeg is distributed in the hope that it will be useful, > >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of > >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > >> + * Lesser General Public License for more details. > >> + * > >> + * You should have received a copy of the GNU Lesser General Public > >> + * License along with FFmpeg; if not, write to the Free Software > >> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA > >> 02110-1301 USA > >> + */ > >> + > >> +#ifndef AVUTIL_FRAME_INTERNAL_H > >> +#define AVUTIL_FRAME_INTERNAL_H > >> + > >> +#include > >> + > >> +#include "frame.h" > >> + > >> +/** > >> + * sizeof(AVFrame). If you think you need to use it, then you need to > >> change > >> + * your code so you don't instead. > >> + * Meant for exceptions like wrapped_avframe. > >> + */ > >> +extern const size_t avpriv_avframe_size; > >> + > >> +#endif /* AVUTIL_FRAME_INTERNAL_H */ > >> -- > >> 2.35.1 > >> > >> _______________________________________________ > >> ffmpeg-devel mailing list > >> ffmpeg-devel@ffmpeg.org > >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > >> > >> To unsubscribe, visit link above, or email > >> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > >> > > _______________________________________________ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > To unsubscribe, visit link above, or email > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".