From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3F7DA4345F for ; Mon, 13 Jun 2022 10:08:05 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0A91A68B585; Mon, 13 Jun 2022 13:08:03 +0300 (EEST) Received: from mail-yw1-f174.google.com (mail-yw1-f174.google.com [209.85.128.174]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6C46168B345 for ; Mon, 13 Jun 2022 13:07:56 +0300 (EEST) Received: by mail-yw1-f174.google.com with SMTP id 00721157ae682-30ce6492a60so45904417b3.8 for ; Mon, 13 Jun 2022 03:07:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=FO52ykmXxnsFJMW2hzS9spIM2xLTHaKZeAi6/+GVaLQ=; b=qQeR6Mk5VFqkbdkyWfueKC5h+I/gP4r6QyalJl8qQzJDoCrsi0im/TQ+xZaXu3SUv8 wNXHATxkkhhXKvYwadmHg5zaXNr7ZZSUX3ywq0RiztEBttyhi6aekoAlVdLScVIY7via NuO1WGX1Tbq01ETESYiCln++x6dkDqpdvkaqPjcC5XJghLqHZlHjsB894AYS2dbnzGoi UKFPF7q9HWkFBm3jvdkCJwKpbSj2kLUcRBAFl9CZfehvo3hhkaYcmxQPAmPRd1/0C9Mv sefOxAzDEkSk5dvpYOtFKxwq/fzS9Tzgk34YiHAYp+a0WpzFSnhFtdmzgU7KiBxvafE3 D+4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=FO52ykmXxnsFJMW2hzS9spIM2xLTHaKZeAi6/+GVaLQ=; b=Wd6FTNR7OAMVquuUAO3isGiP/haY84v+z8vgBIqNSfSTHvCtu5JpKRw8SmpCMQ6MPA USVTYccEE7EdVPcV9yBHuMCIwNP4wiQJ3RGxNFRprR2LCFBuVpN0QPVtmnmMqBMhrPhQ AOeWGc+mZVQsNkTVrneQMoR4TqHQMoFrbNRiYG8Y7515wCCd5T/X66nq539Z9Qs/AGvl OajORZibeiN5okwxEX2S7PA8PUAGNxtyE8p8p8wrZJUVgnmSEkBa8Krbjpe3CgfcUKBI +ifbBqUK/up12iEq+rSZvlEN7lxQhjwJAqINLQwPehLlu2KuKt8Rgy+XKj/vVV53MSt/ TwBg== X-Gm-Message-State: AOAM53011hoTn51x3xLUXA7fThyYC31mY7JKMmKoN/MJjet/TcbcwfbS W8IJLlJCD8KQkv86+i2eBlveLMoOsJ8kQplpL6DAFlzplfc= X-Google-Smtp-Source: ABdhPJzqoakHBzsoNtFwNsuTzTc+Rv8H+kXLK9Y/TYJ6VYoGqhpZrbH2AYTqvRvJ3jhAOteOsWO52a3HxYPz35v256o= X-Received: by 2002:a81:10cf:0:b0:313:aa13:ed0a with SMTP id 198-20020a8110cf000000b00313aa13ed0amr22120921ywq.40.1655114874932; Mon, 13 Jun 2022 03:07:54 -0700 (PDT) MIME-Version: 1.0 References: <20220610231045.9760-1-michael@niedermayer.cc> <20220610231045.9760-2-michael@niedermayer.cc> <20220611145528.GD396728@pb2> <165511144493.13099.15326407212118049404@lain> <165511367625.5088.3673342022457056713@lain.khirnov.net> In-Reply-To: <165511367625.5088.3673342022457056713@lain.khirnov.net> From: Paul B Mahol Date: Mon, 13 Jun 2022 12:10:44 +0200 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH 2/3] avcodec/fmvc: buffer size is stride based not 4*width X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, Jun 13, 2022 at 11:48 AM Anton Khirnov wrote: > Quoting Paul B Mahol (2022-06-13 11:34:44) > > On Mon, Jun 13, 2022 at 11:10 AM Anton Khirnov > wrote: > > > > > Quoting Paul B Mahol (2022-06-13 10:04:04) > > > > On Sat, Jun 11, 2022 at 4:55 PM Michael Niedermayer < > > > michael@niedermayer.cc> > > > > wrote: > > > > > > > > > On Sat, Jun 11, 2022 at 10:47:57AM +0200, Paul B Mahol wrote: > > > > > > Have you actually tested this "change" ? > > > > > > > > > > On every file i found > > > > > 6-methyl-5-hepten-2-one-CC-db_small.avi > > > > > fmvcVirtualDub_small.avi > > > > > skrzyzowanie4.avi > > > > > fmvc-poc.avi > > > > > > > > > > are there any other files i should test it on ? > > > > > > > > > > > > > Yes, the ones where stride != width. > > > > > > Give examples of such files then. And add more tests. > > > > > > You really should try to be more helpful if you care about this code > > > working. > > > > > > Code works perfectly from start. There are always attempts to break it. > > Your attempts to belittle my work are futile. > > Perfect code should live in an external repository that is locked > against modification. > > The ffmpeg repository is only for imperfect code that evolves with time, > and so requires changes. > > I dunno what Michael attempts to fix. Decoder works fine with valid files. I doubt that encoder would encode random bytes or padding into valid file bitstream. > -- > Anton Khirnov > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".