Re: [FFmpeg-devel] [PATCH v15 1/2] avformat/imf: Demuxer

[Paul B Mahol <onemda@gmail.com>]

Why was this applied?


It still breaks style of ffmpeg code, just from quick glance.

Please revert or I leave this project forever.


On Tue, Dec 28, 2021 at 6:28 AM Zane van Iperen <zane@zanevaniperen.com>
wrote:

>
>
> On 27/12/21 10:47, pal@sandflow.com wrote:
> > From: Pierre-Anthony Lemieux <pal@palemieux.com>
> >
> > Signed-off-by: Pierre-Anthony Lemieux <pal@palemieux.com>
> > ---
> >
> > Notes:
> >      The IMF demuxer accepts as input an IMF CPL. The assets referenced
> by the CPL can be
> >      contained in multiple deliveries, each defined by an ASSETMAP file:
> >
> >      ffmpeg -assetmaps <path of ASSETMAP1>,<path of ASSETMAP>,... -i
> <path of CPL>
> >
> >      If -assetmaps is not specified, FFMPEG looks for a file called
> ASSETMAP.xml in the same directory as the CPL.
> >
> >      EXAMPLE:
> >          ffmpeg -i
> http://ffmpeg-imf-samples-public.s3-website-us-west-1.amazonaws.com/countdown/CPL_f5095caa-f204-4e1c-8a84-7af48c7ae16b.xml
> out.mp4
> >
> >      The Interoperable Master Format (IMF) is a file-based media format
> for the
> >      delivery and storage of professional audio-visual masters.
> >      An IMF Composition consists of an XML playlist (the Composition
> Playlist)
> >      and a collection of MXF files (the Track Files). The Composition
> Playlist (CPL)
> >      assembles the Track Files onto a timeline, which consists of
> multiple tracks.
> >      The location of the Track Files referenced by the Composition
> Playlist is stored
> >      in one or more XML documents called Asset Maps. More details at
> https://www.imfug.com/explainer.
> >      The IMF standard was first introduced in 2013 and is managed by the
> SMPTE.
> >
> >      CHANGE NOTES:
> >
> >      - improve code style
> >
> >   MAINTAINERS              |   1 +
> >   configure                |   3 +-
> >   doc/demuxers.texi        |   6 +
> >   libavformat/Makefile     |   1 +
> >   libavformat/allformats.c |   1 +
> >   libavformat/imf.h        | 207 +++++++++
> >   libavformat/imf_cpl.c    | 841 ++++++++++++++++++++++++++++++++++++
> >   libavformat/imfdec.c     | 899 +++++++++++++++++++++++++++++++++++++++
> >   8 files changed, 1958 insertions(+), 1 deletion(-)
> >   create mode 100644 libavformat/imf.h
> >   create mode 100644 libavformat/imf_cpl.c
> >   create mode 100644 libavformat/imfdec.c
> >
>
> Both patches lgtm, I'll apply in a few days if no objections.
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".