From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E6F0741039 for ; Sat, 12 Feb 2022 12:37:58 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 014C268B2B5; Sat, 12 Feb 2022 14:37:57 +0200 (EET) Received: from mail-yb1-f169.google.com (mail-yb1-f169.google.com [209.85.219.169]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2902C68B1FF for ; Sat, 12 Feb 2022 14:37:51 +0200 (EET) Received: by mail-yb1-f169.google.com with SMTP id j2so32765922ybu.0 for ; Sat, 12 Feb 2022 04:37:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=UBKYYNDcf58ymwNg99pLqJFKD/DFl7A2V28SU3G8fa4=; b=MmesL76SE6Vixqanqw98iwCV+o36C37thzYoAjNv5C/3obj1s8gQSRspKiUj15sU3A w24zMXDzk3wjwGCuAAyg95nmVpMY2qrpRN6FGziu3/wOHBmLgbFWvYKOmCZkCZWt6xFw M/u/qzywqbB+LomSRDpZ28gWkRbYFtzH24gOpY0wdsCj8C6FQo4tK68Fw7gcEjfrf6Qx ivwn1WejN4vhRN1PWmtBUm6gJKCkoqX0PC/Al3N+xGajQ65VQXHAal0OGYlpJnbVg/Q8 ZeSRNbtiQHRsYnj/+6s24YOuBA2fVsky8nF5yZvd+VkUCbT1PxBCMOpMwfMdL/ehmAJE m0vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=UBKYYNDcf58ymwNg99pLqJFKD/DFl7A2V28SU3G8fa4=; b=pHAszwQJjkQdSkSdXNBM01aadsNEJOSBA4uQBILnfG1ONHm4GKSYZnz3R5pdwKOZ2M KbENb5mStnZ3cGUse9U/qhG08vqENKttDdiLb+IbKOyrWR8Vi3LkCPO+YCK4OFZk/Gag K8vTEPufMs7far1VJm98xKhcAlmAd2CTs1ipUx2Xzt8FphZpmsSG83LPyeQE7hPxKm9y ZGKh4Ov4U3J2mJgaeP3VqM5ycRSCjcwTRWy3dp2cBhLnvR00w7QfI6xH2j/KyARebyL/ npzINIOJiIv/Ng1X20gLXNN+HuQ/tSYP+Y1JxrTcJ/xHdOAyyEU2O/kbwByu6zqG8492 ThKQ== X-Gm-Message-State: AOAM532yMXRWznGuuhcJKkRa1ohIZJDwWo5XAlsxLwP2fdF3kqw5UtMD /xZYQqvNvjY//D8e0Rz/aObECtknePBoIXX24igOe4fbxsI= X-Google-Smtp-Source: ABdhPJyJAecTAYu/4HtUHo1E/JwYwuizqZucuWuyfAml++lYMxZNCvf14qpQ7oRBEJpCklDCo+HFK9pZDDFlwWuvuqo= X-Received: by 2002:a25:ca15:: with SMTP id a21mr5355216ybg.321.1644669469796; Sat, 12 Feb 2022 04:37:49 -0800 (PST) MIME-Version: 1.0 References: <20220212001301.4090-1-jamrial@gmail.com> <6024556c-3f09-768a-0567-0ab8f8ba47aa@gmail.com> In-Reply-To: From: Paul B Mahol Date: Sat, 12 Feb 2022 13:38:23 +0100 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [RFC][PATCH 1/4] avutil/frame: add an internal field to store the size of AVFrame X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sat, Feb 12, 2022 at 1:33 PM James Almer wrote: > On 2/12/2022 9:32 AM, Paul B Mahol wrote: > > On Sat, Feb 12, 2022 at 1:28 PM James Almer wrote: > > > >> On 2/12/2022 9:25 AM, Paul B Mahol wrote: > >>> On Sat, Feb 12, 2022 at 1:14 AM James Almer wrote: > >>> > >>>> This is unfortunately needed to remove (or reduce the awfulness) of > >> certain > >>>> modules violating the AVFrame API and using sizeof(AVFrame). > >>>> > >>> > >>> Which modules? > >> > >> Anything using wrapped_avframe, so wrapped_avframe decoder and encoder, > >> and vapoursynth demuxer, which exports wrapped_avframe packets. > >> > >> I gave porting the latter into a video source filter some time ago a > >> try, which would let us remove the "demuxer", but never sent a patch. I > >> can dig it and do that, but it will not change the fact both the > >> wrapped_avframe decoder and encoder are still using sizeof(AVFrame). > >> > > > > There was some talk that out VS demuxer is slower than it should be. > > Really? It's literally a zero copy implementation. It was the entire > reason why it was written using wrapped_avframe instead of the proper > rawvideo. I don't see it getting any faster than it is from our side. > > Slowness is probably not in that part but how VS API is used. > > > > > >> > >>> > >>> > >>>> With this, the sizeof(AVFrame) value of the libavutil loaded at > runtime > >>>> can be > >>>> used instead of the compile time value of whatever library included > >> frame.h > >>>> > >>>> Signed-off-by: James Almer > >>>> --- > >>>> This is sucks, but at least less so than the current situation. > >>>> > >>>> I don't see wrapped_avframe going away anytime soon, so something must > >> be > >>>> done, > >>>> and last time i tried to change how the packets are generated my > >> approach > >>>> was > >>>> shut down, so here's another attempt. > >>>> > >>>> libavutil/frame.c | 3 +++ > >>>> libavutil/frame_internal.h | 33 +++++++++++++++++++++++++++++++++ > >>>> 2 files changed, 36 insertions(+) > >>>> create mode 100644 libavutil/frame_internal.h > >>>> > >>>> diff --git a/libavutil/frame.c b/libavutil/frame.c > >>>> index 8997c85e35..a63d2979db 100644 > >>>> --- a/libavutil/frame.c > >>>> +++ b/libavutil/frame.c > >>>> @@ -23,6 +23,7 @@ > >>>> #include "cpu.h" > >>>> #include "dict.h" > >>>> #include "frame.h" > >>>> +#include "frame_internal.h" > >>>> #include "imgutils.h" > >>>> #include "mem.h" > >>>> #include "samplefmt.h" > >>>> @@ -33,6 +34,8 @@ > >>>> (frame)->channels == \ > >>>> > >> av_get_channel_layout_nb_channels((frame)->channel_layout)) > >>>> > >>>> +const size_t avpriv_avframe_size = sizeof(AVFrame); > >>>> + > >>>> #if FF_API_COLORSPACE_NAME > >>>> const char *av_get_colorspace_name(enum AVColorSpace val) > >>>> { > >>>> diff --git a/libavutil/frame_internal.h b/libavutil/frame_internal.h > >>>> new file mode 100644 > >>>> index 0000000000..07c246f86a > >>>> --- /dev/null > >>>> +++ b/libavutil/frame_internal.h > >>>> @@ -0,0 +1,33 @@ > >>>> +/* > >>>> + * This file is part of FFmpeg. > >>>> + * > >>>> + * FFmpeg is free software; you can redistribute it and/or > >>>> + * modify it under the terms of the GNU Lesser General Public > >>>> + * License as published by the Free Software Foundation; either > >>>> + * version 2.1 of the License, or (at your option) any later version. > >>>> + * > >>>> + * FFmpeg is distributed in the hope that it will be useful, > >>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of > >>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > >>>> + * Lesser General Public License for more details. > >>>> + * > >>>> + * You should have received a copy of the GNU Lesser General Public > >>>> + * License along with FFmpeg; if not, write to the Free Software > >>>> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA > >>>> 02110-1301 USA > >>>> + */ > >>>> + > >>>> +#ifndef AVUTIL_FRAME_INTERNAL_H > >>>> +#define AVUTIL_FRAME_INTERNAL_H > >>>> + > >>>> +#include > >>>> + > >>>> +#include "frame.h" > >>>> + > >>>> +/** > >>>> + * sizeof(AVFrame). If you think you need to use it, then you need to > >>>> change > >>>> + * your code so you don't instead. > >>>> + * Meant for exceptions like wrapped_avframe. > >>>> + */ > >>>> +extern const size_t avpriv_avframe_size; > >>>> + > >>>> +#endif /* AVUTIL_FRAME_INTERNAL_H */ > >>>> -- > >>>> 2.35.1 > >>>> > >>>> _______________________________________________ > >>>> ffmpeg-devel mailing list > >>>> ffmpeg-devel@ffmpeg.org > >>>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > >>>> > >>>> To unsubscribe, visit link above, or email > >>>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > >>>> > >>> _______________________________________________ > >>> ffmpeg-devel mailing list > >>> ffmpeg-devel@ffmpeg.org > >>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > >>> > >>> To unsubscribe, visit link above, or email > >>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > >> > >> _______________________________________________ > >> ffmpeg-devel mailing list > >> ffmpeg-devel@ffmpeg.org > >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > >> > >> To unsubscribe, visit link above, or email > >> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > >> > > _______________________________________________ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > To unsubscribe, visit link above, or email > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".