From: Paul B Mahol <onemda@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/utvideodec: add vlc multi support
Date: Fri, 15 Sep 2023 01:24:39 +0200
Message-ID: <CAPYw7P7ZwB3KgoEj_3bCqfx1Nk812vim_Znu+K=7YLqDKwpZmw@mail.gmail.com> (raw)
In-Reply-To: <20230914221908.GA2105706@pb2>
On Fri, Sep 15, 2023 at 12:19 AM Michael Niedermayer <michael@niedermayer.cc>
wrote:
> On Wed, Sep 06, 2023 at 10:19:29PM +0000, Christophe Gisquet wrote:
> > ffmpeg | branch: master | Christophe Gisquet <
> christophe.gisquet@gmail.com> | Sun Jul 9 12:56:35 2017 +0000|
> [da888b790af779a7489068c25f9e7ab8ac653d41] | committer: Paul B Mahol
> >
> > avcodec/utvideodec: add vlc multi support
> >
> > Faster decoding, by average 50% faster overall.
> >
> > >
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=da888b790af779a7489068c25f9e7ab8ac653d41
> > ---
> >
> > libavcodec/utvideo.h | 1 +
> > libavcodec/utvideodec.c | 92
> ++++++++++++++++++++++++-------------------------
> > 2 files changed, 46 insertions(+), 47 deletions(-)
> >
> > diff --git a/libavcodec/utvideo.h b/libavcodec/utvideo.h
> > index 9da9329ff3..e5160aa394 100644
> > --- a/libavcodec/utvideo.h
> > +++ b/libavcodec/utvideo.h
> > @@ -81,6 +81,7 @@ typedef struct UtvideoContext {
> > ptrdiff_t slice_stride;
> > uint8_t *slice_bits, *slice_buffer[4];
> > int slice_bits_size;
> > + void *buffer;
> >
> > const uint8_t *packed_stream[4][256];
> > size_t packed_stream_size[4][256];
> > diff --git a/libavcodec/utvideodec.c b/libavcodec/utvideodec.c
> > index 1f00c58950..ab390be0fa 100644
> > --- a/libavcodec/utvideodec.c
> > +++ b/libavcodec/utvideodec.c
> > @@ -46,7 +46,7 @@ typedef struct HuffEntry {
> > } HuffEntry;
> >
> > static int build_huff(UtvideoContext *c, const uint8_t *src, VLC *vlc,
> > - int *fsym, unsigned nb_elems)
> > + VLC_MULTI *multi, int *fsym, unsigned nb_elems)
> > {
>
> before this patch the whole application finishes within 130ms
> after this patch with teh short table
>
>
> 255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,24,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,24,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,
>
This is of no use to me.
If you have file then provide it.
>
> this times out eventually not exiting the first call
> it always got stuck in many calls to add_level()
>
> thx
>
> [...]
> --
> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Dictatorship: All citizens are under surveillance, all their steps and
> actions recorded, for the politicians to enforce control.
> Democracy: All politicians are under surveillance, all their steps and
> actions recorded, for the citizens to enforce control.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-09-14 23:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230906221930.ACB65410B57@natalya.videolan.org>
2023-09-14 22:19 ` Michael Niedermayer
2023-09-14 23:24 ` Paul B Mahol [this message]
2023-09-16 16:40 ` Michael Niedermayer
2023-09-17 8:40 ` Paul B Mahol
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPYw7P7ZwB3KgoEj_3bCqfx1Nk812vim_Znu+K=7YLqDKwpZmw@mail.gmail.com' \
--to=onemda@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git