From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4D74B40AF8 for ; Sun, 6 Mar 2022 21:25:47 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3A69968B0BB; Sun, 6 Mar 2022 23:25:45 +0200 (EET) Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com [209.85.128.173]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5CB4B68AF2A for ; Sun, 6 Mar 2022 23:25:38 +0200 (EET) Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-2d07ae0b1c4so143908387b3.11 for ; Sun, 06 Mar 2022 13:25:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=dtTLucMk0AMxGfL/4ZFRdiwAqLv4RCXCFQ+aWKUZhAw=; b=R7PXicnx8n3Y6ymCGezTFSL6fwSwD+HgJXz7m9KASlcp+NmdjSmCGvq3PyPJXPkUOm ulHZnFMj66m3XUdy8eGQpko9cnMiTHF0K+1Xvy0DD0dZ+aZ4/ypuaf/B1ea4CsWcjZTa uCQvksFtVF8boTPC4BDaVNzfjUaPxRoHkA/6ZQAfVz/o0kADXGi8qrGx1OkmT1GTFI/r xi3p88FpmjtDBXhkyJ/zO6HQRwTdcbTETjH0gY3Q969In6AZAvyt3lDOUsi+5xDkwhjB 6nEJSbopFQtNf9zqfrW+7TjHGzftxJs7t9ZkpM3iDL3MWp/sf9oNIL16v07mZoWLHln5 EOVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=dtTLucMk0AMxGfL/4ZFRdiwAqLv4RCXCFQ+aWKUZhAw=; b=MyO3flS/+auQguuc4GgZEIe6airrtPgOK3bgVWXAbMiNFYYlxxxJG0bess8da4UYEl iR7RBPCahaQ+CnxPurSftS7+IyBefRY5HgspNCB3VnqACC6TjJN9lqvn9p+I3rp/858U ZxAAwi6MfZ3dDa7zd2dX/XjXmnZmqJkOMMpTor/AieNjnlFVtJe8FMZWOK028NDNVMws XXvmjMSaqmbG2WMrjtzHyORusCx/1ZaOX69LdgOATaU4drBbFAI4/0dfvloq0X2uI5SJ JpKpA/lc29zbjVmsC3pBgTWv5tIBA+Gu+ZmhLHsR/YmihocYIv3Dr8Phl44CyEwI18nN PmBg== X-Gm-Message-State: AOAM530fd0eUpv+m+GmhekeKaFM4MRlsMznEeLU8maNX9XX3DIWi0GGQ U/OpvVG9C5pzpeIVm1RZlLimbLLbzzu5mLMPl7b4ZS2s X-Google-Smtp-Source: ABdhPJz9ENCLvRre44L+ATmDit6wN8/0tSAHqsuCI6UUvA6tWLVG/3s6uIN473l76tliMr4pY8O+UUxy+bVvx93ZaeY= X-Received: by 2002:a81:486:0:b0:2d7:7785:3f33 with SMTP id 128-20020a810486000000b002d777853f33mr6493844ywe.516.1646601936715; Sun, 06 Mar 2022 13:25:36 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a05:690c:12:0:0:0:0 with HTTP; Sun, 6 Mar 2022 13:25:36 -0800 (PST) In-Reply-To: References: <20210115045832.76405-1-borbarak@fb.com> <3fa8e9b2-6824-eb3a-2390-22fd024efa9f@mail.de> <164363001951.23111.4989616914372511566@lain.red.khirnov.net> <14fa7592-4acc-2186-335b-56ea500f9663@mail.de> From: Paul B Mahol Date: Sun, 6 Mar 2022 22:25:36 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avfilter: Added siti filter X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/6/22, Thilo Borgmann wrote: > Am 22.02.22 um 12:30 schrieb Thilo Borgmann: >> Am 18.02.22 um 17:08 schrieb Paul B Mahol: >>> On Sat, Feb 12, 2022 at 11:55 AM Thilo Borgmann >>> wrote: >>> >>>> Am 31.01.22 um 12:55 schrieb James Almer: >>>>> >>>>> >>>>> On 1/31/2022 8:53 AM, Anton Khirnov wrote: >>>>>> Quoting Thilo Borgmann (2022-01-18 14:58:07) >>>>>>>>> Violations of code style. >>>>>>> >>>>>>> Enhanced. >>>>>> >>>>>> Not enough. There are still many remaining, e.g. >>>>>> * opening brace of a function definition should be on its own line >>>>>> * the context should generally be the first argument >>>>>> * unsigned char* should be uint8_t* >>>>>> * mixed declarations and code (the compiler should warn about that) >>>>> >>>>> I think someone said that clang (or some versions) is apparently not >>>> warning about this, hence why so many of these end up being missed in >>>> reviews or even by the patch author. >>>> >>>> This and all of Anton's comments in v3. Also removed some more >>>> obviously >>>> useless doubles. >>>> >>> >>> Why it uses doubles in so many places? >>> Is there any real benefit in that, except extra slowdown? >> >> I guess because it's originating in some c&p Matlab code. >> I did %s#double#float#g for v4, loosing some precision we can ignore >> IMHO. >> >> >> >> v3: >> >> Total frames: 2 >> >> Spatial Information: >> Average: 165.451985 >> Max: 165.817542 >> Min: 165.086427 >> >> Temporal Information: >> Average: 1.007263 >> Max: 2.014525 >> Min: 0.000000 >> >> >> >> v4: >> >> Total frames: 2 >> >> Spatial Information: >> Average: 164.385895 >> Max: 164.742325 >> Min: 164.029480 >> >> Temporal Information: >> Average: 1.007241 >> Max: 2.014483 >> Min: 0.000000 >> > > Ping. Into wrong section of changelog added entry. Useless cast of allocation results. Does filter changes pixels? If not, add metadata flag to appropriate place. > > -Thilo > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".