From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9297B4086D for ; Thu, 3 Mar 2022 08:24:25 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B20CC68AFD0; Thu, 3 Mar 2022 10:24:22 +0200 (EET) Received: from mail-yw1-f177.google.com (mail-yw1-f177.google.com [209.85.128.177]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E608F68AEEA for ; Thu, 3 Mar 2022 10:24:15 +0200 (EET) Received: by mail-yw1-f177.google.com with SMTP id 00721157ae682-2dbd97f9bfcso46562187b3.9 for ; Thu, 03 Mar 2022 00:24:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=DMl8AuIUmkNirDkwAZHzyAOQsH1fiJ8SFCtibuSXTzs=; b=iVwIWF+EvLg3lTt8nQsgZRwSob2Xd5Q6mYzf2u93ivN/y8zLpxzGOa7Zt2df3o13Cu deq8S1druJpCcn4yUJQwk/mlb/uKK/fJbAL3F16A3BirWZpSTIQqI4Szp3ZamdMMvmtF n5tdE+YhHZU7VfUONEbXtIS8RQLXvCdJvzd+TPUZlReiXlnyoce+Z1RQtBfUvdmQkrQs 2iuyjlHPXlRbbGlBe7hEXKQFRcDWCaNm6fpKtaHljkUM6+v63PgBEnlEvvJ+cm9sopad XhIOQ2+1unSksqAedjLXAxyPrCKZVMDlM7i2Zj3XS40S19CQW9CFfVFgLYxHiFS55UvJ kuxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=DMl8AuIUmkNirDkwAZHzyAOQsH1fiJ8SFCtibuSXTzs=; b=4kqtBhjnV6m36pPOmQozp4RyRJNcfNHHiPwWnnhm01uAhRLN72fUOGASMnaiziFRpc DdAkRPdA2bTO3vUuAui9sx/K5Kt82M6Fepk5hqBgQ9MAHK0R4qrliOoRzexiWYXaYGAf x/Ias0gCWLBfIZj5ASYu9xlXzSynA+9J5EzmqjlO35tccSNqKQQNFdzu7jI5WTKCcocp r0Z7uJRlXBrxqIT3Usgo2LhKLXdiJ/GpPUVeFZ5B7a27xTd6LQIp/0FPReOIi4838pTX 5Vprkz1lSL3iLf4+d+jsdVz2rCZILzUkyy/vDuo3dc8fIxXlpJze4fBME/ig0mmrIN79 tuYA== X-Gm-Message-State: AOAM531+IBBe3JXJqG3vm/jARl2L2tlAKkig5sPXHEcC4rmWtPrgg65C Jke75LgwN1xN959bT7FdAL2ENeci78StELCkMWTXTpyhvMo= X-Google-Smtp-Source: ABdhPJz0HNdvqTxkzHh3rNi3XLz0sca4zS0F83rY9WnDUf1U1V7B13mfqi50/buxcNv/A56epC0O9Qtlz7upyWMOROU= X-Received: by 2002:a0d:eb53:0:b0:2db:da53:a6d0 with SMTP id u80-20020a0deb53000000b002dbda53a6d0mr12549275ywe.34.1646295854321; Thu, 03 Mar 2022 00:24:14 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a0d:d9cf:0:0:0:0:0 with HTTP; Thu, 3 Mar 2022 00:24:13 -0800 (PST) In-Reply-To: <20220302214727.GB2829255@pb2> References: <20220302113805.272888-1-onemda@gmail.com> <20220302130045.GZ2829255@pb2> <20220302214727.GB2829255@pb2> From: Paul B Mahol Date: Thu, 3 Mar 2022 09:24:13 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avcodec/mpegvideo_enc: remove direct=1 support X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/2/22, Michael Niedermayer wrote: > On Wed, Mar 02, 2022 at 08:11:18PM +0100, Paul B Mahol wrote: >> On 3/2/22, Michael Niedermayer wrote: >> > On Wed, Mar 02, 2022 at 12:38:05PM +0100, Paul B Mahol wrote: >> >> It seems it does not work properly. >> >> >> >> Signed-off-by: Paul B Mahol >> >> --- >> >> libavcodec/mpegvideo_enc.c | 23 +++-------------------- >> >> 1 file changed, 3 insertions(+), 20 deletions(-) >> > >> > if iam not mistaken, that requires the whole image to be copied >> > one extra time >> > i think before doing that it should be understood >> > where the problem is >> > and why that is the better solution to fixing it and not doing >> > that extra copy >> > >> > of course i may be missing something >> > >> >> Yea, If you manage to trigger that path, I'm all ears. > > thats a fair request > > i tried > --- a/libavcodec/mpegvideo_enc.c > +++ b/libavcodec/mpegvideo_enc.c > @@ -1065,6 +1065,7 @@ static int load_input_picture(MpegEncContext *s, const > AVFrame *pic_arg) > pic->reference = 3; > > if (direct) { > + av_log(0,0, "direct mode\n"); > if ((ret = av_frame_ref(pic->f, pic_arg)) < 0) > return ret; > } > > with > ./ffmpeg -i ~/videos/matrixbench_mpeg2.mpg -t 1 test.avi > > and that gives me: > direct mode > Last message repeated 23 times > > so it seems the code is used Same happens if filtering is used? > > [...] > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > Observe your enemies, for they first find out your faults. -- Antisthenes > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".