From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9D6F1477F8 for ; Fri, 22 Sep 2023 21:30:48 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0DDF168C95A; Sat, 23 Sep 2023 00:30:46 +0300 (EEST) Received: from mail-ua1-f42.google.com (mail-ua1-f42.google.com [209.85.222.42]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A9C3168C7E5 for ; Sat, 23 Sep 2023 00:30:39 +0300 (EEST) Received: by mail-ua1-f42.google.com with SMTP id a1e0cc1a2514c-7aafa630ea2so1096287241.3 for ; Fri, 22 Sep 2023 14:30:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695418238; x=1696023038; darn=ffmpeg.org; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=ywNw7EdfwW/q7xRFNXK1Ns0wZ3t94e3tenbVbdHSuWY=; b=CuYT8w/EymwHLLIlHg74n1YSmi0It+SkI6Mab+WRwdZhubfrijICzKITeKz74Y4hJP yohPxpcQB5VcsiHhVE57paNVCZmIZ9eCpuwNWIQyIWgv7cvcLqt9ikUu5+0hOSbDawQ7 l0AqFTmCmLOqxQfTcUaFcMiwMm3oLL85FoEkdkUrLcYEuy286KZwTrpR9M8VJf+MDwMT 8NArcwDnnBEd/rpXrBM35LF0A28x0fynZLM/9dTTXdPAB1/KHD52GRJxDpkUX5KTibyF OWqpp+Q8W1IfVnHi4ZcXhiRCz/EI/cahXh5Mq9ZGyo8rH84rKJzkx374g/HEmRPDB/a1 /GIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695418238; x=1696023038; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ywNw7EdfwW/q7xRFNXK1Ns0wZ3t94e3tenbVbdHSuWY=; b=uj3ZGfewpq+kv893fvP1sJW6y0yFJCBW6YrtQWkmq4AFt33LSmH3mBPfUzw0Qgu2Nk yO4LDPvKfA29OyooByNW4j0Ymf0eVvfZmrJj7OsUpip8IWs57z9IffmfBXlrxzuyNU5b 0iP2FsN5Ufns4yfVp9ZaaQYXBfZC5e8v5a+pJm1KPTwyFRYS1LfsMbhpaVDuqOJRTzMC AYg/veLlZ8xnzEbjjmfoKjtV1yl5aURUT2S+UJcABVYs2844f843lgN5KA0Jt46VXssF yFg086gvyPb8FmHcYV37FsaNFtI6ouSNQs0CwG0Vj4UTONpGbEsMyk7CaCvkPhr7UrvL psww== X-Gm-Message-State: AOJu0YxEcN3xrdNp+LQa+Qp41O2oKH1FYvUCEMNBiYo1QNGgiw39Dx1h MLdU/ofNMdPe0145qOy2h1xEFnlDUof7PVqO+GzddE8DrS8= X-Google-Smtp-Source: AGHT+IFhPLENCbcQmC7M3y1XjMUGilmYxz81dTyu4ufH7ddMHWCFW5qCseQS67khiSeTMoIVROQPknjdU1gsv7ddVTw= X-Received: by 2002:a67:f319:0:b0:451:64e:4645 with SMTP id p25-20020a67f319000000b00451064e4645mr838936vsf.12.1695418237971; Fri, 22 Sep 2023 14:30:37 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a59:9f50:0:b0:3eb:b4c:bd4f with HTTP; Fri, 22 Sep 2023 14:30:37 -0700 (PDT) In-Reply-To: <20230922212616.GH8640@pb2> References: <20230726235916.30058-1-michael@niedermayer.cc> <20230922192204.GC8640@pb2> <20230922212616.GH8640@pb2> From: Paul B Mahol Date: Fri, 22 Sep 2023 23:30:37 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 1/4] avcodec/rtv1: Check if the minimal size is available in decode_rtv1() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 9/22/23, Michael Niedermayer wrote: > On Fri, Sep 22, 2023 at 09:32:47PM +0200, Paul B Mahol wrote: >> On 9/22/23, Michael Niedermayer wrote: >> > On Thu, Jul 27, 2023 at 01:59:13AM +0200, Michael Niedermayer wrote: >> >> Signed-off-by: Michael Niedermayer >> >> --- >> >> libavcodec/rtv1.c | 6 +++++- >> >> 1 file changed, 5 insertions(+), 1 deletion(-) >> > >> > will apply 1-3 of this patchset >> >> Are you sure this does not break decoding? > > Well, its a loop over 4x4 blocks, a 16bit "skip" run so the minimum > check looks correct. > There are 2 end of bitstream checks for early exit but they look like > error handling not some normal exit as they leave the frame uninitialized > FFmpeg default initialization code for AVFrame's buffers does it twice, so they are always zeroed or previous values of previous buffers in pool. > Do you have some files so i can double check this is not breaking anything Search trac tickets. > ? > > thx > > [...] > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > Those who would give up essential Liberty, to purchase a little > temporary Safety, deserve neither Liberty nor Safety -- Benjamin Franklin > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".