From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8848043621 for ; Sat, 17 Sep 2022 14:45:38 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1C2BF68BB92; Sat, 17 Sep 2022 17:45:36 +0300 (EEST) Received: from mail-yb1-f171.google.com (mail-yb1-f171.google.com [209.85.219.171]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0B9CF68BB1D for ; Sat, 17 Sep 2022 17:45:30 +0300 (EEST) Received: by mail-yb1-f171.google.com with SMTP id c9so36565499ybf.5 for ; Sat, 17 Sep 2022 07:45:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :from:to:cc:subject:date; bh=h1bMXwRrGH4zwywOMDOFDusBdNvuPbbqlYYnURBfp5c=; b=karPmUT9gsVQOAR4Kv8uHY0MP+GH575U4qDaPuYY55MWFyFyALo61Z9z9C7GjeeS4t Mtut8D5wLdHfBQ8ig4ffpuJDo9pT8QJXKriMd2iTxQ4yikHSX8nDsTONn3EVOEnrczim nPe9peIUVUdrEzFcRG78sE1gD4TLNhpzo9BlgDjFwSaT+BftdxTNHMsiXuERU3wIAz6/ mDNQ8HB7ctDBzG+gZcN54DNoCRrEVK1KKruWktn9qzgv57uOZGMj449lQARzEtbl1pN5 OfgDebawj/HFx42hnKNUgn8PZzh+37sQG7xLKs3RgyUNnSx0BenBVIDeMUD16PTthZBY qOWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :x-gm-message-state:from:to:cc:subject:date; bh=h1bMXwRrGH4zwywOMDOFDusBdNvuPbbqlYYnURBfp5c=; b=zm15YU9HlTs4HOXBVFuInmj89QsA97sXg/vRco3Fn0RV1p370h7Zkoqn+cdJ8EvxMa 6mIOhNSwIR8TCnoUHO6gwsh6szy67szXf7ddIk11Dw2v7kvA5fBG4swySE9iUKPS40uw fwm2UuZifPED4Kt0CXWyzZXj8wwZn19o1vIvhTPh5J5b6aGYrhLJlmdl99Ys+RvNj2bX qyFglrReBLtAu7UOerESK8gUaPV6mOttDThLgzgLGPjJPGHaoNPGk4MOBKNKhRxTBgTd z+AIjwxwn+9wzXpUMSZD3LpgR2lfT/mHmBuEad+0MA5Rq5Lft16xbgxlPQLiRWhxqqjs Le+A== X-Gm-Message-State: ACrzQf2yQN1UgErN4QqzdFMT9AwI4tYYlRordsx/QwcR4LfWbmtEinaA Et26qgitc8aB+b4gTc6Ndugx7XKnm9eqqi7EYqfCFs/8 X-Google-Smtp-Source: AMsMyM4Xk8ljiea56kZrs8BD8LyGuFyM9joIUxzJH2oTg+d0cyQko7+mlhM3pgsnhA49sge75vEkYfeYmta3/tlFygs= X-Received: by 2002:a5b:485:0:b0:67c:2c89:f3a3 with SMTP id n5-20020a5b0485000000b0067c2c89f3a3mr8108725ybp.571.1663425928390; Sat, 17 Sep 2022 07:45:28 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a81:7402:0:0:0:0:0 with HTTP; Sat, 17 Sep 2022 07:45:28 -0700 (PDT) In-Reply-To: <20220917143209.7797-2-michael@niedermayer.cc> References: <20220917143209.7797-1-michael@niedermayer.cc> <20220917143209.7797-2-michael@niedermayer.cc> From: Paul B Mahol Date: Sat, 17 Sep 2022 16:45:28 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/aiffdec: Use 64bit for block_duration use X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 9/17/22, Michael Niedermayer wrote: > Fixes: signed integer overflow: 3 * -2147483648 cannot be represented in > type 'int' > Fixes: > 50993/clusterfuzz-testcase-minimized-ffmpeg_dem_AIFF_fuzzer-6668935979728896 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavformat/aiffdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/aiffdec.c b/libavformat/aiffdec.c > index 318e3ad742e..80733e58010 100644 > --- a/libavformat/aiffdec.c > +++ b/libavformat/aiffdec.c > @@ -428,7 +428,7 @@ static int aiff_read_packet(AVFormatContext *s, > pkt->flags &= ~AV_PKT_FLAG_CORRUPT; > /* Only one stream in an AIFF file */ > pkt->stream_index = 0; > - pkt->duration = (res / st->codecpar->block_align) * > aiff->block_duration; > + pkt->duration = (res / st->codecpar->block_align) * (int64_t) > aiff->block_duration; > return 0; > } LGTM > > -- > 2.17.1 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".