From: Paul B Mahol <onemda@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/aiffdec: Use 64bit for block_duration use
Date: Sat, 17 Sep 2022 16:45:28 +0200
Message-ID: <CAPYw7P7JqLo3OaSfyO+ExwBxxN7jkOFCMuWe+C5dQVy=3iTzVw@mail.gmail.com> (raw)
In-Reply-To: <20220917143209.7797-2-michael@niedermayer.cc>
On 9/17/22, Michael Niedermayer <michael@niedermayer.cc> wrote:
> Fixes: signed integer overflow: 3 * -2147483648 cannot be represented in
> type 'int'
> Fixes:
> 50993/clusterfuzz-testcase-minimized-ffmpeg_dem_AIFF_fuzzer-6668935979728896
>
> Found-by: continuous fuzzing process
> https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
> libavformat/aiffdec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/aiffdec.c b/libavformat/aiffdec.c
> index 318e3ad742e..80733e58010 100644
> --- a/libavformat/aiffdec.c
> +++ b/libavformat/aiffdec.c
> @@ -428,7 +428,7 @@ static int aiff_read_packet(AVFormatContext *s,
> pkt->flags &= ~AV_PKT_FLAG_CORRUPT;
> /* Only one stream in an AIFF file */
> pkt->stream_index = 0;
> - pkt->duration = (res / st->codecpar->block_align) *
> aiff->block_duration;
> + pkt->duration = (res / st->codecpar->block_align) * (int64_t)
> aiff->block_duration;
> return 0;
> }
LGTM
>
> --
> 2.17.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-09-17 14:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-17 14:32 [FFmpeg-devel] [PATCH 1/2] avformat/aiffdec: Check block_duration Michael Niedermayer
2022-09-17 14:32 ` [FFmpeg-devel] [PATCH 2/2] avformat/aiffdec: Use 64bit for block_duration use Michael Niedermayer
2022-09-17 14:45 ` Paul B Mahol [this message]
2022-09-22 15:10 ` Michael Niedermayer
2022-09-17 14:45 ` [FFmpeg-devel] [PATCH 1/2] avformat/aiffdec: Check block_duration Paul B Mahol
2022-09-22 15:10 ` Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPYw7P7JqLo3OaSfyO+ExwBxxN7jkOFCMuWe+C5dQVy=3iTzVw@mail.gmail.com' \
--to=onemda@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git