* [FFmpeg-devel] [PATCH] avformat/cafdec: Implement FLAC-in-CAF parsing
@ 2022-06-03 13:11 Martijn van Beurden
2022-06-03 13:18 ` Paul B Mahol
2022-06-03 17:10 ` Andreas Rheinhardt
0 siblings, 2 replies; 12+ messages in thread
From: Martijn van Beurden @ 2022-06-03 13:11 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Martijn van Beurden
The afconvert utility shipped with MacOS supports muxing of FLAC
in CAF, see afconvert help output on a recent Mac here:
https://hydrogenaud.io/index.php?topic=122509.0 A file created
with afconvert free of copyright (licensed CC0) can be found here:
http://www.audiograaf.nl/misc_stuff/afconvert-FLAC-in-CAF.caf
This patch implements parsing of such a file
---
libavformat/caf.c | 1 +
libavformat/cafdec.c | 41 +++++++++++++++++++++++++++++++++++++++++
2 files changed, 42 insertions(+)
diff --git a/libavformat/caf.c b/libavformat/caf.c
index a700e4055b..a61c39fae5 100644
--- a/libavformat/caf.c
+++ b/libavformat/caf.c
@@ -46,6 +46,7 @@ const AVCodecTag ff_codec_caf_tags[] = {
{ AV_CODEC_ID_GSM, MKTAG('a','g','s','m') },
{ AV_CODEC_ID_GSM_MS, MKTAG('m','s', 0, '1') },
{ AV_CODEC_ID_ILBC, MKTAG('i','l','b','c') },
+ { AV_CODEC_ID_FLAC, MKTAG('f','l','a','c') },
{ AV_CODEC_ID_MACE3, MKTAG('M','A','C','3') },
{ AV_CODEC_ID_MACE6, MKTAG('M','A','C','6') },
{ AV_CODEC_ID_MP1, MKTAG('.','m','p','1') },
diff --git a/libavformat/cafdec.c b/libavformat/cafdec.c
index 168f69f20b..72a74ab297 100644
--- a/libavformat/cafdec.c
+++ b/libavformat/cafdec.c
@@ -31,6 +31,7 @@
#include "demux.h"
#include "internal.h"
#include "isom.h"
+#include "libavcodec/flac.h"
#include "mov_chan.h"
#include "libavutil/intreadwrite.h"
#include "libavutil/intfloat.h"
@@ -170,6 +171,46 @@ static int read_kuki_chunk(AVFormatContext *s, int64_t size)
}
avio_skip(pb, size - ALAC_NEW_KUKI);
}
+ } else if (st->codecpar->codec_id == AV_CODEC_ID_FLAC) {
+ int last, type, flac_metadata_size;
+ uint8_t buf[4];
+ /* The magic cookie format for FLAC consists mostly of an mp4 dfLa atom. */
+ if (size < (16 + FLAC_STREAMINFO_SIZE)) {
+ av_log(s, AV_LOG_ERROR, "invalid FLAC magic cookie\n");
+ return AVERROR_INVALIDDATA;
+ }
+ /* Check cookie version. */
+ if (avio_r8(pb) != 0) {
+ av_log(s, AV_LOG_ERROR, "unknown FLAC magic cookie\n");
+ return AVERROR_INVALIDDATA;
+ }
+ avio_rb24(pb); /* Flags */
+ /* read dfLa fourcc */
+ if (avio_read(pb, buf, 4) != 4) {
+ av_log(s, AV_LOG_ERROR, "failed to read FLAC magic cookie\n");
+ return AVERROR_INVALIDDATA;
+ }
+ if (memcmp(buf,"dfLa",4)) {
+ av_log(s, AV_LOG_ERROR, "invalid FLAC magic cookie\n");
+ return AVERROR_INVALIDDATA;
+ }
+ /* Check dfLa version. */
+ if (avio_r8(pb) != 0) {
+ av_log(s, AV_LOG_ERROR, "unknown dfLa version\n");
+ return AVERROR_INVALIDDATA;
+ }
+ avio_rb24(pb); /* Flags */
+ avio_read(pb, buf, sizeof(buf));
+ flac_parse_block_header(buf, &last, &type, &flac_metadata_size);
+ if (type != FLAC_METADATA_TYPE_STREAMINFO || flac_metadata_size != FLAC_STREAMINFO_SIZE) {
+ av_log(s, AV_LOG_ERROR, "STREAMINFO must be first FLACMetadataBlock\n");
+ return AVERROR_INVALIDDATA;
+ }
+ ret = ff_get_extradata(s, st->codecpar, pb, FLAC_STREAMINFO_SIZE);
+ if (ret < 0)
+ return ret;
+ if (!last)
+ av_log(s, AV_LOG_WARNING, "non-STREAMINFO FLACMetadataBlock(s) ignored\n");
} else if (st->codecpar->codec_id == AV_CODEC_ID_OPUS) {
// The data layout for Opus is currently unknown, so we do not export
// extradata at all. Multichannel streams are not supported.
--
2.30.2
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [FFmpeg-devel] [PATCH] avformat/cafdec: Implement FLAC-in-CAF parsing
2022-06-03 13:11 [FFmpeg-devel] [PATCH] avformat/cafdec: Implement FLAC-in-CAF parsing Martijn van Beurden
@ 2022-06-03 13:18 ` Paul B Mahol
2022-06-03 17:10 ` Andreas Rheinhardt
1 sibling, 0 replies; 12+ messages in thread
From: Paul B Mahol @ 2022-06-03 13:18 UTC (permalink / raw)
To: FFmpeg development discussions and patches; +Cc: Martijn van Beurden
On Fri, Jun 3, 2022 at 3:12 PM Martijn van Beurden <mvanb1@gmail.com> wrote:
> The afconvert utility shipped with MacOS supports muxing of FLAC
> in CAF, see afconvert help output on a recent Mac here:
> https://hydrogenaud.io/index.php?topic=122509.0 A file created
> with afconvert free of copyright (licensed CC0) can be found here:
> http://www.audiograaf.nl/misc_stuff/afconvert-FLAC-in-CAF.caf
>
> This patch implements parsing of such a file
> ---
> libavformat/caf.c | 1 +
> libavformat/cafdec.c | 41 +++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 42 insertions(+)
>
> diff --git a/libavformat/caf.c b/libavformat/caf.c
> index a700e4055b..a61c39fae5 100644
> --- a/libavformat/caf.c
> +++ b/libavformat/caf.c
> @@ -46,6 +46,7 @@ const AVCodecTag ff_codec_caf_tags[] = {
> { AV_CODEC_ID_GSM, MKTAG('a','g','s','m') },
> { AV_CODEC_ID_GSM_MS, MKTAG('m','s', 0, '1') },
> { AV_CODEC_ID_ILBC, MKTAG('i','l','b','c') },
> + { AV_CODEC_ID_FLAC, MKTAG('f','l','a','c') },
> { AV_CODEC_ID_MACE3, MKTAG('M','A','C','3') },
> { AV_CODEC_ID_MACE6, MKTAG('M','A','C','6') },
> { AV_CODEC_ID_MP1, MKTAG('.','m','p','1') },
> diff --git a/libavformat/cafdec.c b/libavformat/cafdec.c
> index 168f69f20b..72a74ab297 100644
> --- a/libavformat/cafdec.c
> +++ b/libavformat/cafdec.c
> @@ -31,6 +31,7 @@
> #include "demux.h"
> #include "internal.h"
> #include "isom.h"
> +#include "libavcodec/flac.h"
> #include "mov_chan.h"
> #include "libavutil/intreadwrite.h"
> #include "libavutil/intfloat.h"
> @@ -170,6 +171,46 @@ static int read_kuki_chunk(AVFormatContext *s,
> int64_t size)
> }
> avio_skip(pb, size - ALAC_NEW_KUKI);
> }
> + } else if (st->codecpar->codec_id == AV_CODEC_ID_FLAC) {
> + int last, type, flac_metadata_size;
> + uint8_t buf[4];
> + /* The magic cookie format for FLAC consists mostly of an mp4
> dfLa atom. */
> + if (size < (16 + FLAC_STREAMINFO_SIZE)) {
> + av_log(s, AV_LOG_ERROR, "invalid FLAC magic cookie\n");
> + return AVERROR_INVALIDDATA;
> + }
> + /* Check cookie version. */
> + if (avio_r8(pb) != 0) {
> + av_log(s, AV_LOG_ERROR, "unknown FLAC magic cookie\n");
> + return AVERROR_INVALIDDATA;
> + }
> + avio_rb24(pb); /* Flags */
> + /* read dfLa fourcc */
> + if (avio_read(pb, buf, 4) != 4) {
> + av_log(s, AV_LOG_ERROR, "failed to read FLAC magic cookie\n");
> + return AVERROR_INVALIDDATA;
> + }
> + if (memcmp(buf,"dfLa",4)) {
> + av_log(s, AV_LOG_ERROR, "invalid FLAC magic cookie\n");
> + return AVERROR_INVALIDDATA;
> + }
> + /* Check dfLa version. */
> + if (avio_r8(pb) != 0) {
> + av_log(s, AV_LOG_ERROR, "unknown dfLa version\n");
> + return AVERROR_INVALIDDATA;
> + }
> + avio_rb24(pb); /* Flags */
> + avio_read(pb, buf, sizeof(buf));
> + flac_parse_block_header(buf, &last, &type, &flac_metadata_size);
> + if (type != FLAC_METADATA_TYPE_STREAMINFO || flac_metadata_size
> != FLAC_STREAMINFO_SIZE) {
> + av_log(s, AV_LOG_ERROR, "STREAMINFO must be first
> FLACMetadataBlock\n");
> + return AVERROR_INVALIDDATA;
> + }
> + ret = ff_get_extradata(s, st->codecpar, pb, FLAC_STREAMINFO_SIZE);
> + if (ret < 0)
> + return ret;
> + if (!last)
> + av_log(s, AV_LOG_WARNING, "non-STREAMINFO
> FLACMetadataBlock(s) ignored\n");
> } else if (st->codecpar->codec_id == AV_CODEC_ID_OPUS) {
> // The data layout for Opus is currently unknown, so we do not
> export
> // extradata at all. Multichannel streams are not supported.
> --
> 2.30.2
>
>
LGTM
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [FFmpeg-devel] [PATCH] avformat/cafdec: Implement FLAC-in-CAF parsing
2022-06-03 13:11 [FFmpeg-devel] [PATCH] avformat/cafdec: Implement FLAC-in-CAF parsing Martijn van Beurden
2022-06-03 13:18 ` Paul B Mahol
@ 2022-06-03 17:10 ` Andreas Rheinhardt
2022-06-03 18:45 ` Jan Ekström
2022-06-03 19:47 ` Martijn van Beurden
1 sibling, 2 replies; 12+ messages in thread
From: Andreas Rheinhardt @ 2022-06-03 17:10 UTC (permalink / raw)
To: ffmpeg-devel
Martijn van Beurden:
> The afconvert utility shipped with MacOS supports muxing of FLAC
> in CAF, see afconvert help output on a recent Mac here:
> https://hydrogenaud.io/index.php?topic=122509.0 A file created
> with afconvert free of copyright (licensed CC0) can be found here:
> http://www.audiograaf.nl/misc_stuff/afconvert-FLAC-in-CAF.caf
>
> This patch implements parsing of such a file
> ---
> libavformat/caf.c | 1 +
> libavformat/cafdec.c | 41 +++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 42 insertions(+)
>
> diff --git a/libavformat/caf.c b/libavformat/caf.c
> index a700e4055b..a61c39fae5 100644
> --- a/libavformat/caf.c
> +++ b/libavformat/caf.c
> @@ -46,6 +46,7 @@ const AVCodecTag ff_codec_caf_tags[] = {
> { AV_CODEC_ID_GSM, MKTAG('a','g','s','m') },
> { AV_CODEC_ID_GSM_MS, MKTAG('m','s', 0, '1') },
> { AV_CODEC_ID_ILBC, MKTAG('i','l','b','c') },
> + { AV_CODEC_ID_FLAC, MKTAG('f','l','a','c') },
> { AV_CODEC_ID_MACE3, MKTAG('M','A','C','3') },
> { AV_CODEC_ID_MACE6, MKTAG('M','A','C','6') },
> { AV_CODEC_ID_MP1, MKTAG('.','m','p','1') },
> diff --git a/libavformat/cafdec.c b/libavformat/cafdec.c
> index 168f69f20b..72a74ab297 100644
> --- a/libavformat/cafdec.c
> +++ b/libavformat/cafdec.c
> @@ -31,6 +31,7 @@
> #include "demux.h"
> #include "internal.h"
> #include "isom.h"
> +#include "libavcodec/flac.h"
> #include "mov_chan.h"
> #include "libavutil/intreadwrite.h"
> #include "libavutil/intfloat.h"
> @@ -170,6 +171,46 @@ static int read_kuki_chunk(AVFormatContext *s, int64_t size)
> }
> avio_skip(pb, size - ALAC_NEW_KUKI);
> }
> + } else if (st->codecpar->codec_id == AV_CODEC_ID_FLAC) {
> + int last, type, flac_metadata_size;
> + uint8_t buf[4];
> + /* The magic cookie format for FLAC consists mostly of an mp4 dfLa atom. */
> + if (size < (16 + FLAC_STREAMINFO_SIZE)) {
> + av_log(s, AV_LOG_ERROR, "invalid FLAC magic cookie\n");
> + return AVERROR_INVALIDDATA;
> + }
> + /* Check cookie version. */
> + if (avio_r8(pb) != 0) {
> + av_log(s, AV_LOG_ERROR, "unknown FLAC magic cookie\n");
> + return AVERROR_INVALIDDATA;
> + }
> + avio_rb24(pb); /* Flags */
> + /* read dfLa fourcc */
> + if (avio_read(pb, buf, 4) != 4) {
> + av_log(s, AV_LOG_ERROR, "failed to read FLAC magic cookie\n");
> + return AVERROR_INVALIDDATA;
> + }
> + if (memcmp(buf,"dfLa",4)) {
> + av_log(s, AV_LOG_ERROR, "invalid FLAC magic cookie\n");
> + return AVERROR_INVALIDDATA;
> + }
> + /* Check dfLa version. */
> + if (avio_r8(pb) != 0) {
> + av_log(s, AV_LOG_ERROR, "unknown dfLa version\n");
> + return AVERROR_INVALIDDATA;
> + }
> + avio_rb24(pb); /* Flags */
> + avio_read(pb, buf, sizeof(buf));
You are not checking this; this could lead to uninitialized values being
used in flac_parse_block_header() below.
> + flac_parse_block_header(buf, &last, &type, &flac_metadata_size);
> + if (type != FLAC_METADATA_TYPE_STREAMINFO || flac_metadata_size != FLAC_STREAMINFO_SIZE) {
> + av_log(s, AV_LOG_ERROR, "STREAMINFO must be first FLACMetadataBlock\n");
> + return AVERROR_INVALIDDATA;
> + }
> + ret = ff_get_extradata(s, st->codecpar, pb, FLAC_STREAMINFO_SIZE);
> + if (ret < 0)
> + return ret;
> + if (!last)
> + av_log(s, AV_LOG_WARNING, "non-STREAMINFO FLACMetadataBlock(s) ignored\n");
> } else if (st->codecpar->codec_id == AV_CODEC_ID_OPUS) {
> // The data layout for Opus is currently unknown, so we do not export
> // extradata at all. Multichannel streams are not supported.
Is there an official spec for this?
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [FFmpeg-devel] [PATCH] avformat/cafdec: Implement FLAC-in-CAF parsing
2022-06-03 17:10 ` Andreas Rheinhardt
@ 2022-06-03 18:45 ` Jan Ekström
2022-06-03 19:47 ` Martijn van Beurden
1 sibling, 0 replies; 12+ messages in thread
From: Jan Ekström @ 2022-06-03 18:45 UTC (permalink / raw)
To: FFmpeg development discussions and patches
On Fri, Jun 3, 2022 at 8:11 PM Andreas Rheinhardt
<andreas.rheinhardt@outlook.com> wrote:
>
> Martijn van Beurden:
> > The afconvert utility shipped with MacOS supports muxing of FLAC
> > in CAF, see afconvert help output on a recent Mac here:
> > https://hydrogenaud.io/index.php?topic=122509.0 A file created
> > with afconvert free of copyright (licensed CC0) can be found here:
> > http://www.audiograaf.nl/misc_stuff/afconvert-FLAC-in-CAF.caf
> >
> > This patch implements parsing of such a file
> > ---
> > libavformat/caf.c | 1 +
> > libavformat/cafdec.c | 41 +++++++++++++++++++++++++++++++++++++++++
> > 2 files changed, 42 insertions(+)
> >
> > diff --git a/libavformat/caf.c b/libavformat/caf.c
> > index a700e4055b..a61c39fae5 100644
> > --- a/libavformat/caf.c
> > +++ b/libavformat/caf.c
> > @@ -46,6 +46,7 @@ const AVCodecTag ff_codec_caf_tags[] = {
> > { AV_CODEC_ID_GSM, MKTAG('a','g','s','m') },
> > { AV_CODEC_ID_GSM_MS, MKTAG('m','s', 0, '1') },
> > { AV_CODEC_ID_ILBC, MKTAG('i','l','b','c') },
> > + { AV_CODEC_ID_FLAC, MKTAG('f','l','a','c') },
> > { AV_CODEC_ID_MACE3, MKTAG('M','A','C','3') },
> > { AV_CODEC_ID_MACE6, MKTAG('M','A','C','6') },
> > { AV_CODEC_ID_MP1, MKTAG('.','m','p','1') },
> > diff --git a/libavformat/cafdec.c b/libavformat/cafdec.c
> > index 168f69f20b..72a74ab297 100644
> > --- a/libavformat/cafdec.c
> > +++ b/libavformat/cafdec.c
> > @@ -31,6 +31,7 @@
> > #include "demux.h"
> > #include "internal.h"
> > #include "isom.h"
> > +#include "libavcodec/flac.h"
> > #include "mov_chan.h"
> > #include "libavutil/intreadwrite.h"
> > #include "libavutil/intfloat.h"
> > @@ -170,6 +171,46 @@ static int read_kuki_chunk(AVFormatContext *s, int64_t size)
> > }
> > avio_skip(pb, size - ALAC_NEW_KUKI);
> > }
> > + } else if (st->codecpar->codec_id == AV_CODEC_ID_FLAC) {
> > + int last, type, flac_metadata_size;
> > + uint8_t buf[4];
> > + /* The magic cookie format for FLAC consists mostly of an mp4 dfLa atom. */
> > + if (size < (16 + FLAC_STREAMINFO_SIZE)) {
> > + av_log(s, AV_LOG_ERROR, "invalid FLAC magic cookie\n");
> > + return AVERROR_INVALIDDATA;
> > + }
> > + /* Check cookie version. */
> > + if (avio_r8(pb) != 0) {
> > + av_log(s, AV_LOG_ERROR, "unknown FLAC magic cookie\n");
> > + return AVERROR_INVALIDDATA;
> > + }
> > + avio_rb24(pb); /* Flags */
> > + /* read dfLa fourcc */
> > + if (avio_read(pb, buf, 4) != 4) {
> > + av_log(s, AV_LOG_ERROR, "failed to read FLAC magic cookie\n");
> > + return AVERROR_INVALIDDATA;
> > + }
> > + if (memcmp(buf,"dfLa",4)) {
> > + av_log(s, AV_LOG_ERROR, "invalid FLAC magic cookie\n");
> > + return AVERROR_INVALIDDATA;
> > + }
> > + /* Check dfLa version. */
> > + if (avio_r8(pb) != 0) {
> > + av_log(s, AV_LOG_ERROR, "unknown dfLa version\n");
> > + return AVERROR_INVALIDDATA;
> > + }
> > + avio_rb24(pb); /* Flags */
> > + avio_read(pb, buf, sizeof(buf));
>
> You are not checking this; this could lead to uninitialized values being
> used in flac_parse_block_header() below.
>
> > + flac_parse_block_header(buf, &last, &type, &flac_metadata_size);
> > + if (type != FLAC_METADATA_TYPE_STREAMINFO || flac_metadata_size != FLAC_STREAMINFO_SIZE) {
> > + av_log(s, AV_LOG_ERROR, "STREAMINFO must be first FLACMetadataBlock\n");
> > + return AVERROR_INVALIDDATA;
> > + }
> > + ret = ff_get_extradata(s, st->codecpar, pb, FLAC_STREAMINFO_SIZE);
> > + if (ret < 0)
> > + return ret;
> > + if (!last)
> > + av_log(s, AV_LOG_WARNING, "non-STREAMINFO FLACMetadataBlock(s) ignored\n");
> > } else if (st->codecpar->codec_id == AV_CODEC_ID_OPUS) {
> > // The data layout for Opus is currently unknown, so we do not export
> > // extradata at all. Multichannel streams are not supported.
>
> Is there an official spec for this?
CAF mostly follows ISOBMFF in these things, so
https://github.com/xiph/flac/blob/master/doc/isoflac.txt is probably
the source of truth for dfLa FLACSpecificBox and such.
Base CAF specification is at
https://developer.apple.com/library/archive/documentation/MusicAudio/Reference/CAFSpec/CAF_spec/CAF_spec.html
, but it stops at AAC, and ignores both Opus and FLAC.
Jan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [FFmpeg-devel] [PATCH] avformat/cafdec: Implement FLAC-in-CAF parsing
2022-06-03 17:10 ` Andreas Rheinhardt
2022-06-03 18:45 ` Jan Ekström
@ 2022-06-03 19:47 ` Martijn van Beurden
2022-06-04 10:35 ` [FFmpeg-devel] [PATCH v2 1/2] " Martijn van Beurden
1 sibling, 1 reply; 12+ messages in thread
From: Martijn van Beurden @ 2022-06-03 19:47 UTC (permalink / raw)
To: FFmpeg development discussions and patches
Op vr 3 jun. 2022 om 19:11 schreef Andreas Rheinhardt
<andreas.rheinhardt@outlook.com>:
>
> You are not checking this; this could lead to uninitialized values being
> used in flac_parse_block_header() below.
>
Yes, indeed, thank you. Interestingly enough, I copied this bit
directly from mov_read_dfla in mov.c, so I'll send a patch for that as
well.
>
> Is there an official spec for this?
>
Not that I know of, but as I was looking at the file the with a hex
editor dfLa stood out as recognizable, as the MP4 spec uses it as well
(as Jan already commented). Therefore I copied most of the code from
mov_read_dfla, with some additions/changes as it is used in a
different context here of course.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 12+ messages in thread
* [FFmpeg-devel] [PATCH v2 1/2] avformat/cafdec: Implement FLAC-in-CAF parsing
2022-06-03 19:47 ` Martijn van Beurden
@ 2022-06-04 10:35 ` Martijn van Beurden
2022-06-04 10:35 ` [FFmpeg-devel] [PATCH v2 2/2] avformat/mov: prevent potential use of uninitialized value Martijn van Beurden
2022-06-07 9:05 ` [FFmpeg-devel] [PATCH v2 1/2] avformat/cafdec: Implement FLAC-in-CAF parsing Anton Khirnov
0 siblings, 2 replies; 12+ messages in thread
From: Martijn van Beurden @ 2022-06-04 10:35 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Martijn van Beurden
The afconvert utility shipped with MacOS supports muxing of FLAC
in CAF, see afconvert help output on a recent Mac here:
https://hydrogenaud.io/index.php?topic=122509.0 A file created
with afconvert free of copyright (licensed CC0) can be found here:
http://www.audiograaf.nl/misc_stuff/afconvert-FLAC-in-CAF.caf
This patch implements parsing of such a file
---
libavformat/caf.c | 1 +
libavformat/cafdec.c | 44 ++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 45 insertions(+)
diff --git a/libavformat/caf.c b/libavformat/caf.c
index a700e4055b..a61c39fae5 100644
--- a/libavformat/caf.c
+++ b/libavformat/caf.c
@@ -46,6 +46,7 @@ const AVCodecTag ff_codec_caf_tags[] = {
{ AV_CODEC_ID_GSM, MKTAG('a','g','s','m') },
{ AV_CODEC_ID_GSM_MS, MKTAG('m','s', 0, '1') },
{ AV_CODEC_ID_ILBC, MKTAG('i','l','b','c') },
+ { AV_CODEC_ID_FLAC, MKTAG('f','l','a','c') },
{ AV_CODEC_ID_MACE3, MKTAG('M','A','C','3') },
{ AV_CODEC_ID_MACE6, MKTAG('M','A','C','6') },
{ AV_CODEC_ID_MP1, MKTAG('.','m','p','1') },
diff --git a/libavformat/cafdec.c b/libavformat/cafdec.c
index 168f69f20b..a9e19df264 100644
--- a/libavformat/cafdec.c
+++ b/libavformat/cafdec.c
@@ -32,6 +32,7 @@
#include "internal.h"
#include "isom.h"
#include "mov_chan.h"
+#include "libavcodec/flac.h"
#include "libavutil/intreadwrite.h"
#include "libavutil/intfloat.h"
#include "libavutil/dict.h"
@@ -170,6 +171,49 @@ static int read_kuki_chunk(AVFormatContext *s, int64_t size)
}
avio_skip(pb, size - ALAC_NEW_KUKI);
}
+ } else if (st->codecpar->codec_id == AV_CODEC_ID_FLAC) {
+ int last, type, flac_metadata_size;
+ uint8_t buf[4];
+ /* The magic cookie format for FLAC consists mostly of an mp4 dfLa atom. */
+ if (size < (16 + FLAC_STREAMINFO_SIZE)) {
+ av_log(s, AV_LOG_ERROR, "invalid FLAC magic cookie\n");
+ return AVERROR_INVALIDDATA;
+ }
+ /* Check cookie version. */
+ if (avio_r8(pb) != 0) {
+ av_log(s, AV_LOG_ERROR, "unknown FLAC magic cookie\n");
+ return AVERROR_INVALIDDATA;
+ }
+ avio_rb24(pb); /* Flags */
+ /* read dfLa fourcc */
+ if (avio_read(pb, buf, 4) != 4) {
+ av_log(s, AV_LOG_ERROR, "failed to read FLAC magic cookie\n");
+ return AVERROR_INVALIDDATA;
+ }
+ if (memcmp(buf,"dfLa",4)) {
+ av_log(s, AV_LOG_ERROR, "invalid FLAC magic cookie\n");
+ return AVERROR_INVALIDDATA;
+ }
+ /* Check dfLa version. */
+ if (avio_r8(pb) != 0) {
+ av_log(s, AV_LOG_ERROR, "unknown dfLa version\n");
+ return AVERROR_INVALIDDATA;
+ }
+ avio_rb24(pb); /* Flags */
+ if (avio_read(pb, buf, sizeof(buf)) != sizeof(buf)) {
+ av_log(s, AV_LOG_ERROR, "failed to read FLAC metadata block header\n");
+ return AVERROR_INVALIDDATA;
+ }
+ flac_parse_block_header(buf, &last, &type, &flac_metadata_size);
+ if (type != FLAC_METADATA_TYPE_STREAMINFO || flac_metadata_size != FLAC_STREAMINFO_SIZE) {
+ av_log(s, AV_LOG_ERROR, "STREAMINFO must be first FLACMetadataBlock\n");
+ return AVERROR_INVALIDDATA;
+ }
+ ret = ff_get_extradata(s, st->codecpar, pb, FLAC_STREAMINFO_SIZE);
+ if (ret < 0)
+ return ret;
+ if (!last)
+ av_log(s, AV_LOG_WARNING, "non-STREAMINFO FLACMetadataBlock(s) ignored\n");
} else if (st->codecpar->codec_id == AV_CODEC_ID_OPUS) {
// The data layout for Opus is currently unknown, so we do not export
// extradata at all. Multichannel streams are not supported.
--
2.30.2
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 12+ messages in thread* [FFmpeg-devel] [PATCH v2 2/2] avformat/mov: prevent potential use of uninitialized value
2022-06-04 10:35 ` [FFmpeg-devel] [PATCH v2 1/2] " Martijn van Beurden
@ 2022-06-04 10:35 ` Martijn van Beurden
2022-06-11 7:32 ` [FFmpeg-devel] [PATCH v3 " Martijn van Beurden
2022-06-07 9:05 ` [FFmpeg-devel] [PATCH v2 1/2] avformat/cafdec: Implement FLAC-in-CAF parsing Anton Khirnov
1 sibling, 1 reply; 12+ messages in thread
From: Martijn van Beurden @ 2022-06-04 10:35 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Martijn van Beurden
---
libavformat/mov.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/libavformat/mov.c b/libavformat/mov.c
index d7be593a86..f3a63abaaa 100644
--- a/libavformat/mov.c
+++ b/libavformat/mov.c
@@ -6772,7 +6772,10 @@ static int mov_read_dfla(MOVContext *c, AVIOContext *pb, MOVAtom atom)
avio_rb24(pb); /* Flags */
- avio_read(pb, buf, sizeof(buf));
+ if (avio_read(pb, buf, sizeof(buf)) != sizeof(buf)) {
+ av_log(c->fc, AV_LOG_ERROR, "failed to read FLAC metadata block header\n");
+ return AVERROR_INVALIDDATA;
+ }
flac_parse_block_header(buf, &last, &type, &size);
if (type != FLAC_METADATA_TYPE_STREAMINFO || size != FLAC_STREAMINFO_SIZE) {
--
2.30.2
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 12+ messages in thread* [FFmpeg-devel] [PATCH v3 2/2] avformat/mov: prevent potential use of uninitialized value
2022-06-04 10:35 ` [FFmpeg-devel] [PATCH v2 2/2] avformat/mov: prevent potential use of uninitialized value Martijn van Beurden
@ 2022-06-11 7:32 ` Martijn van Beurden
2022-06-11 8:50 ` Paul B Mahol
0 siblings, 1 reply; 12+ messages in thread
From: Martijn van Beurden @ 2022-06-11 7:32 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Martijn van Beurden
---
libavformat/mov.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/libavformat/mov.c b/libavformat/mov.c
index d7be593a86..51c0f6f9d8 100644
--- a/libavformat/mov.c
+++ b/libavformat/mov.c
@@ -6772,7 +6772,10 @@ static int mov_read_dfla(MOVContext *c, AVIOContext *pb, MOVAtom atom)
avio_rb24(pb); /* Flags */
- avio_read(pb, buf, sizeof(buf));
+ if (avio_read(pb, buf, sizeof(buf)) != sizeof(buf)) {
+ av_log(c->fc, AV_LOG_ERROR, "failed to read FLAC metadata block header\n");
+ return (pb->error < 0 ? pb->error : AVERROR_INVALIDDATA);
+ }
flac_parse_block_header(buf, &last, &type, &size);
if (type != FLAC_METADATA_TYPE_STREAMINFO || size != FLAC_STREAMINFO_SIZE) {
--
2.30.2
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [FFmpeg-devel] [PATCH v2 1/2] avformat/cafdec: Implement FLAC-in-CAF parsing
2022-06-04 10:35 ` [FFmpeg-devel] [PATCH v2 1/2] " Martijn van Beurden
2022-06-04 10:35 ` [FFmpeg-devel] [PATCH v2 2/2] avformat/mov: prevent potential use of uninitialized value Martijn van Beurden
@ 2022-06-07 9:05 ` Anton Khirnov
2022-06-11 7:31 ` [FFmpeg-devel] [PATCH v3 " Martijn van Beurden
1 sibling, 1 reply; 12+ messages in thread
From: Anton Khirnov @ 2022-06-07 9:05 UTC (permalink / raw)
To: FFmpeg development discussions and patches; +Cc: Martijn van Beurden
Quoting Martijn van Beurden (2022-06-04 12:35:06)
> @@ -170,6 +171,49 @@ static int read_kuki_chunk(AVFormatContext *s, int64_t size)
> }
> avio_skip(pb, size - ALAC_NEW_KUKI);
> }
> + } else if (st->codecpar->codec_id == AV_CODEC_ID_FLAC) {
> + int last, type, flac_metadata_size;
> + uint8_t buf[4];
> + /* The magic cookie format for FLAC consists mostly of an mp4 dfLa atom. */
> + if (size < (16 + FLAC_STREAMINFO_SIZE)) {
> + av_log(s, AV_LOG_ERROR, "invalid FLAC magic cookie\n");
> + return AVERROR_INVALIDDATA;
> + }
> + /* Check cookie version. */
> + if (avio_r8(pb) != 0) {
> + av_log(s, AV_LOG_ERROR, "unknown FLAC magic cookie\n");
> + return AVERROR_INVALIDDATA;
> + }
> + avio_rb24(pb); /* Flags */
> + /* read dfLa fourcc */
> + if (avio_read(pb, buf, 4) != 4) {
> + av_log(s, AV_LOG_ERROR, "failed to read FLAC magic cookie\n");
> + return AVERROR_INVALIDDATA;
Should probably forward the IO error with something like
return (pb->error < 0 ? pb->error : AVERROR_INVALIDDATA);
same below and in the second patch
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 12+ messages in thread* [FFmpeg-devel] [PATCH v3 1/2] avformat/cafdec: Implement FLAC-in-CAF parsing
2022-06-07 9:05 ` [FFmpeg-devel] [PATCH v2 1/2] avformat/cafdec: Implement FLAC-in-CAF parsing Anton Khirnov
@ 2022-06-11 7:31 ` Martijn van Beurden
2022-07-05 11:42 ` Martijn van Beurden
0 siblings, 1 reply; 12+ messages in thread
From: Martijn van Beurden @ 2022-06-11 7:31 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Martijn van Beurden
The afconvert utility shipped with MacOS supports muxing of FLAC
in CAF, see afconvert help output on a recent Mac here:
https://hydrogenaud.io/index.php?topic=122509.0 A file created
with afconvert free of copyright (licensed CC0) can be found here:
http://www.audiograaf.nl/misc_stuff/afconvert-FLAC-in-CAF.caf
This patch implements parsing of such a file
---
libavformat/caf.c | 1 +
libavformat/cafdec.c | 44 ++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 45 insertions(+)
diff --git a/libavformat/caf.c b/libavformat/caf.c
index a700e4055b..a61c39fae5 100644
--- a/libavformat/caf.c
+++ b/libavformat/caf.c
@@ -46,6 +46,7 @@ const AVCodecTag ff_codec_caf_tags[] = {
{ AV_CODEC_ID_GSM, MKTAG('a','g','s','m') },
{ AV_CODEC_ID_GSM_MS, MKTAG('m','s', 0, '1') },
{ AV_CODEC_ID_ILBC, MKTAG('i','l','b','c') },
+ { AV_CODEC_ID_FLAC, MKTAG('f','l','a','c') },
{ AV_CODEC_ID_MACE3, MKTAG('M','A','C','3') },
{ AV_CODEC_ID_MACE6, MKTAG('M','A','C','6') },
{ AV_CODEC_ID_MP1, MKTAG('.','m','p','1') },
diff --git a/libavformat/cafdec.c b/libavformat/cafdec.c
index 168f69f20b..ced61643f8 100644
--- a/libavformat/cafdec.c
+++ b/libavformat/cafdec.c
@@ -32,6 +32,7 @@
#include "internal.h"
#include "isom.h"
#include "mov_chan.h"
+#include "libavcodec/flac.h"
#include "libavutil/intreadwrite.h"
#include "libavutil/intfloat.h"
#include "libavutil/dict.h"
@@ -170,6 +171,49 @@ static int read_kuki_chunk(AVFormatContext *s, int64_t size)
}
avio_skip(pb, size - ALAC_NEW_KUKI);
}
+ } else if (st->codecpar->codec_id == AV_CODEC_ID_FLAC) {
+ int last, type, flac_metadata_size;
+ uint8_t buf[4];
+ /* The magic cookie format for FLAC consists mostly of an mp4 dfLa atom. */
+ if (size < (16 + FLAC_STREAMINFO_SIZE)) {
+ av_log(s, AV_LOG_ERROR, "invalid FLAC magic cookie\n");
+ return AVERROR_INVALIDDATA;
+ }
+ /* Check cookie version. */
+ if (avio_r8(pb) != 0) {
+ av_log(s, AV_LOG_ERROR, "unknown FLAC magic cookie\n");
+ return AVERROR_INVALIDDATA;
+ }
+ avio_rb24(pb); /* Flags */
+ /* read dfLa fourcc */
+ if (avio_read(pb, buf, 4) != 4) {
+ av_log(s, AV_LOG_ERROR, "failed to read FLAC magic cookie\n");
+ return (pb->error < 0 ? pb->error : AVERROR_INVALIDDATA);
+ }
+ if (memcmp(buf,"dfLa",4)) {
+ av_log(s, AV_LOG_ERROR, "invalid FLAC magic cookie\n");
+ return AVERROR_INVALIDDATA;
+ }
+ /* Check dfLa version. */
+ if (avio_r8(pb) != 0) {
+ av_log(s, AV_LOG_ERROR, "unknown dfLa version\n");
+ return AVERROR_INVALIDDATA;
+ }
+ avio_rb24(pb); /* Flags */
+ if (avio_read(pb, buf, sizeof(buf)) != sizeof(buf)) {
+ av_log(s, AV_LOG_ERROR, "failed to read FLAC metadata block header\n");
+ return (pb->error < 0 ? pb->error : AVERROR_INVALIDDATA);
+ }
+ flac_parse_block_header(buf, &last, &type, &flac_metadata_size);
+ if (type != FLAC_METADATA_TYPE_STREAMINFO || flac_metadata_size != FLAC_STREAMINFO_SIZE) {
+ av_log(s, AV_LOG_ERROR, "STREAMINFO must be first FLACMetadataBlock\n");
+ return AVERROR_INVALIDDATA;
+ }
+ ret = ff_get_extradata(s, st->codecpar, pb, FLAC_STREAMINFO_SIZE);
+ if (ret < 0)
+ return ret;
+ if (!last)
+ av_log(s, AV_LOG_WARNING, "non-STREAMINFO FLACMetadataBlock(s) ignored\n");
} else if (st->codecpar->codec_id == AV_CODEC_ID_OPUS) {
// The data layout for Opus is currently unknown, so we do not export
// extradata at all. Multichannel streams are not supported.
--
2.30.2
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [FFmpeg-devel] [PATCH v3 1/2] avformat/cafdec: Implement FLAC-in-CAF parsing
2022-06-11 7:31 ` [FFmpeg-devel] [PATCH v3 " Martijn van Beurden
@ 2022-07-05 11:42 ` Martijn van Beurden
0 siblings, 0 replies; 12+ messages in thread
From: Martijn van Beurden @ 2022-07-05 11:42 UTC (permalink / raw)
To: FFmpeg development discussions and patches
Op za 11 jun. 2022 om 09:31 schreef Martijn van Beurden <mvanb1@gmail.com>:
> The afconvert utility shipped with MacOS supports muxing of FLAC
> in CAF, see afconvert help output on a recent Mac here:
> https://hydrogenaud.io/index.php?topic=122509.0 A file created
> with afconvert free of copyright (licensed CC0) can be found here:
> http://www.audiograaf.nl/misc_stuff/afconvert-FLAC-in-CAF.caf
>
> This patch implements parsing of such a file
> ---
> libavformat/caf.c | 1 +
> libavformat/cafdec.c | 44 ++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 45 insertions(+)
>
> diff --git a/libavformat/caf.c b/libavformat/caf.c
> index a700e4055b..a61c39fae5 100644
> --- a/libavformat/caf.c
> +++ b/libavformat/caf.c
> @@ -46,6 +46,7 @@ const AVCodecTag ff_codec_caf_tags[] = {
> { AV_CODEC_ID_GSM, MKTAG('a','g','s','m') },
> { AV_CODEC_ID_GSM_MS, MKTAG('m','s', 0, '1') },
> { AV_CODEC_ID_ILBC, MKTAG('i','l','b','c') },
> + { AV_CODEC_ID_FLAC, MKTAG('f','l','a','c') },
> { AV_CODEC_ID_MACE3, MKTAG('M','A','C','3') },
> { AV_CODEC_ID_MACE6, MKTAG('M','A','C','6') },
> { AV_CODEC_ID_MP1, MKTAG('.','m','p','1') },
> diff --git a/libavformat/cafdec.c b/libavformat/cafdec.c
> index 168f69f20b..ced61643f8 100644
> --- a/libavformat/cafdec.c
> +++ b/libavformat/cafdec.c
> @@ -32,6 +32,7 @@
> #include "internal.h"
> #include "isom.h"
> #include "mov_chan.h"
> +#include "libavcodec/flac.h"
> #include "libavutil/intreadwrite.h"
> #include "libavutil/intfloat.h"
> #include "libavutil/dict.h"
> @@ -170,6 +171,49 @@ static int read_kuki_chunk(AVFormatContext *s,
> int64_t size)
> }
> avio_skip(pb, size - ALAC_NEW_KUKI);
> }
> + } else if (st->codecpar->codec_id == AV_CODEC_ID_FLAC) {
> + int last, type, flac_metadata_size;
> + uint8_t buf[4];
> + /* The magic cookie format for FLAC consists mostly of an mp4
> dfLa atom. */
> + if (size < (16 + FLAC_STREAMINFO_SIZE)) {
> + av_log(s, AV_LOG_ERROR, "invalid FLAC magic cookie\n");
> + return AVERROR_INVALIDDATA;
> + }
> + /* Check cookie version. */
> + if (avio_r8(pb) != 0) {
> + av_log(s, AV_LOG_ERROR, "unknown FLAC magic cookie\n");
> + return AVERROR_INVALIDDATA;
> + }
> + avio_rb24(pb); /* Flags */
> + /* read dfLa fourcc */
> + if (avio_read(pb, buf, 4) != 4) {
> + av_log(s, AV_LOG_ERROR, "failed to read FLAC magic cookie\n");
> + return (pb->error < 0 ? pb->error : AVERROR_INVALIDDATA);
> + }
> + if (memcmp(buf,"dfLa",4)) {
> + av_log(s, AV_LOG_ERROR, "invalid FLAC magic cookie\n");
> + return AVERROR_INVALIDDATA;
> + }
> + /* Check dfLa version. */
> + if (avio_r8(pb) != 0) {
> + av_log(s, AV_LOG_ERROR, "unknown dfLa version\n");
> + return AVERROR_INVALIDDATA;
> + }
> + avio_rb24(pb); /* Flags */
> + if (avio_read(pb, buf, sizeof(buf)) != sizeof(buf)) {
> + av_log(s, AV_LOG_ERROR, "failed to read FLAC metadata block
> header\n");
> + return (pb->error < 0 ? pb->error : AVERROR_INVALIDDATA);
> + }
> + flac_parse_block_header(buf, &last, &type, &flac_metadata_size);
> + if (type != FLAC_METADATA_TYPE_STREAMINFO || flac_metadata_size
> != FLAC_STREAMINFO_SIZE) {
> + av_log(s, AV_LOG_ERROR, "STREAMINFO must be first
> FLACMetadataBlock\n");
> + return AVERROR_INVALIDDATA;
> + }
> + ret = ff_get_extradata(s, st->codecpar, pb, FLAC_STREAMINFO_SIZE);
> + if (ret < 0)
> + return ret;
> + if (!last)
> + av_log(s, AV_LOG_WARNING, "non-STREAMINFO
> FLACMetadataBlock(s) ignored\n");
> } else if (st->codecpar->codec_id == AV_CODEC_ID_OPUS) {
> // The data layout for Opus is currently unknown, so we do not
> export
> // extradata at all. Multichannel streams are not supported.
> --
> 2.30.2
>
>
I would like to bring this patch to the attention of the mailing list
again. It still applies against current git.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2022-07-05 11:42 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-03 13:11 [FFmpeg-devel] [PATCH] avformat/cafdec: Implement FLAC-in-CAF parsing Martijn van Beurden
2022-06-03 13:18 ` Paul B Mahol
2022-06-03 17:10 ` Andreas Rheinhardt
2022-06-03 18:45 ` Jan Ekström
2022-06-03 19:47 ` Martijn van Beurden
2022-06-04 10:35 ` [FFmpeg-devel] [PATCH v2 1/2] " Martijn van Beurden
2022-06-04 10:35 ` [FFmpeg-devel] [PATCH v2 2/2] avformat/mov: prevent potential use of uninitialized value Martijn van Beurden
2022-06-11 7:32 ` [FFmpeg-devel] [PATCH v3 " Martijn van Beurden
2022-06-11 8:50 ` Paul B Mahol
2022-06-07 9:05 ` [FFmpeg-devel] [PATCH v2 1/2] avformat/cafdec: Implement FLAC-in-CAF parsing Anton Khirnov
2022-06-11 7:31 ` [FFmpeg-devel] [PATCH v3 " Martijn van Beurden
2022-07-05 11:42 ` Martijn van Beurden
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git