From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AF0024092C for ; Thu, 3 Mar 2022 17:17:26 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BC82568B015; Thu, 3 Mar 2022 19:17:23 +0200 (EET) Received: from mail-yb1-f170.google.com (mail-yb1-f170.google.com [209.85.219.170]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CC13568A115 for ; Thu, 3 Mar 2022 19:17:17 +0200 (EET) Received: by mail-yb1-f170.google.com with SMTP id h126so11665629ybc.1 for ; Thu, 03 Mar 2022 09:17:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=I7xYuVzwPfzlfMN2hKUFJ5moCShbiB98iU8epx7IRDw=; b=Rbg6Z3JGD4Dl9txNjYd8W+XgqTU/CySJWi/80AqFX/duxlSTbwP1JED+3uKER+VuB3 7G6AvGMzt+J+8yaxkYruEaAfgmUvjYapY6ibHsJd7lTofXgrzXMUTXpkWDkZ+EcJtbIh ckRI0fiCjvsj9LIUYA05QavNtVDSE/m5orQ6fyXVRDB5f4rhJDDV87JIJbLGCQztkCAJ WC4M/Z/mMB95fipt2lAyW00NEuWQ1Z83GNfIbzMDA7wg4YxTlwLbDPLk8UiDcKPmGJzj Jy5vPMvfrE7A+YqAFtTeIM4t8F31GuVa0RqUXQUZQ+ksdyH7ZS6gVqLBbNlRtJDC414G 7VjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=I7xYuVzwPfzlfMN2hKUFJ5moCShbiB98iU8epx7IRDw=; b=avJpLtvQ9WXccZAZXYLs6/EHvG6dr/wqiOXjZrG96Z+kbmvWp3Osb3oL1F0pNA2IuK 2GVJg9Q9U0ryAqym/XsOPOvbbocZS2xKVl48g1znI1he76W4Cl3O0EbWB8YxVmS2NkVF h6iTnhczmRhXKMDhISg+l9EB60iiggK+pV0n2rkf8YR6MNYFaHkdbErXFCkZg93qHq3X hyVJrB8kaLIwGkkU1zfcJEbJYgnGcFvvT6zzn+5Xqi9ZxRWBM4AFOM44VrYcexZcLJ5W F7j8qxw5oPXO/3r8E0UtfK/kMCch14eqT1ahy+1oTyH0WgDs5UUidwzK5voY4YJD68wP D59w== X-Gm-Message-State: AOAM530us7Ehc0v+8gSMUZxFUAe6jP6xU7pCAMP1eyLPwnrO8dPj/JYu 9UBUbJEKDfbj6s5263pu/bcYVFMvNDoY+3Zb6AUz6GztVgc= X-Google-Smtp-Source: ABdhPJzWrQBpvQ+JvQq1BgiJB5lmf9dS+GDkayuaeD4/+jHfnGFr1oMZNvzPpknfII+bS0Gw/BQQkntJ6H6nccnePxA= X-Received: by 2002:a25:8d8f:0:b0:628:c2e3:18fd with SMTP id o15-20020a258d8f000000b00628c2e318fdmr3320838ybl.396.1646327836350; Thu, 03 Mar 2022 09:17:16 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a0d:d9cf:0:0:0:0:0 with HTTP; Thu, 3 Mar 2022 09:17:15 -0800 (PST) In-Reply-To: <20220303170548.2606-1-jamrial@gmail.com> References: <20220303170548.2606-1-jamrial@gmail.com> From: Paul B Mahol Date: Thu, 3 Mar 2022 18:17:15 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avfilter/framepool: remove superfluous pallete buffer allocation X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/3/22, James Almer wrote: > av_image_fill_plane_sizes() already sets sizes[1] to AVPALETTE_SIZE. > Should fix memory leaks. ok > > Signed-off-by: James Almer > --- > Sorry for not noticing this before. > > libavfilter/framepool.c | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/libavfilter/framepool.c b/libavfilter/framepool.c > index 96bfe46319..1990902666 100644 > --- a/libavfilter/framepool.c > +++ b/libavfilter/framepool.c > @@ -56,13 +56,9 @@ FFFramePool *ff_frame_pool_video_init(AVBufferRef* > (*alloc)(size_t size), > { > int i, ret; > FFFramePool *pool; > - const AVPixFmtDescriptor *desc = av_pix_fmt_desc_get(format); > ptrdiff_t linesizes[4]; > size_t sizes[4]; > > - if (!desc) > - return NULL; > - > pool = av_mallocz(sizeof(FFFramePool)); > if (!pool) > return NULL; > @@ -108,12 +104,6 @@ FFFramePool *ff_frame_pool_video_init(AVBufferRef* > (*alloc)(size_t size), > goto fail; > } > > - if (desc->flags & AV_PIX_FMT_FLAG_PAL) { > - pool->pools[1] = av_buffer_pool_init(AVPALETTE_SIZE, alloc); > - if (!pool->pools[1]) > - goto fail; > - } > - > return pool; > > fail: > -- > 2.35.1 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".