From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8F828421C4 for ; Thu, 24 Feb 2022 21:50:10 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E6ED368B37C; Thu, 24 Feb 2022 23:50:07 +0200 (EET) Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com [209.85.128.175]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7ECBA68A7A1; Thu, 24 Feb 2022 23:49:56 +0200 (EET) Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-2d62593ad9bso13260797b3.8; Thu, 24 Feb 2022 13:49:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=b08NFOiGTfrKeem1UehvMR6g1wLgzpQudxZ/dGrOWEE=; b=WzFggvzj1SJSLOEiCm4CcQW249Sy5yoS8YqMnBsEOEHIOR/NkPxkDjh7LMqIsqK7jq Ts3IA8ZPhdJ1LHuRQJvmpGNHdWvFFx+vXWazhoktlC/Tp8CVSFxzp+nRPJUA/cEqy2O4 LNiWYa0Z/GXCIgfBV8n5OhNq4o78pi/VJV1JIMYw1VSmgwJq6wCrW7/0BuL/5s0L4FGl CwSvyosXPha6K0BtWrQhlf6y97Kplh0B5NHZfqUuEo1vadBMMylwPnjCsjC9sFYNRB8Z QoP/bHgwr46yIT/pn/37P6vBuZCj8hEI/Fykp3RfPpir6wNHKqEzl5KcSD1Dqjs8HSvF OffA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=b08NFOiGTfrKeem1UehvMR6g1wLgzpQudxZ/dGrOWEE=; b=zvLwMoqz2Uu1IRUQm2SLvz9z79ozAxMVOngeGFN7xHcbzJ/7koZI7sJd3TYeQdnrNt GAdXOK0L4I5G69/B/Dco3k4gX5+IyIUuJ4uMScMTHOa/MPkt4DnWVwhj9deV5Qx7eoIJ 1o+ilureox+wiMjJTe0aTwSSwUhbRCSpvH76I0yaIrurzCCeUkJe/9AjOIu/gAL2xWWH erCn7sL/fHMAldssWSsbJrDu+MUdQzJgHEjBoGCVJUoS6O/GUz2hFNhRgyhd5U0C6oMo H9nhjJuxHk2HcAj2v+7WnkvVNw6UJqs7XMQaTLKvxUa0M10Cy9UR3qnv26DkyRebJY0V l+NQ== X-Gm-Message-State: AOAM531Mc7t8wThwOy5D4pRmFKXimB/4Bahp8lLz4qGSqwIwQsCe7o/n NHC/QuVmtff6muM4yBBU8kBHNZqIcWVesiCyup4IOjKB9+w= X-Google-Smtp-Source: ABdhPJwKS8fa0DGHwewdHjPMbj6Jao+FahJWgqbNRSsVDFlBqQ8iYWa6SsoA7/Te9kCHQ0R9gCukpTJoYpRiimGhVLk= X-Received: by 2002:a81:1504:0:b0:2d7:2439:8e98 with SMTP id 4-20020a811504000000b002d724398e98mr4561624ywv.40.1645739395270; Thu, 24 Feb 2022 13:49:55 -0800 (PST) MIME-Version: 1.0 References: <20220224203039.CD4BB41059B@natalya.videolan.org> In-Reply-To: From: Paul B Mahol Date: Thu, 24 Feb 2022 22:51:15 +0100 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/vf_tpad: if there is no frame to clone return early X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: FFmpeg git commit log and discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, Feb 24, 2022 at 10:36 PM Thierry Foucu wrote: > On Thu, Feb 24, 2022 at 1:28 PM Paul B Mahol wrote: > > > On Thu, Feb 24, 2022 at 10:12 PM Thierry Foucu wrote: > > > > > On Thu, Feb 24, 2022 at 12:30 PM Paul B Mahol > wrote: > > > > > > > ffmpeg | branch: master | Paul B Mahol | Thu Feb > 24 > > > > 20:32:41 2022 +0100| [3715f2f8643695940582ce040b7a052cccfb9db2] | > > > > committer: Paul B Mahol > > > > > > > > avfilter/vf_tpad: if there is no frame to clone return early > > > > > > > > > > > > > > > > > > > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=3715f2f8643695940582ce040b7a052cccfb9db2 > > > > --- > > > > > > > > libavfilter/vf_tpad.c | 5 +++++ > > > > 1 file changed, 5 insertions(+) > > > > > > > > diff --git a/libavfilter/vf_tpad.c b/libavfilter/vf_tpad.c > > > > index e5acece1e4..120dbcb4d3 100644 > > > > --- a/libavfilter/vf_tpad.c > > > > +++ b/libavfilter/vf_tpad.c > > > > @@ -148,6 +148,11 @@ static int activate(AVFilterContext *ctx) > > > > frame->data, frame->linesize, > > > > 0, 0, frame->width, frame->height); > > > > } else if (s->stop_mode == 1) { > > > > + if (!s->cache_stop) { > > > > + s->pad_stop = 0; > > > > + ff_outlink_set_status(outlink, AVERROR_EOF, s->pts); > > > > + return 0; > > > > + } > > > > frame = av_frame_clone(s->cache_stop); > > > > if (!frame) > > > > return AVERROR(ENOMEM); > > > > > > > > > > > The problem with this solution is that the tpad will then not do what > we > > > are expecting, which is padding video track, and the output file will > not > > > have the desired duration. > > > Will it not be better to just output black frame (aka stop_mode == 0) , > > > something like that? > > > > > > > I doubt that, clone is clone, there is no point in padding stream that > have > > no frames at all. > > > > > > > The sample I forwarded to JB has video frames. The problem was that there > was a re-init of the filter chain after a resolution change and after the > re-init, there were no frames but got frames before the re-init. > I will understand for a media file which has NEVER received a video frame > and in this case, this is the correct solution. > Hmm, so you encode output with resolution change, why not use scale filter as first filter and then no resolution ever change for rest of graph? Adding support for resolution changes to all filters is very time consuming task and I see no real benefit in doing that now. > > > > > > > > iff --git a/libavfilter/vf_tpad.c b/libavfilter/vf_tpad.c > > > index e5acece1e4..5e4062e9f2 100644 > > > --- a/libavfilter/vf_tpad.c > > > +++ b/libavfilter/vf_tpad.c > > > @@ -140,7 +140,7 @@ static int activate(AVFilterContext *ctx) > > > ff_outlink_set_status(outlink, AVERROR_EOF, s->pts); > > > return 0; > > > } > > > - if (s->stop_mode == 0) { > > > + if (s->stop_mode == 0 || !s->cache_stop) { > > > frame = ff_get_video_buffer(outlink, outlink->w, > > outlink->h); > > > if (!frame) > > > return AVERROR(ENOMEM); > > > > > > > > > > > > > > > > _______________________________________________ > > > > ffmpeg-cvslog mailing list > > > > ffmpeg-cvslog@ffmpeg.org > > > > https://ffmpeg.org/mailman/listinfo/ffmpeg-cvslog > > > > > > > > To unsubscribe, visit link above, or email > > > > ffmpeg-cvslog-request@ffmpeg.org with subject "unsubscribe". > > > > > > > > > > > > > -- > > > > > > Thierry Foucu > > > _______________________________________________ > > > ffmpeg-devel mailing list > > > ffmpeg-devel@ffmpeg.org > > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > > > To unsubscribe, visit link above, or email > > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > > > > > _______________________________________________ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > To unsubscribe, visit link above, or email > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > > > > > -- > > Thierry Foucu > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".