From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id EE448420DD for ; Sat, 15 Jan 2022 08:27:13 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 86B6A68B42B; Sat, 15 Jan 2022 10:27:11 +0200 (EET) Received: from mail-yb1-f180.google.com (mail-yb1-f180.google.com [209.85.219.180]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 340FC68B23A for ; Sat, 15 Jan 2022 10:27:05 +0200 (EET) Received: by mail-yb1-f180.google.com with SMTP id h14so30316015ybe.12 for ; Sat, 15 Jan 2022 00:27:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=ByCzzJJsfC6jWxERbBCU6MiVrbWkAmUs+SV/s5cThIE=; b=ZIZP3ykhXMNTipozKG+tbQS88K2qhqfp19pdcUmQWjHZKovtkz2ZrUZKgfk6IpBkjg /7XrKym6zM7BJ04bjoGqmAara8BAC2oqoBnmtE6wcR2tIQc8aPbsAd6oEdx4eUHIAQSP mULT1+YN1OMbMxrzicqKN23rlO4Z2JQE3QLoxpSv0bc2Sxvp+GwpD9a+biLsNr9pSj62 LFJjTwVxC7xirxJXnW8+Z2rwBkm6NJ8C4UAnv8ywWGds/OCve5Jle8dqA7ezNLYr+v1c rgf1FG7w2+7w+IqFvep8EixdVliDaw34rn496qDOrreqgtjnlWKmhMk3w8094BF6MCip aaYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=ByCzzJJsfC6jWxERbBCU6MiVrbWkAmUs+SV/s5cThIE=; b=A2fot9LNFqhlXLmPm1w5icTfLjTSYLEhLqsx25tUqm+I3CmJIpYjRxKLwQNPqdBqg8 YXa/ug10Jl8NT1qGkK9d0YLWr2BHBSxubd+i/t6J+NlJspPcc9yT0eDQmoSJ8NtbIEFu Di7ogUAmnR5nBF0BUzTN7po0yXM/4Hiu6BgbiIqSsb7Qwt6ZjnDM8QGjTf6jlTvRxrey 52uHN9Tl/N2V2LLsHbj6UcIjThn6zRZU6SCdcdijq8Z3ClPCHAmWZ6X1bjP+mSpFxxpW xpeYffJeCKQSXK8/H/Zdaf04BATcqSL2xZCf2s78yw/kaTU0ECfX4C2kCske7Ldg2MtT rIvQ== X-Gm-Message-State: AOAM532A5CpjovrVk6YHS3Vcmcmk+dW4/CQlI5yih/Jw6kUUWThUiSfN QqfLjSOdneiSXz0v/49TamKgDuqjTDtPO9rlkywVA8RB X-Google-Smtp-Source: ABdhPJzgWs4rcTwKiFYIwkKWt3hECRXjgfLTh15xpCKQSy8L8rcjWhkpppiv/+cfAjTkWVxeGdRP+2OQS+bjSmvREAE= X-Received: by 2002:a05:6902:84:: with SMTP id h4mr18174241ybs.722.1642235223916; Sat, 15 Jan 2022 00:27:03 -0800 (PST) MIME-Version: 1.0 References: <20210115045832.76405-1-borbarak@fb.com> <3fa8e9b2-6824-eb3a-2390-22fd024efa9f@mail.de> In-Reply-To: From: Paul B Mahol Date: Sat, 15 Jan 2022 09:27:19 +0100 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] avfilter: Added siti filter X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sat, Jan 15, 2022 at 9:25 AM Paul B Mahol wrote: > > > On Fri, Jan 14, 2022 at 5:22 PM Thilo Borgmann > wrote: > >> Hi, >> >> Am 19.01.21 um 05:49 schrieb Lynne: >> > Jan 19, 2021, 01:07 by borbarak@fb.com: >> > >> >> Calculate Spatial Info (SI) and Temporal Info (TI) scores for a video, >> as defined >> >> in ITU-T P.910: Subjective video quality assessment methods for >> multimedia >> >> applications. >> >> >> >> Update: Fixed bracket style. >> >> >> > >> > Thanks, looks much neater now. >> > >> > >> > >> >> I'm already adding the data to the frame's metadata, is the suggestion >> to remove the file option altogether? >> >> >> > >> > Yes. We want to avoid filters having their own file in/out options >> rather >> > than using generic ones. >> >> Updated the patch to apply to git HEAD. >> Removed file output. >> Made printing summary to console optional. >> >> >> >> + >> >> +#include "libavutil/imgutils.h" >> >> +#include "libavutil/internal.h" >> >> +#include "libavutil/opt.h" >> >> + >> >> +#include "avfilter.h" >> >> +#include "formats.h" >> >> +#include "internal.h" >> >> +#include "video.h" >> >> + >> >> +static const int X_FILTER[9] = { >> >> + 1, 0, -1, >> >> + 2, 0, -2, >> >> + 1, 0, -1 >> >> +}; >> >> + >> >> +static const int Y_FILTER[9] = { >> >> + 1, 2, 1, >> >> + 0, 0, 0, >> >> + -1, -2, -1 >> >> +}; >> >> >> > >> > We have optimized assembly to apply 3x3 matrices. Check out >> > libavfilter/x86/vf_convolution.asm:ff_filter_3x3_sse4 >> > vf_convolution already applies a sobel filter that way. Maybe >> > look into sharing some DSP code with it? >> >> I checked a bit since I also want a common sobel for vf_edgedetect / my >> patch for vf_blurriness. >> >> For sobel, there is no direct asm implementation. We have a generic >> filter_3x3 with sse4 optimization. To use sobel with that, you'd need to >> run two times filter_3x3 plus one pass for gradient calculation. >> >> As another difference, this filter (SITI) does on-the-fly conversion to >> full-range pixel values during its sobel. While vf_edgedetect / >> vf_bluriness use an abbreviation for the gradients during its sobel. Which >> makes them both distinct enough not to fit into a general filter_3x3 or >> filter_sobel from vf_convolution easily (and more overhead). So I think >> it's not worth the effort to force them into a common function? (Especially >> since we don't have a sobel_sse4 or something) >> >> Patch without a common sobel attached. >> >> > > Violations of code style. > > Also why filter description only shows SI part and TI part is missing? > >> -Thilo >> >> >> _______________________________________________ >> ffmpeg-devel mailing list >> ffmpeg-devel@ffmpeg.org >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> >> To unsubscribe, visit link above, or email >> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". >> > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".