From: Paul B Mahol <onemda@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] Waveform Archiver decoder and demuxer
Date: Wed, 1 Feb 2023 11:53:41 +0100
Message-ID: <CAPYw7P7Ahu5AK5-2-ti1+_C2TTg51S-ERkbTZ=Y1W_mPcYe5qQ@mail.gmail.com> (raw)
In-Reply-To: <19063381e31bdd280ebc3899951ea5b3cabfa3bb.camel@haerdin.se>
On 2/1/23, Tomas Härdin <git@haerdin.se> wrote:
>> + if (avctx->extradata_size < 44)
>> + return AVERROR_INVALIDDATA;
>> + if (AV_RL32(avctx->extradata + 16) != MKTAG('R','I','F','F'))
>> + return AVERROR_INVALIDDATA;
>> + if (AV_RL32(avctx->extradata + 24) != MKTAG('W','A','V','E'))
>> + return AVERROR_INVALIDDATA;
>> + if (AV_RL32(avctx->extradata + 28) != MKTAG('f','m','t',' '))
>> + return AVERROR_INVALIDDATA;
>> + if (AV_RL16(avctx->extradata + 38) != 1 &&
>> + AV_RL16(avctx->extradata + 38) != 2)
>> + return AVERROR_INVALIDDATA;
>
> What in tarnation
>
>> + av_channel_layout_default(&avctx->ch_layout, AV_RL16(avctx-
>> >extradata + 38));
>> + avctx->sample_rate = AV_RL32(avctx->extradata + 40);
>>
>
> This belongs in the demuxer. In fact it appears the decoder duplicates
Decoder needs extradata as relevant information is not provided in
bitstream of packets.
> code from the demuxer. Why? Some samples would help.
Anybody is free to create samples.
>
> /Tomas
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-02-01 10:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-29 12:00 Paul B Mahol
2023-01-31 17:11 ` Paul B Mahol
2023-01-31 20:06 ` Anton Khirnov
2023-02-01 9:36 ` Tomas Härdin
2023-02-01 9:42 ` Nicolas George
2023-02-02 16:59 ` Tomas Härdin
2023-02-01 10:53 ` Paul B Mahol [this message]
2023-02-01 13:54 ` Andreas Rheinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPYw7P7Ahu5AK5-2-ti1+_C2TTg51S-ERkbTZ=Y1W_mPcYe5qQ@mail.gmail.com' \
--to=onemda@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git