From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 92A0240897 for ; Thu, 3 Mar 2022 13:56:15 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3869E68AFE1; Thu, 3 Mar 2022 15:56:12 +0200 (EET) Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com [209.85.128.171]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4518068AF5C for ; Thu, 3 Mar 2022 15:56:06 +0200 (EET) Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-2dbd8777564so56711827b3.0 for ; Thu, 03 Mar 2022 05:56:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=7MoSLSC6+3ZPmr2Lz4YAy8tqM9RIq82QjGncIE/Xg/Q=; b=Pj1p9HTgxGqP0SSgf1PG8l6SVamo80NgENmZhkfrTt4QKk6xXWbHgh0Ez16BOiAaHe sLQS0LBc3OMIGLIOn78iGOTZ1249iuJIK7hUFukRBmFggbDEW/hPiGXpIIPMtOHtUgc9 LdpqCxblIahBRchvGVwlVNNajuVlVB/WBhpLI8nHJx81gaxCJAck2krnzfU/99buwWQe Ga0Er85ekjD7PfVdLjUw0u/w5Hlm06LwhOWMjySMCnEG5LJZ8LTLGghkmNWN31gmRGXV AKoQamELGxxrsTc93+XBJW3crzrgs/fBNNxO4yMxNx0z37iySGPMIaP+q9r8NP9OXOLI VnRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=7MoSLSC6+3ZPmr2Lz4YAy8tqM9RIq82QjGncIE/Xg/Q=; b=ihi+B1z9IL4tFmmov7aPvBN818xgvD+l6vbgmJzXwFq6LwMNmGQ5h/9JIIlfQTUJmy gHkc0IMNL/4KreRR/rHJy2Aa8OjqxS73H1r6Xa1hz/UHrhYOHxzBSdHOBM1ko6ptNcGT 8ktVE5DWca4Haql8QZU8uW6R27tRJqTeX181FklN18GrpvOymQeRCg0QF1krZt4J1mWm K6gGqFwiUkLAiH4ej6IYPxcSuwG5xnOyRKuXYrCTozRm1V9HRHwmFddbd4rljkr6wspR 81D/bsRw/ZLGmomR0YgciuHYS03Evz3ivGkSck3/2yyiGzJxwbIomHgMAVEBuJ5X/Ho6 1hmQ== X-Gm-Message-State: AOAM533pvIJlLYVfKXBJiy1FSoSy/p/oxNPoyiHLS/APt2zHtcUMvh1B lkSPLj3zTpqumiSNyM6Om8zxMRwAFBHGQcMCzCkSyaoLadA= X-Google-Smtp-Source: ABdhPJwCm4Zuia7gMZ53bm2BdO8YaxcNmY1n0WwDH5KHmS/HDPIHYEYJhprROrGwXOiwuX6zY2i7b5YbsCT0E7K7RwQ= X-Received: by 2002:a0d:eb53:0:b0:2db:da53:a6d0 with SMTP id u80-20020a0deb53000000b002dbda53a6d0mr13681566ywe.34.1646315764013; Thu, 03 Mar 2022 05:56:04 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a0d:d9cf:0:0:0:0:0 with HTTP; Thu, 3 Mar 2022 05:56:03 -0800 (PST) In-Reply-To: <1e6e3de9-b08f-6613-ae14-77914b8b8e39@gmail.com> References: <20220301142310.16367-1-jamrial@gmail.com> <1e6e3de9-b08f-6613-ae14-77914b8b8e39@gmail.com> From: Paul B Mahol Date: Thu, 3 Mar 2022 14:56:03 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avfilter/framepool: use av_image_fill_plane_sizes() to calculate pool sizes X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/3/22, James Almer wrote: > > > On 3/1/2022 11:23 AM, James Almer wrote: >> Signed-off-by: James Almer >> --- >> libavfilter/framepool.c | 20 ++++++++++++++------ >> 1 file changed, 14 insertions(+), 6 deletions(-) >> >> diff --git a/libavfilter/framepool.c b/libavfilter/framepool.c >> index 5b510c9af9..cf6a1d0ea0 100644 >> --- a/libavfilter/framepool.c >> +++ b/libavfilter/framepool.c >> @@ -57,6 +57,8 @@ FFFramePool *ff_frame_pool_video_init(AVBufferRef* >> (*alloc)(size_t size), >> int i, ret; >> FFFramePool *pool; >> const AVPixFmtDescriptor *desc = av_pix_fmt_desc_get(format); >> + ptrdiff_t linesizes[4]; >> + size_t sizes[4]; >> >> if (!desc) >> return NULL; >> @@ -89,13 +91,19 @@ FFFramePool *ff_frame_pool_video_init(AVBufferRef* >> (*alloc)(size_t size), >> } >> } >> >> - for (i = 0; i < 4 && pool->linesize[i]; i++) { >> - int h = pool->height; >> - if (i == 1 || i == 2) >> - h = AV_CEIL_RSHIFT(h, desc->log2_chroma_h); >> + for (i = 0; i < 4; i++) >> + linesizes[i] = pool->linesize[i]; >> >> - pool->pools[i] = av_buffer_pool_init(pool->linesize[i] * h + >> align, >> - alloc); >> + if (av_image_fill_plane_sizes(sizes, pool->format, >> + FFALIGN(pool->height, align), >> + linesizes) < 0) { >> + goto fail; >> + } >> + >> + for (i = 0; i < 4 && sizes[i]; i++) { >> + if (sizes[i] > SIZE_MAX - align) >> + goto fail; >> + pool->pools[i] = av_buffer_pool_init(sizes[i] + align, alloc); >> if (!pool->pools[i]) >> goto fail; >> } > > Ping. I can also remove the height padding if preferred. It does not work. No? > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".