From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3BA5F44DBC for ; Mon, 26 Dec 2022 20:14:13 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 282FC68BAB3; Mon, 26 Dec 2022 22:14:10 +0200 (EET) Received: from mail-vk1-f182.google.com (mail-vk1-f182.google.com [209.85.221.182]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 45C6868B1A0 for ; Mon, 26 Dec 2022 22:14:03 +0200 (EET) Received: by mail-vk1-f182.google.com with SMTP id z190so1080956vka.4 for ; Mon, 26 Dec 2022 12:14:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=taZV27wSDVNvhZ5mUiS2fJIDtXrqZ59JBRzzw+Mxfww=; b=IbFcPrV41i5oPP8mQzCiQ6c9wubkF9sXNeV2+HAKUuYxHZGHc4j+TAlqtqYZv+hRwM 9D9TAxYL64LqCs/yYHh+9twMj03oyyBrsafdRpMwyRoHEkFziSiwPhugYbjLcgWdFGgm wQD/jNjebk/k1KfH1XlG4IznsJPzx1rB80XXLvl6e0f7LkaiDdSIcCdHqQdjU55lKT/Z 41eg9IK7MI+pA1BkMSsHF2fPNYb1wQjIFUE/DYTdcRMlDK/l3I9OjYSg55K4pczQWIe0 f1cFeP/qgY5lB6EfjG6hVb4+TvbvW6nDGGs3XK4KaJGGe3BWyPbaXAGr/VExLNiIIT/h LYaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=taZV27wSDVNvhZ5mUiS2fJIDtXrqZ59JBRzzw+Mxfww=; b=hsLN6SQcMc2DrMxY7Kek6w/z3koeLKqyc6PzbC7b1K9GVTisMLoKEana1I76nweOEP vZvV/m/wifVdcYUtcodentZAbS8SFimGNjLov5ygmeDQGJ4PI1aDcWaYxX2VE23kcTFI ldEbgBeEA5idkTR/J/0XiasVtHmfSBEEdMOCi/GIVFiEWr28mEkSyduHvoFG3Ws5E+Ie It1Qiun4cwe91SW0RfgOgETNNT3w9YfvSAJJGm3QZNs7pWyue4OmU5a++AOVrbNmsyQ8 1pg1/sYMTH6nXuj9QSxavXV1E81PoThzRmoCfTCMBIhtSRE2ByP0Kvoiz79HU4+wuB4h NIeg== X-Gm-Message-State: AFqh2kp/DNKC4/0f7leizUXd3HWzG+i0mXBGz3wgqfI6dc0BqlzmMoIo UWgPefAtMg5lIKcYsj3t0ZO7mhybxNsh1c0Zues= X-Google-Smtp-Source: AMrXdXvblnQzDf2p1vDtS+ZQW4e4fPvWA9kVRAaQM+QyYq3KofhZOiNsaCyhrt22P2kDSerpohCASX9eWtjhVS4Jv6Y= X-Received: by 2002:a1f:1c95:0:b0:3bc:9f94:d7f1 with SMTP id c143-20020a1f1c95000000b003bc9f94d7f1mr2012568vkc.21.1672085641548; Mon, 26 Dec 2022 12:14:01 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a05:612c:2428:b0:32a:5eaa:92e4 with HTTP; Mon, 26 Dec 2022 12:14:00 -0800 (PST) In-Reply-To: References: <20221011172437.36211-1-mvanb1@gmail.com> From: Paul B Mahol Date: Mon, 26 Dec 2022 21:14:00 +0100 Message-ID: To: Martijn van Beurden Subject: Re: [FFmpeg-devel] [PATCH v7 0/3] 32bps FLAC patches X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 12/19/22, Paul B Mahol wrote: > On 12/11/22, Martijn van Beurden wrote: >> Op do 1 dec. 2022 om 13:31 schreef Paul B Mahol : >>> >>> On 11/25/22, Paul B Mahol wrote: >>> > On 10/11/22, Martijn van Beurden wrote: >>> >> Recently libFLAC gained the ability (first released in FLAC 1.4.0) >>> >> to create FLAC files containing 32-bit int PCM samples. To >>> >> keep complexity reasonable, the choice was made to limit residuals >>> >> to 32-bit integers, which the encoder must make sure of. In case >>> >> the encoder cannot find any predictor of which the residuals fit >>> >> this limit, it must default to using a verbatim subframe. Tests have >>> >> shown that this does not happen often (<0.1% of subframes on a >>> >> music corpus of various styles). See also discussion here: >>> >> https://github.com/ietf-wg-cellar/flac-specification/pull/148 >>> >> >>> >> These two patches implement decoding and encoding following this >>> >> format. >>> >> >>> >> Changes since v1: >>> >> fix copy-paste error in encoder, several invocations of >>> >> lpc_encode_choose_datapath used wrong parameters, making FATE fail as >>> >> compression was less than it should be >>> >> >>> >> Changes since v2: >>> >> Rebased decoder part as it didn't apply anymore >>> >> >>> >> Changes since v3: >>> >> Moved put_golomb part to flacenc.c (as it is now quite specific to >>> >> FLAC) >>> >> and renamed put_sbits64 to put_sbits63 (and changed assert >>> >> accordingly) >>> >> >>> >> Changes since v4: >>> >> Fix check of decoded_buffer_33bps malloc. Fix reading of wasted bits >>> >> for 33bps subframe. Add fate test >>> >> >>> >> Changes since v5: >>> >> Slimmed down 32 bps fate flac test from 2 to 1 input file. Replaced >>> >> -strict -2 with -strict experimental in fate and encoder warning. >>> >> >>> >> Changes since v6: >>> >> Deduplicated function bodies with preprocessor macros in both >>> >> encoder and decoder, declared variables in loop body where possible >>> >> and changed ff_ctz to ff_ctzll where necessary >>> >> >>> >> Martijn van Beurden (3): >>> >> libavcodec/flacdec: Implement decoding of 32 bit-per-sample PCM >>> >> libavcodec/flacenc: Implement encoding of 32 bit-per-sample PCM >>> >> fate/flac: Add test of 32 bps encoding/decoding >>> >> >>> >> libavcodec/flac.c | 4 +- >>> >> libavcodec/flacdec.c | 218 ++++++++++++++++-- >>> >> libavcodec/flacenc.c | 480 >>> >> +++++++++++++++++++++++++++++++--------- >>> >> libavcodec/get_bits.h | 12 + >>> >> libavcodec/mathops.h | 9 + >>> >> libavcodec/put_bits.h | 7 + >>> >> libavcodec/put_golomb.h | 14 -- >>> >> tests/fate/flac.mak | 4 + >>> >> 8 files changed, 602 insertions(+), 146 deletions(-) >>> >> >>> >> -- >>> >> 2.30.2 >>> >> >>> > >>> > >>> > >>> > If this is OK, will apply soon. >>> >>> >>> Last time to say no to this patchset. >> >> I haven't had any comments the last few weeks, it still applies >> against current git and passed FATE. If you could apply it I would be >> much obliged. >> >> Kind regards, >> >> Martijn van Beurden >> > > Hi, if this still pastes FATE and compiles and applies I gonna apply > it in next 48h. > Pushed. Next time do not put tabs in non Makefile parts in patch or I will reject pushing it. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".