From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 40E0045402 for ; Sat, 28 Jan 2023 15:32:23 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6758368BE51; Sat, 28 Jan 2023 17:32:20 +0200 (EET) Received: from mail-vk1-f180.google.com (mail-vk1-f180.google.com [209.85.221.180]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5F19E68BD46 for ; Sat, 28 Jan 2023 17:32:14 +0200 (EET) Received: by mail-vk1-f180.google.com with SMTP id b81so3834837vkf.1 for ; Sat, 28 Jan 2023 07:32:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=OEGvC4XSNqqCtXYs62XK94juaC3pyCnBl/yz1dYpUDo=; b=jyrNFaGEIq6VEt8dNUwxzRRtUNgCAV+AtJuqd1CD1ZC7RFWfOJyJIBKfH3KRcN50dh zBR/oYls5g1ZmEW9WizZ8WOktL7QgYxx3ScoMbYSAAGp5ABAn840R/RRefwTgw5jL/Sc gyobWnB70cfxyIp2L3yTdZzfQrlqXDIqev1SXeCcocp/4g84Pu+80evpNf9vXJI2nDYc eRh+tGpAxih0UPFShEKNbIEn/A5EwbDjimAlskVU39eB25bgMjit+CR/1KLpj5cNXMdS czbhJzE2fse+EkuS+MUfIp8XzK9b81JAYJc8ck6GIYSYGHw8ycWny3KwW4moe0zFInAQ KvCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OEGvC4XSNqqCtXYs62XK94juaC3pyCnBl/yz1dYpUDo=; b=2Ka0YXo71MZWLoqEf12tEQftYiLV+U/nafx7gp53CcohV2gOmHrLVEebY2eJcpaJvC spcTm0MEC4AlOtESWuCKnPF9Ol1l40AgWirPetDxSnGnyru63Bzd3tMZsav3bSsE2eO1 JjXcGUslUwhYW14ra+BSR2GJBvHVINE41BrtfeiHACa6cwerId9X7I3y82vVlmyB1c8t somlpnHvGoBBcg9Og6hP1snEIfYsKLlYGE1M1eH1ejf8l2sfIooajKceynO5qvhH9kci YbLyRkZX+caC9ech6CSkLM3iWmGlsCdE4v9J0HiWWI3CW19187Vh93yCPwFFdGyFS8fV p3dg== X-Gm-Message-State: AO0yUKWG2Whl53Ejf97cRoc4FPYp5h1q0U28ej1RtC9RvygIiIentYSA U0ZOuRfielXJbX3+O26rNsV+Q56jVOSHrHJZZpJ/Ee4B X-Google-Smtp-Source: AK7set//PsiNOBFgkzBRLBqXcrqi4oqt0AAbmP/KHTQpBy9DySeAKO1qbyCTrocVdE6ojPc2cL43oaNEnhvSHn9tZN0= X-Received: by 2002:a1f:a1cc:0:b0:3ea:6a1:347a with SMTP id k195-20020a1fa1cc000000b003ea06a1347amr211630vke.21.1674919932623; Sat, 28 Jan 2023 07:32:12 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a05:612c:2428:b0:32a:5eaa:92e4 with HTTP; Sat, 28 Jan 2023 07:32:11 -0800 (PST) In-Reply-To: References: <8d713a21-f2f0-5c8d-fa93-0278965509e5@tiscali.it> <47ee718c-bce0-cffa-9c6a-2889a6547017@tiscali.it> From: Paul B Mahol Date: Sat, 28 Jan 2023 16:32:11 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] drawtext filter X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 1/28/23, Francesco Carusi wrote: > On 27/01/2023 18:31, Paul B Mahol wrote: >> On 1/27/23, Francesco Carusi wrote: >>> On 26/01/2023 17:37, Paul B Mahol wrote: >>>> On 1/26/23, Francesco Carusi wrote: >>>>> On 26/01/2023 14:21, Paul B Mahol wrote: >>>>>> On 1/26/23, Francesco Carusi wrote: >>>>>>> The drawtext reinit command is also used in the docs as an example >>>>>>> for >>>>>>> the sendcmd filter, so I thought it was fine to use commands in that >>>>>>> way. In my opinion it is also a convenient way to modify multiple >>>>>>> options at the same time. >>>>>>> Should the command match the name of a filter option instead? >>>>>>> >>>>>> Please do not top post. >>>>>> >>>>>> It is much better to use already existing options for commands that >>>>>> is >>>>>> more intuitive to users. Also multiple options can be set at runtime, >>>>>> there is no such limitation. >>>>> ok, I'm going to remove the "change" command and add commands that >>>>> match >>>>> the options that it included. >>>> Thanks, feel free to ask questions on #ffmpeg-devel irc channel. >>> I'm attaching the updated patch, I also updated the document at >>> https://github.com/yethie/FFmpeg/blob/master/drawtext/CHANGES.md >>> Thanks >> Amazing, I like demos! >> >> Could improve code style of newly added/changed lines? >> For example opening { put on separate line. So code style is in sync >> with rest of codebase. > Sure, I'll put opening { on a new line for functions, not for control > statements, like in the rest of the code. Is it fine? Yes. Thanks. >> The commands stuff does not need to use strcmp to detect if option >> value have been changed, you could avoid strcmp by just caching old >> value prior to calling function the picks new values, and after that >> just compare old with new and then if it differs call needed code. > I'll cache the numeric values. I think that caching string values is not > the preferred solution because in addition to the strcmp needed to check > the value, it would also need a strdup to cache the previous value, even > when the command does not involve those options. Does it sound reasonable? Yes. >>>>>>> On 26/01/2023 11:50, Paul B Mahol wrote: >>>>>>>> On 1/26/23, Francesco Carusi wrote: >>>>>>>>> Hi, I'm new to contributing to ffmpeg! >>>>>>>>> >>>>>>>>> I modified the drawtext filter to improve text rendering and add >>>>>>>>> some >>>>>>>>> features. You can find a high level description of the changes at >>>>>>>>> this >>>>>>>>> link: >>>>>>>>> >>>>>>>>> https://github.com/yethie/FFmpeg/blob/master/drawtext/CHANGES.md >>>>>>>>> >>>>>>>>> I'm also attaching the patch file. >>>>>>>>> I looked for the filter maintainer to discuss about the changes I >>>>>>>>> made >>>>>>>>> but it looks like there isn't any, am I correct? >>>>>>>>> >>>>>>>>> Please let me know if this is the right way to submit my >>>>>>>>> contribution. >>>>>>>> Why filter can not support normal commands for options? Like >>>>>>>> most/all >>>>>>>> other filters that have support for changing options values at >>>>>>>> runtime. >>>>>>>> >>>>>>>> The reinit and yours added change option(s) are very >>>>>>>> strange/inconvenient things to do. >>>>>>>> _______________________________________________ >>>>>>>> ffmpeg-devel mailing list >>>>>>>> ffmpeg-devel@ffmpeg.org >>>>>>>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >>>>>>>> >>>>>>>> To unsubscribe, visit link above, or email >>>>>>>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". >>>>>>> _______________________________________________ >>>>>>> ffmpeg-devel mailing list >>>>>>> ffmpeg-devel@ffmpeg.org >>>>>>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >>>>>>> >>>>>>> To unsubscribe, visit link above, or email >>>>>>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". >>>>>>> >>>>>> _______________________________________________ >>>>>> ffmpeg-devel mailing list >>>>>> ffmpeg-devel@ffmpeg.org >>>>>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >>>>>> >>>>>> To unsubscribe, visit link above, or email >>>>>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". >>>>> _______________________________________________ >>>>> ffmpeg-devel mailing list >>>>> ffmpeg-devel@ffmpeg.org >>>>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >>>>> >>>>> To unsubscribe, visit link above, or email >>>>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". >>>>> >>>> _______________________________________________ >>>> ffmpeg-devel mailing list >>>> ffmpeg-devel@ffmpeg.org >>>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >>>> >>>> To unsubscribe, visit link above, or email >>>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". >> _______________________________________________ >> ffmpeg-devel mailing list >> ffmpeg-devel@ffmpeg.org >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> >> To unsubscribe, visit link above, or email >> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".