From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4AC8644E30 for ; Thu, 26 Jan 2023 13:22:01 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C3AFF68B9B7; Thu, 26 Jan 2023 15:21:58 +0200 (EET) Received: from mail-vs1-f43.google.com (mail-vs1-f43.google.com [209.85.217.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BEAC268B25B for ; Thu, 26 Jan 2023 15:21:52 +0200 (EET) Received: by mail-vs1-f43.google.com with SMTP id v127so1796770vsb.12 for ; Thu, 26 Jan 2023 05:21:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=C+RvN8D+o7qidq+7jZ2o38u+6eOFPW1GtexHiu9WZsw=; b=eTpnAxLACsdL9rsTUgmvBm8oVGK0HmM7g7hFcOxTMJInKR17Gc1eeBHLetTnRvIDo/ ++3jthJr2ipX86kSiHQP7CJRYYMEj+zUl/WNd1PtkPBQUQgwGoDnv/+MAPKLI5NklgWc 8gWBwvfu5PK1jlMIJB3NYD4hviNydw21d+Zxitx4RbLVoHU20J6GZ6SAP3xfwEtk5YRl AG04JtTEiegFcFEVxK7MrUpILfQeVqkGOhzwYrlicJcYAGnPmxMyXUpXqL+kNx/yN8Zd /R2pky4iSgFCNVoQrYR2Y/WqvVhGftcSc1CxIiQLTOFnLMvbU0QdiHguFl9rNCbqE8Ci 5akw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=C+RvN8D+o7qidq+7jZ2o38u+6eOFPW1GtexHiu9WZsw=; b=xCVJ3MSVvqB8y+RHhYnnP397aIe96mVEeoTAqdcKinNMi+XbKsycXwP8wfIg0w7BvC UprI5cF3CrSG2HU5GzCKqHnGQon4c9/7J/VCXAq1jQddDHIqe64XOK7QDGCbq796KPNL lyzG3Ys0IVi6YnRgNRTHriJLCXfu9Jdr0yLiXrs6HWTmeqChXY7hU21fY5DC9HGDl8gI nOaYHiuPa4vE8+6FM7m1FWN27U0TqoE5vxSgxuVrWeywjrN6ix8ZSNzUY19ENepk7beK j0FljmYZGZBv2WeTWLTqofPJtCBIZojarCFfc8qs3zGmknYTxWyeMqdGk4Z/93MA/Bib onHA== X-Gm-Message-State: AFqh2krmW7m8JIPdx2hJGFdQe6SnvTdB1B868vLjgZoY4VwqdQNQ/W5y CVNAhXiM+JXWvS9eJmTMSxhrxvPSQxmG5BcOpkDDW3GV X-Google-Smtp-Source: AMrXdXuRPwj3lq+TYUXz96utGmGke6KEkeEO7eci1sexQ/cfVp+pNeBhtZ0uo2/FleOAP4BybeEjOOCCfU61rA8oySI= X-Received: by 2002:a05:6102:1510:b0:3d3:e5dc:e359 with SMTP id f16-20020a056102151000b003d3e5dce359mr4807518vsv.61.1674739311058; Thu, 26 Jan 2023 05:21:51 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a05:612c:2428:b0:32a:5eaa:92e4 with HTTP; Thu, 26 Jan 2023 05:21:50 -0800 (PST) In-Reply-To: References: <8d713a21-f2f0-5c8d-fa93-0278965509e5@tiscali.it> From: Paul B Mahol Date: Thu, 26 Jan 2023 14:21:50 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] drawtext filter X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 1/26/23, Francesco Carusi wrote: > The drawtext reinit command is also used in the docs as an example for > the sendcmd filter, so I thought it was fine to use commands in that > way. In my opinion it is also a convenient way to modify multiple > options at the same time. > Should the command match the name of a filter option instead? > Please do not top post. It is much better to use already existing options for commands that is more intuitive to users. Also multiple options can be set at runtime, there is no such limitation. > > On 26/01/2023 11:50, Paul B Mahol wrote: >> On 1/26/23, Francesco Carusi wrote: >>> Hi, I'm new to contributing to ffmpeg! >>> >>> I modified the drawtext filter to improve text rendering and add some >>> features. You can find a high level description of the changes at this >>> link: >>> >>> https://github.com/yethie/FFmpeg/blob/master/drawtext/CHANGES.md >>> >>> I'm also attaching the patch file. >>> I looked for the filter maintainer to discuss about the changes I made >>> but it looks like there isn't any, am I correct? >>> >>> Please let me know if this is the right way to submit my contribution. >> Why filter can not support normal commands for options? Like most/all >> other filters that have support for changing options values at >> runtime. >> >> The reinit and yours added change option(s) are very >> strange/inconvenient things to do. >> _______________________________________________ >> ffmpeg-devel mailing list >> ffmpeg-devel@ffmpeg.org >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> >> To unsubscribe, visit link above, or email >> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".