From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4A18C42BC6 for ; Wed, 30 Nov 2022 20:39:55 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id ABE5468B155; Wed, 30 Nov 2022 22:39:52 +0200 (EET) Received: from mail-ua1-f50.google.com (mail-ua1-f50.google.com [209.85.222.50]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DCBDD68A318 for ; Wed, 30 Nov 2022 22:39:46 +0200 (EET) Received: by mail-ua1-f50.google.com with SMTP id n9so3327758uao.13 for ; Wed, 30 Nov 2022 12:39:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=+6RSizUVrskOxCQdKQD3gCcIpwpjPYK2d0cqduhAqvI=; b=IiDoR7t4WyghD2djzqR2rreDto7YCMpF0ivlITSdsPY8tBphJbBApCMEgegtEN9lGs g3TI52y9f9FoikiBTNODgxFJRJgm8gd5Tefepl4WB9RG0a+elfnRr+xvMOIrwDdfvmjh fo5ZF/Iy+DW9gNxjHmMTI12enaBA7NS+1D7TGg0WzaZpHkIX9yA9eRjA5MsKZYNWgtc+ 9AVWc4By6ZXb8rqztqIGYHlY+hnJp9J3YO5EZubRfPNDYtcLT0J3YHQIlUqfPc5izCuC K6vC/usWgdY815UVn14DSkCI/NtHxih+UEI+OGB9CBwFNyoHkbAnWI7IjY0VPHXM9PHO XEvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+6RSizUVrskOxCQdKQD3gCcIpwpjPYK2d0cqduhAqvI=; b=5UeTTXRbogzpVuq6uu4iPYvpAMWXVyc5x3BNzzY4DuUo+GKpFwjYDeuCXaYuVPQ0Vs 7oGTAjaBRKgC6MzhfVeZHn4QJPmlC9AJ5kNC1wFSU5I9pYc+Q3nHZaYpjx1IRe+bf7Lj Ju4jhFXXQ3wFyR/5YU3is0vrztRO3oHgXKXvKOdDMvU5jTMmCjVBPfF+he69fxpYVE6j 6pUYCT4PTM43+poFnGFBkbs/W54hmqV2ylrrzFUtMGU4WrptT6Nq7wu6EMZCgXtrL9Ow yyk5YhtAJZPR50HnL2kGSIlyVtkoEGiBhlh/xQjUuSgPy9cZNjrcHwQYqZoV1pPDG/co 0ZlA== X-Gm-Message-State: ANoB5pm8tyz3sQgM8kzUXFkT0oE/568iGfNYY+LeMTIlbgADxIx2y1L8 V1Ir35n9GpbUfEcijJeLHZW4Vjn/kqp4Ir1PnZBHRHXU X-Google-Smtp-Source: AA0mqf7hqrLnYTiUGxTm0Y9UtrFMdCvpbuOBbdvH5ulhfq6TAD+WkhenFTR9nkMcXhoyP8OF0t33kOF3oMmBtvayYUo= X-Received: by 2002:ab0:64d1:0:b0:418:f948:259f with SMTP id j17-20020ab064d1000000b00418f948259fmr19563899uaq.38.1669840785245; Wed, 30 Nov 2022 12:39:45 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a05:612c:2428:b0:32a:5eaa:92e4 with HTTP; Wed, 30 Nov 2022 12:39:44 -0800 (PST) In-Reply-To: <20220911142721.30812-2-michael@niedermayer.cc> References: <20220911142721.30812-1-michael@niedermayer.cc> <20220911142721.30812-2-michael@niedermayer.cc> From: Paul B Mahol Date: Wed, 30 Nov 2022 21:39:44 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 2/5] avcodec/wavpack: Fix overflow in k=31 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 9/11/22, Michael Niedermayer wrote: > Untested with "non fuzzed" samples as i have no such file > Then create it. > Fixes: shift exponent 32 is too large for 32-bit type 'int' > Fixes: > 50930/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WAVPACK_fuzzer-6319201949712384 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavcodec/wavpack.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/wavpack.c b/libavcodec/wavpack.c > index 7aa1f65e17b..b4d19df7ea2 100644 > --- a/libavcodec/wavpack.c > +++ b/libavcodec/wavpack.c > @@ -126,7 +126,7 @@ static av_always_inline unsigned get_tail(GetBitContext > *gb, unsigned k) > if (k < 1) > return 0; > p = av_log2(k); > - e = (1 << (p + 1)) - k - 1; > + e = (1LL << (p + 1)) - k - 1; > res = get_bits_long(gb, p); > if (res >= e) > res = (res << 1) - e + get_bits1(gb); > -- > 2.17.1 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".