Re: [FFmpeg-devel] [PATCH 1/2] lavu/tx: rewrite internal code as a tree-based codelet constructor

From: Paul B Mahol <onemda@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/2] lavu/tx: rewrite internal code as a tree-based codelet constructor
Date: Tue, 25 Jan 2022 18:17:16 +0100
Message-ID: <CAPYw7P7-OY6hXxCC2T34XG0XyumgjtNWVP6uhyS47uY-OWLKBQ@mail.gmail.com> (raw)
In-Reply-To: <MuFq3r2--3-2@lynne.ee>

On Tue, Jan 25, 2022 at 11:46 AM Lynne <dev@lynne.ee> wrote:

> 21 Jan 2022, 09:51 by dev@lynne.ee:
>
> > 21 Jan 2022, 09:33 by dev@lynne.ee:
> >
> >> This commit rewrites the internal transform code into a constructor
> >> that stitches transforms (codelets).
> >> This allows for transforms to reuse arbitrary parts of other
> >> transforms, and allows transforms to be stacked onto one
> >> another (such as a full iMDCT using a half-iMDCT which in turn
> >> uses an FFT). It also permits for each step to be individually
> >> replaced by assembly or a custom implementation (such as an ASIC).
> >>
> >> Patch attached.
> >>
> >
> > Forgot that I disabled double and int32 transforms to speed up
> > testing, reenabled locally and on my github tx_tree branch.
> > Also removed some inactive debug code.
> > https://github.com/cyanreg/FFmpeg/tree/tx_tree
> >
>
> I fixed bugs and improved to code more, and I think it's ready
> for merging now.
> The rdft is no longer bound by any convention, and its
> scale may be changed by the user, eliminating after-transform
> multiplies that are used pretty much everywhere in our code.
>
> If someone (looks at Paul) gives it a test or converts a filter,
> would be nice. I've only tested it on my synthetic benchmarks:
> https://github.com/cyanreg/lavu_fft_test

Will try it once its applied. Thanks.

>
>
> I plan to push the patchset tomorrow unless there are comments.
> Mostly done with the aarch64's SIMD, patch coming soon, hopefully.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".